From patchwork Sun Oct 13 12:04:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Mader X-Patchwork-Id: 21605 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 06730C32F4 for ; Sun, 13 Oct 2024 12:05:19 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id D40CB6537B; Sun, 13 Oct 2024 14:05:17 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=collabora.com header.i=robert.mader@collabora.com header.b="QVHbqoB5"; dkim-atps=neutral Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 90B7F6536C for ; Sun, 13 Oct 2024 14:05:15 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; t=1728821112; cv=none; d=zohomail.com; s=zohoarc; b=Wb6OsfhEMJ7gC76uyC4Uj3Wxg6GLcjvpVYG2Q9ux6KwYaxUc3aeTzY2fllS5J+NePt6rj16Dt9+SCsrPiVf5idiqGgtg5hnz8NhvrAGXrYeA3fRCGgE0LkaYz6e/Hh5AuE6n4Lrg7D0yd0KlmiVc5CRc6ZM1/hFscvz4EjPgauE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1728821112; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=pLOmuWTxPmEYSafuuvwNcnnA2m45+Dcin75kOSTAC/Y=; b=gdAl2wkjab+hNUZ48kY/2xTqVsX7hUEZSLt3blba+DPSts15FjbL5dYCEMLpGZOlikCLS4ZVOH8qZkQROJZv47FlCM93mGohNPJMtfRn+dBv6TnJqk+ZVZH75xGa1eCFoPTY2FO81Sb2WfVwYWE34e2/usqJP3numQeM/4jg67g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=robert.mader@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1728821112; s=zohomail; d=collabora.com; i=robert.mader@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To; bh=pLOmuWTxPmEYSafuuvwNcnnA2m45+Dcin75kOSTAC/Y=; b=QVHbqoB5UQ1s3l4nZ2rqCCdZKNBXn54qx6Fp3GZvsYDSy4nci+nwuIH1WANZSu56 vsSIEzdfebdUM6U7buRjLfgpDs8GLUE4xpePIT+ZG8OfPCcgS3MEodvUhqVa3glB2Yb 9rZ6ZRFg3qbaCqI5VhcVXSuuGUoubS4HnkBpwPuc= Received: by mx.zohomail.com with SMTPS id 1728821110719366.98375270739166; Sun, 13 Oct 2024 05:05:10 -0700 (PDT) From: Robert Mader To: libcamera-devel@lists.libcamera.org Cc: Robert Mader Subject: [PATCH] libcamera: software_isp: Clear frameContexts on Stop() Date: Sun, 13 Oct 2024 14:04:50 +0200 Message-ID: <20241013120450.149837-1-robert.mader@collabora.com> X-Mailer: git-send-email 2.47.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Like the hardware pipelines do. Otherwise we might hit the following assert: "Frame context for ... has been overwritten by ...". Fixes: 04d171e6 ("libcamera: software_isp: Call Algorithm::queueRequest") Signed-off-by: Robert Mader --- src/ipa/simple/soft_simple.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp index b28c7039..ac8847cb 100644 --- a/src/ipa/simple/soft_simple.cpp +++ b/src/ipa/simple/soft_simple.cpp @@ -245,6 +245,7 @@ int IPASoftSimple::start() void IPASoftSimple::stop() { + context_.frameContexts.clear(); } void IPASoftSimple::queueRequest(const uint32_t frame, const ControlList &controls)