From patchwork Wed Oct 2 16:19:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 21479 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 49039BD80A for ; Wed, 2 Oct 2024 16:20:42 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 0A4A363532; Wed, 2 Oct 2024 18:20:42 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="kSp4vuln"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A48916352F for ; Wed, 2 Oct 2024 18:20:40 +0200 (CEST) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:b246:b33f:c662:8ae1]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A4F42320D; Wed, 2 Oct 2024 18:19:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1727885947; bh=KGv6J3Mw1x+xm5eUkpBW6wbhUyCGGCzzrLzCj7zFk9Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kSp4vulnGx8bBcQGjzT0vl9JI0p7lBOI9C9RYURTil2Bi96lY/CBChugribxxgmC4 CNNEPmpCvQxBQTylD/oUhXHec+EGQjV0e25h59RBGuQxMXwhrtS24EMs108Inv1X05 QfUYWhNT8+Bz3TiMK/xHVqXqumqCPG3HbuH4oNac= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH v1 8/8] [WIP] ipa: enable debug metadata by default Date: Wed, 2 Oct 2024 18:19:26 +0200 Message-ID: <20241002161933.247091-9-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241002161933.247091-1-stefan.klug@ideasonboard.com> References: <20241002161933.247091-1-stefan.klug@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Camshark currently doesn't support metadata values that are not there on every frame. Enable the debug metadata by default to test this series. Signed-off-by: Stefan Klug --- src/ipa/rkisp1/rkisp1.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp index 5b1ef0c372c6..fc95f733a2e8 100644 --- a/src/ipa/rkisp1/rkisp1.cpp +++ b/src/ipa/rkisp1/rkisp1.cpp @@ -328,6 +328,11 @@ void IPARkISP1::queueRequest(const uint32_t frame, const ControlList &controls) { IPAFrameContext &frameContext = context_.frameContexts.alloc(frame); context_.debugMetadata.checkForEnable(controls); + /* + * Todo: Remove the unconditional enable as soon as camshark supports + * metadata that is not available on every frame + */ + context_.debugMetadata.enable(); for (auto const &a : algorithms()) { Algorithm *algo = static_cast(a.get());