From patchwork Wed Sep 11 21:18:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 21242 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 7B37BC324C for ; Wed, 11 Sep 2024 21:18:42 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id CE7C863504; Wed, 11 Sep 2024 23:18:35 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="rf7wvaqq"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 82161618FB for ; Wed, 11 Sep 2024 23:18:28 +0200 (CEST) Received: from charm.tail69b4.ts.net (213-229-8-243.static.upcbusiness.at [213.229.8.243]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id AE02E83D; Wed, 11 Sep 2024 23:17:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1726089430; bh=8nXkTcGf9vdwvW3F6/FAMBsw3uFOD7oG4nZ2jAC0Ps0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rf7wvaqqEAMQnlIgxgqP7SClAd+DwEwl2d5yo3tORyxaBO6xL/uugvS/i5owU8GCy yWs1o0+zr3kygtnq9XX3ZLr+uf31C/ID/A7FuonwloLunjBq5XyGp7NWeIzIHV1F80 P2MQerjCYuJoCSW+mqt8bqfmso28z/2JYXFSPB+U= From: Kieran Bingham To: libcamera devel Cc: Kieran Bingham , Laurent Pinchart Subject: [PATCH v2 4/4] libcamera: pipeline: simple: Use MediaLink string helper Date: Wed, 11 Sep 2024 23:18:16 +0200 Message-ID: <20240911211816.73763-5-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240911211816.73763-1-kieran.bingham@ideasonboard.com> References: <20240911211816.73763-1-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Replace the open-coded implementation of a link representation with the operator<< overload string representation to simplify the code and unify appearance of reporting MediaLinks. Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart Signed-off-by: Kieran Bingham Reviewed-by: Stefan Klug --- src/libcamera/pipeline/simple/simple.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp index 1e7ec7d97255..2d205e9925ef 100644 --- a/src/libcamera/pipeline/simple/simple.cpp +++ b/src/libcamera/pipeline/simple/simple.cpp @@ -774,11 +774,8 @@ int SimpleCameraData::setupFormats(V4L2SubdeviceFormat *format, } LOG(SimplePipeline, Debug) - << "Link '" << source->entity()->name() - << "':" << source->index() - << " -> '" << sink->entity()->name() - << "':" << sink->index() - << " configured with format " << *format; + << "Link " << *link << ": configured with format " + << *format; } return 0;