From patchwork Wed Sep 11 21:18:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 21241 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id CF77CC324C for ; Wed, 11 Sep 2024 21:18:40 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 3987F63506; Wed, 11 Sep 2024 23:18:34 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="S0G08kSK"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 2009A634FB for ; Wed, 11 Sep 2024 23:18:27 +0200 (CEST) Received: from charm.tail69b4.ts.net (213-229-8-243.static.upcbusiness.at [213.229.8.243]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2A32BBEB; Wed, 11 Sep 2024 23:17:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1726089430; bh=KMPtBgA6ElkSiiL4dlJFYbbzxlxGy6+uguxmeIzSY/k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S0G08kSKrxk1AkGvKXamEORBvxMHFuJ0wQYjtyC4+vuuwXh+4TwYNfoxXKH06YBFF lIszsnfJhBLugaYDMKgbpdZ92HBI5+XKx5sqsBNqaY6dqyW+cbGmFc//HgFOGPDvo7 E4ZTv5cdztYXNe6gZ6EeKaP030RR189V3xzpGG5c= From: Kieran Bingham To: libcamera devel Cc: Kieran Bingham , Laurent Pinchart Subject: [PATCH v2 3/4] libcamera: media_device: Use MediaLink string helper Date: Wed, 11 Sep 2024 23:18:15 +0200 Message-ID: <20240911211816.73763-4-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240911211816.73763-1-kieran.bingham@ideasonboard.com> References: <20240911211816.73763-1-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Replace the two open-coded implementations of a link representation with the operator<< overload string representation to simplify the code and unify appearance of reporting MediaLinks. Reviewed-by: Laurent Pinchart Signed-off-by: Kieran Bingham Reviewed-by: Stefan Klug --- src/libcamera/media_device.cpp | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp index bd054552a093..d71dad74df70 100644 --- a/src/libcamera/media_device.cpp +++ b/src/libcamera/media_device.cpp @@ -818,20 +818,12 @@ int MediaDevice::setupLink(const MediaLink *link, unsigned int flags) if (ret) { ret = -errno; LOG(MediaDevice, Error) - << "Failed to setup link " - << source->entity()->name() << "[" - << source->index() << "] -> " - << sink->entity()->name() << "[" - << sink->index() << "]: " + << "Failed to setup link " << *link << ": " << strerror(-ret); return ret; } - LOG(MediaDevice, Debug) - << source->entity()->name() << "[" - << source->index() << "] -> " - << sink->entity()->name() << "[" - << sink->index() << "]: " << flags; + LOG(MediaDevice, Debug) << *link << ": " << flags; return 0; }