From patchwork Thu Sep 5 16:25:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 21166 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 88403BF415 for ; Thu, 5 Sep 2024 16:25:18 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1DBD1634EC; Thu, 5 Sep 2024 18:25:18 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="RDivcgmZ"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id CAF24634E3 for ; Thu, 5 Sep 2024 18:25:13 +0200 (CEST) Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 47DAE3E6 for ; Thu, 5 Sep 2024 18:24:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1725553440; bh=VeyMbtIOBmVq2alwV85YSVU9tXQDafkh1F25AlrJ7VU=; h=From:To:Subject:Date:In-Reply-To:References:From; b=RDivcgmZz/gsq1xivBZwSF+lHGmdLUC8J+CGxYf58FWsTRxPt0FpblooA2amkNUmA OjxGkg+KacEaU+OqZohaL/38b0LCKaR4AW5+WQkuqNiHmGVO3IQvS14DVAvnzu3291 OnZ0CpALligmBf9qsa8gKVqqVw9o6efqlH0za61Q= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Subject: [PATCH 2/2] qcam: viewfinder_qt: Render stopped icon on a black background Date: Thu, 5 Sep 2024 19:25:08 +0300 Message-ID: <20240905162508.4169-3-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.44.2 In-Reply-To: <20240905162508.4169-1-laurent.pinchart@ideasonboard.com> References: <20240905162508.4169-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" To match the black letterboxes, render the stoppid icon on a black background. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- src/apps/qcam/assets/feathericons/camera-off.svg | 2 +- src/apps/qcam/viewfinder_qt.cpp | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/apps/qcam/assets/feathericons/camera-off.svg b/src/apps/qcam/assets/feathericons/camera-off.svg index daa3e25f0c1d..2d36b59c8b52 100644 --- a/src/apps/qcam/assets/feathericons/camera-off.svg +++ b/src/apps/qcam/assets/feathericons/camera-off.svg @@ -1 +1 @@ - \ No newline at end of file + diff --git a/src/apps/qcam/viewfinder_qt.cpp b/src/apps/qcam/viewfinder_qt.cpp index 62b6f27fa23e..b0d63f3fa5ea 100644 --- a/src/apps/qcam/viewfinder_qt.cpp +++ b/src/apps/qcam/viewfinder_qt.cpp @@ -48,6 +48,8 @@ ViewFinderQt::ViewFinderQt(QWidget *parent) QPalette pal = palette(); pal.setColor(QPalette::Window, Qt::black); setPalette(pal); + + setAttribute(Qt::WA_OpaquePaintEvent, true); } ViewFinderQt::~ViewFinderQt() @@ -122,7 +124,6 @@ void ViewFinderQt::render(libcamera::FrameBuffer *buffer, Image *image) } } - setAttribute(Qt::WA_OpaquePaintEvent, true); update(); if (buffer) @@ -138,7 +139,6 @@ void ViewFinderQt::stop() buffer_ = nullptr; } - setAttribute(Qt::WA_OpaquePaintEvent, false); update(); } @@ -194,6 +194,7 @@ void ViewFinderQt::paintEvent(QPaintEvent *) else point.setY((height() - pixmap_.height()) / 2); + painter.drawRect(rect()); painter.drawPixmap(point, pixmap_); }