From patchwork Tue Aug 13 12:25:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaslo Ziska X-Patchwork-Id: 20901 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 3685BBDB13 for ; Tue, 13 Aug 2024 12:48:18 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id E8708633B5; Tue, 13 Aug 2024 14:48:17 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ziska.de header.i=@ziska.de header.b="aI1KpMgD"; dkim=permerror (0-bit key) header.d=ziska.de header.i=@ziska.de header.b="ejcKC+5V"; dkim-atps=neutral Received: from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de [81.169.146.220]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 92AAC63382 for ; Tue, 13 Aug 2024 14:48:16 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; t=1723553296; cv=none; d=strato.com; s=strato-dkim-0002; b=VCqnqBRR0EwLKq6C+HE4yYOeCSvTSGkhZTTZ0vhU6Bk52CWOu/A0WEH+2Il0CHsG9j dwzb3Gm2jS09Cbcox+kvCsc4wIC1j7RDrGkEsLwpzFp/q4rtRjSb4+5no8mmLKGiW8Td DbBAnm1uoYFRfoeYzrH8LO70/mng9Nc16DEPe5gXW+sw2ki3d/B6HRigZPizGcHsjOxc Q+9JR//deMf5fRGAHa4u+UwFIpC4XwCL8Nu2+/Vgh+FKUpyLFGUKRKPbwxOEr805cdgU Pre52ArYlfsmL2x/Vd+8FYk9y3CNd8hYyBUyvyD7e/Bf9HmnNNtRF7oCpKCJLsBjJqz2 02sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1723553296; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=VrgI6MUBEQZ4SixjjRaGQ1/YDwuso5jYmEdUtg1ppXs=; b=qaAOhF7/mMUchFrVE/VV80KoHpEM42sdjBjyHBkhD2qjHfthvGFotwlmZuRPELGHdL pt9T0QjHHw4X4acccZgO9wi9Km1GQu7jERvdc5m5KGIRdZ4bpGo5m4xSD8+JEo8/Ds9C 2ORc2g2hxBgR0sQqF1VGpbfpUZbU7LpzJ7RJ9pKLOhaaahM1UoXjrefyOE+OQjQatkCe 4F6r7v6eDDWJ1FF28ioox9A1gtx39TeVFEnVFM8qYhci+dwjjZOfau7oBph4oQnPkC7y TaQGeWQeGAjVIZyNKJ1rflm69FKuYOfcH3fJRfhmJjlpPk11Fu6J3q/R2HIcbgis+Qv9 DeMg== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1723553296; s=strato-dkim-0002; d=ziska.de; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=VrgI6MUBEQZ4SixjjRaGQ1/YDwuso5jYmEdUtg1ppXs=; b=aI1KpMgDFJdGbePhSqx0OX+gnwTRuICZxW6Tknv+uKQWmmsHtZFqvPlYIJaWqZeXth gtZOT2641Cn7o7S9KpeLuzzMWpxjDtj4UC+h2W+VWCTDAXgM2VHfd3G1Yv6pXAu39+OD EWAc0mWwU77/JgaEQuskFaiEMpK4GDGmNWOpzz3fIAe7APGwBWyRb8TvjZlFeCMCxefl Ff/Tl8/v/0EgEqqEzJcza4LZT8zJKo0edO6XC4mgB1kyLBe/DfEFZNsqMR+zWTYeN1KR DCS7vCO8ETMJdeugEQQu9s3etnsHKRy+3hqO8whdwip0S7vSD1Ewj6kd5ochc4sgd6jS wDAw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1723553296; s=strato-dkim-0003; d=ziska.de; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=VrgI6MUBEQZ4SixjjRaGQ1/YDwuso5jYmEdUtg1ppXs=; b=ejcKC+5VJJNaeyzUL94Ncc0UOq92HMz18mhq/QWFTmMpoYzKL6tGCtqJJ2/Ay+NifE BRmjbO3DJDvsqUt+ibDw== X-RZG-AUTH: ":Jm0XeU+IYfb0x77LHmrjN5Wlb7TBwusDqIM6Hizy8VdfzvKi4yoFC9cGhoqwVPJQb1HfVSED9d9Z5psVXjkhV67rRpA=" Received: from archlinux.fritz.box by smtp.strato.de (RZmta 51.1.0 AUTH) with ESMTPSA id zb9f0a07DCmGU7g (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Tue, 13 Aug 2024 14:48:16 +0200 (CEST) From: Jaslo Ziska To: libcamera-devel@lists.libcamera.org Cc: Jaslo Ziska Subject: [PATCH v2 1/3] gstreamer: Remove auto-focus-mode property from device provider Date: Tue, 13 Aug 2024 14:25:05 +0200 Message-ID: <20240813124722.22425-2-jaslo@ziska.de> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240813124722.22425-1-jaslo@ziska.de> References: <20240813124722.22425-1-jaslo@ziska.de> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The device provider is not supposed to have control properties, remove the auto-focus-mode property which was introduced by accident. Fixes: 5a142438b025 ("gstreamer: Add enable_auto_focus option to the GStreamer plugin") Signed-off-by: Jaslo Ziska Reviewed-by: Laurent Pinchart --- src/gstreamer/gstlibcameraprovider.cpp | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/src/gstreamer/gstlibcameraprovider.cpp b/src/gstreamer/gstlibcameraprovider.cpp index 4fb1b007..5da96ea3 100644 --- a/src/gstreamer/gstlibcameraprovider.cpp +++ b/src/gstreamer/gstlibcameraprovider.cpp @@ -33,7 +33,6 @@ GST_DEBUG_CATEGORY_STATIC(provider_debug); enum { PROP_DEVICE_NAME = 1, - PROP_AUTO_FOCUS_MODE = 2, }; #define GST_TYPE_LIBCAMERA_DEVICE gst_libcamera_device_get_type() @@ -43,7 +42,6 @@ G_DECLARE_FINAL_TYPE(GstLibcameraDevice, gst_libcamera_device, struct _GstLibcameraDevice { GstDevice parent; gchar *name; - controls::AfModeEnum auto_focus_mode = controls::AfModeManual; }; G_DEFINE_TYPE(GstLibcameraDevice, gst_libcamera_device, GST_TYPE_DEVICE) @@ -60,7 +58,6 @@ gst_libcamera_device_create_element(GstDevice *device, const gchar *name) g_assert(source); g_object_set(source, "camera-name", GST_LIBCAMERA_DEVICE(device)->name, nullptr); - g_object_set(source, "auto-focus-mode", GST_LIBCAMERA_DEVICE(device)->auto_focus_mode, nullptr); return source; } @@ -87,9 +84,6 @@ gst_libcamera_device_set_property(GObject *object, guint prop_id, case PROP_DEVICE_NAME: device->name = g_value_dup_string(value); break; - case PROP_AUTO_FOCUS_MODE: - device->auto_focus_mode = static_cast(g_value_get_enum(value)); - break; default: G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec); break; @@ -129,15 +123,6 @@ gst_libcamera_device_class_init(GstLibcameraDeviceClass *klass) (GParamFlags)(G_PARAM_STATIC_STRINGS | G_PARAM_WRITABLE | G_PARAM_CONSTRUCT_ONLY)); g_object_class_install_property(object_class, PROP_DEVICE_NAME, pspec); - - pspec = g_param_spec_enum("auto-focus-mode", - "Set auto-focus mode", - "Available options: AfModeManual, " - "AfModeAuto or AfModeContinuous.", - gst_libcamera_auto_focus_get_type(), - static_cast(controls::AfModeManual), - G_PARAM_WRITABLE); - g_object_class_install_property(object_class, PROP_AUTO_FOCUS_MODE, pspec); } static GstDevice *