From patchwork Wed Jul 31 13:59:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 20733 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D8962BDC71 for ; Wed, 31 Jul 2024 14:00:09 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8383363378; Wed, 31 Jul 2024 16:00:09 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="HTFAuh4B"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9FB0B6337E for ; Wed, 31 Jul 2024 16:00:03 +0200 (CEST) Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9FC8BF85 for ; Wed, 31 Jul 2024 15:59:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1722434355; bh=Knu62KiGoHOCCQU/vXuC0BXDHWrzsPsQ2qf1DsZw6QM=; h=From:To:Subject:Date:In-Reply-To:References:From; b=HTFAuh4BkktOmblQ9Y/PYwrEdReXx+p1e+VYMWjCcgQ2vWA8fTyNWHeBOiIZZc7Xl MJ/938fx6ukyLpS3JmAxt6tdbk7VC4VrHWb1b9gPP2gYfLIYDOLb26fo/L9V1mkP5U 1D0rINhv1VEVXdsHmkfBtjOjnzw1uQnfYlUVFLLE= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Subject: [PATCH v2 4/4] libcamera: software_isp: Remove file seal TODO item Date: Wed, 31 Jul 2024 16:59:36 +0300 Message-ID: <20240731135936.2105-5-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.44.2 In-Reply-To: <20240731135936.2105-1-laurent.pinchart@ideasonboard.com> References: <20240731135936.2105-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The file seal TODO item has been addressed. Remove it. Signed-off-by: Laurent Pinchart Reviewed-by: Milan Zamazal Reviewed-by: Kieran Bingham Reviewed-by: Hans de Goede --- src/libcamera/software_isp/TODO | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/src/libcamera/software_isp/TODO b/src/libcamera/software_isp/TODO index 6bdc590531ca..9978afc0317b 100644 --- a/src/libcamera/software_isp/TODO +++ b/src/libcamera/software_isp/TODO @@ -1,22 +1,3 @@ -1. Setting F_SEAL_SHRINK and F_SEAL_GROW after ftruncate() - ->> SharedMem::SharedMem(const std::string &name, std::size_t size) ->> : name_(name), size_(size), mem_(nullptr) ->> ->> ... ->> ->> if (ftruncate(fd_.get(), size_) < 0) ->> return; -> -> Should we set the GROW and SHRINK seals (in a separate patch) ? - -Yes, this can be done. -Setting F_SEAL_SHRINK and F_SEAL_GROW after the ftruncate() call above could catch -some potential errors related to improper access to the shared memory allocated by -the SharedMemObject. - ---- - 2. Reconsider stats sharing >>> +void SwStatsCpu::finishFrame(void)