From patchwork Tue Jul 23 14:17:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Semkowicz X-Patchwork-Id: 20697 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C7BB8C323E for ; Tue, 23 Jul 2024 14:18:30 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 960D16336F; Tue, 23 Jul 2024 16:18:29 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=thaumatec-com.20230601.gappssmtp.com header.i=@thaumatec-com.20230601.gappssmtp.com header.b="UHvvMEoq"; dkim-atps=neutral Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7E5BC619A1 for ; Tue, 23 Jul 2024 16:18:27 +0200 (CEST) Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-59589a9be92so5216083a12.2 for ; Tue, 23 Jul 2024 07:18:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thaumatec-com.20230601.gappssmtp.com; s=20230601; t=1721744307; x=1722349107; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ckne10Pw7G3MjSIZUsCyjric8DWTB7cc8Hyvg8KjZ4g=; b=UHvvMEoqwv80bPVCqVu0+U+HwKKfzHGH58vviSVeLPRO+p/0fJrg8S0H0ax3h12Ds+ VxJlNJkbXWL3U2XSf1KIXbcNOywHCnAOoNy7RJD/BILh6OGebKm8UcxKQW5WrLAIssEE fGaEmRCGWtJiqbSULyy2NwY2pocPPyyeHmNYYm+3gfsP85K7suEBrxr58EuRZIo26FmC TUVdjYw8TfqctUDTljd+0U5wSP21q8DE3fwIlJyjWo1QOaLkya/yvhFa9doo5GwtM2OM Yx0V6RX5+gMLoX09dLbdhNEb5YE5E9LCiFXPdEcfYXsSLhzdk+gkWfpQVuJRK3XpYR24 wxCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721744307; x=1722349107; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ckne10Pw7G3MjSIZUsCyjric8DWTB7cc8Hyvg8KjZ4g=; b=cyOXb97eFLYfOLHlprhEl3TcgUjMZKskiH2nwQMlHL39ZvG6VhWHVMgSyal9Df06lt w3srxh4SyEvt8nxPHljca0cb6CBTUDz2gx4TsMPtO1ybKoNZGaOcMPTiEykn4+823OYa SLhxShDZHhUT22aeG6qO0Sl3Q7Qg/ikVH+8wmQy3dXtTqVCDccMuhb+UY46tFqGDoZN2 ImkS6202cD8xpuTO+u1dPeScpD4wY7ivK2CiPdIWdBH4sOSfLBOW1vZ8KGWaAbKYml27 vviJpICzUa9qviIHzGqOYhNpYuAyGoNTKzy+PzPnQ3nGgTDTvboJqCdAAfJEjczEJNkN 3Nrw== X-Gm-Message-State: AOJu0YxHQAPM/33BRByv5SX7FeHzSiysH9jDpeU5g2RzGyqrgjKI5HoA XHOc2s4kFm0Mqwzuzi1sU7sl0A9fR8SKK1RFamLYIwGks/uJUnLGG9jT46Yz6Kvnf/nFa7o15cX L X-Google-Smtp-Source: AGHT+IFhXd3dxyxkePAK1E3M/+k37CsbYVJPjB6lAw7xnZyANFCmMYM5bKee2jwLh7EDeXoJi2hdFg== X-Received: by 2002:a50:c31d:0:b0:57d:357d:9909 with SMTP id 4fb4d7f45d1cf-5a943b098cdmr1875170a12.33.1721744306826; Tue, 23 Jul 2024 07:18:26 -0700 (PDT) Received: from localhost.localdomain ([91.90.172.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5a30c2f8a5fsm7537595a12.62.2024.07.23.07.18.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jul 2024 07:18:26 -0700 (PDT) From: Daniel Semkowicz To: libcamera-devel@lists.libcamera.org Cc: Daniel Semkowicz Subject: [PATCH v1] libipa: camera_sensor_helper: Add OV5675 black level Date: Tue, 23 Jul 2024 16:17:58 +0200 Message-ID: <20240723141814.76823-1-dse@thaumatec.com> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add black level value for OV5675 camera. According to datasheet, default value is 0x10, 10 bits width. Signed-off-by: Daniel Semkowicz Reviewed-by: Kieran Bingham --- src/ipa/libipa/camera_sensor_helper.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp index a1339c83..79608c00 100644 --- a/src/ipa/libipa/camera_sensor_helper.cpp +++ b/src/ipa/libipa/camera_sensor_helper.cpp @@ -601,6 +601,8 @@ class CameraSensorHelperOv5675 : public CameraSensorHelper public: CameraSensorHelperOv5675() { + /* From datasheet: 0x10 at 10bits. */ + blackLevel_ = 1024; gainType_ = AnalogueGainLinear; gainConstants_.linear = { 1, 0, 0, 128 }; }