From patchwork Tue Jul 9 14:39:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Scally X-Patchwork-Id: 20618 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 67A5CBDB1C for ; Tue, 9 Jul 2024 14:39:30 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 059536337F; Tue, 9 Jul 2024 16:39:25 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="FdChxek9"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0E249619C1 for ; Tue, 9 Jul 2024 16:39:20 +0200 (CEST) Received: from mail.ideasonboard.com (cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 6C1A716C3; Tue, 9 Jul 2024 16:38:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1720535927; bh=kGF5kMqdHRI9qnD49DVIAMqqroOG26NPu6xcaqD1H5E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FdChxek9JCWFH66xIMWZiWINkGjQAxeQnUh+ds5kdQtuxRXOtwP+ZmDTY6az8BAFC FqgiU8kEhxnk6aIqdDZVUVpdZTYf5G/UwQmNTbvQr5OYqDLE9a5dyxJidLGvOm3CQC Av3bIC8KypZjj5AqBOOV0H1th2tOD2TPMpmMQ1Zk= From: Daniel Scally To: libcamera-devel@lists.libcamera.org Cc: Jacopo Mondi , Daniel Scally , Umang Jain , Kieran Bingham Subject: [PATCH v4 01/13] libcamera: mali-c55: Limit max size to sensor resolution Date: Tue, 9 Jul 2024 15:39:01 +0100 Message-Id: <20240709143913.3276983-2-dan.scally@ideasonboard.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240709143913.3276983-1-dan.scally@ideasonboard.com> References: <20240709143913.3276983-1-dan.scally@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Jacopo Mondi The Mali C55 ISP cannot upscale. The maximum allowed output size is the sensor's resolution. For RAW streams this is already handled in adjustRawSizes(), while for processed streams the maximum allowed resolution was wrongly set to the ISP maximum output size (8192x8192). Reviewed-by: Daniel Scally Reviewed-by: Umang Jain Reviewed-by: Kieran Bingham Signed-off-by: Jacopo Mondi Signed-off-by: Daniel Scally --- src/libcamera/pipeline/mali-c55/mali-c55.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp index 45c71c1d..1c1fef23 100644 --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp @@ -342,7 +342,11 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate() rawConfig = &config; } - Size maxSize = kMaliC55MaxSize; + /* + * The C55 can not upscale. Limit the configuration to the ISP + * capabilities and the sensor resolution. + */ + Size maxSize = kMaliC55MaxSize.boundedTo(data_->resolution()); if (rawConfig) { /* * \todo Take into account the Bayer components ordering once