From patchwork Wed Jul 3 17:31:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 20540 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 1C5CFBD87C for ; Wed, 3 Jul 2024 17:31:45 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id BB88062E25; Wed, 3 Jul 2024 19:31:43 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="gDDHoTI3"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5894762C95 for ; Wed, 3 Jul 2024 19:31:42 +0200 (CEST) Received: from pendragon.ideasonboard.com (117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 014123E6; Wed, 3 Jul 2024 19:31:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1720027874; bh=nRSc0xcANvdAH4gY+ZIlqWWfHxwSuDMHj1rIZJAn2tw=; h=From:To:Cc:Subject:Date:From; b=gDDHoTI3YYgTACL7Iip3DrxJ6uk2QB/Pk+JmgBza1pRU6mnSuxA56arIIsVVyheF7 4wR3ByUNO1ktjgjDUaSnzdG7sMOKuSS3xqZBLrh9h4z0CMOmIHolNQgXogWZCb//I3 v9Q/oGUValzHNbhJRG2MyZ3AGqpgimObRTg9Qnns= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH] ipa: rkisp1: blc: Drop [[maybe_unused]] attribute Date: Wed, 3 Jul 2024 20:31:20 +0300 Message-ID: <20240703173120.9995-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.44.2 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The context parameter of the BlackLevelCorrection::init() function is used. Drop the [[maybe_unused]] attribute. Fixes: 50c28e135100 ("ipa: rkisp1: blc: Query black levels from camera sensor helper") Signed-off-by: Laurent Pinchart Reviewed-by: Umang Jain Reviewed-by: Stefan Klug Reviewed-by: Paul Elder --- I'm starting to wonder if we should omit parameter names for parameters that are never used, and use [[maybe_unused]] for parameters that are conditionally unused, as recommended by https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rf-unused. --- src/ipa/rkisp1/algorithms/blc.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) base-commit: 196abb8d1d6e0fe9d190315e72a85eb12d16a554 diff --git a/src/ipa/rkisp1/algorithms/blc.cpp b/src/ipa/rkisp1/algorithms/blc.cpp index 4b00034cc434..464a0e066dd4 100644 --- a/src/ipa/rkisp1/algorithms/blc.cpp +++ b/src/ipa/rkisp1/algorithms/blc.cpp @@ -52,8 +52,7 @@ BlackLevelCorrection::BlackLevelCorrection() /** * \copydoc libcamera::ipa::Algorithm::init */ -int BlackLevelCorrection::init([[maybe_unused]] IPAContext &context, - const YamlObject &tuningData) +int BlackLevelCorrection::init(IPAContext &context, const YamlObject &tuningData) { std::optional levelRed = tuningData["R"].get(); std::optional levelGreenR = tuningData["Gr"].get();