From patchwork Wed Jun 26 14:03:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 20421 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 3D8F0BDB1D for ; Wed, 26 Jun 2024 14:03:39 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2D84862B6A; Wed, 26 Jun 2024 16:03:36 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="W9rVQ0TD"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9212A62B6C for ; Wed, 26 Jun 2024 16:03:25 +0200 (CEST) Received: from localhost.localdomain (93-61-96-190.ip145.fastwebnet.it [93.61.96.190]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 47D7FFD6; Wed, 26 Jun 2024 16:03:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1719410582; bh=X6gJynBagqREg3jCj3k+tgV+GY8axntkmX7HpkzqXvc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=W9rVQ0TDEjwxuD9+PUWG6HlpZxDNMwpK3lWM+GoT+zAvQyzk22l+QNeBEYowRwnRC OU5iCjUHnJPBQWvTRMZVokYBLNzFRO/5X0BOSQtyFLlpBsEl1Ldqkz9h6tqOJJkEaY +rUp+XJqzTZC/abUNV8J8KjVXjQCScWM3/Ml0PNU= From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org Cc: Jacopo Mondi Subject: [PATCH v3 9/9] libcamera: mali-c55: Propagate CSI-2 format to ISP Date: Wed, 26 Jun 2024 16:03:05 +0200 Message-ID: <20240626140309.50052-10-jacopo.mondi@ideasonboard.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240626140309.50052-1-jacopo.mondi@ideasonboard.com> References: <20240626140309.50052-1-jacopo.mondi@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The latest version of the Mali C55 driver has changed the format accepted by the ISP sink pad to be the 20-bit wide. The CSI-2 receiver handles the format expansion internally by propagating the sensor produced format from its sink to the 20-bit expanded version on its source pad. Instead of re-applying the sensor format to the CSI-2 receiver source pad (which is now an invalid operation) read from there the format propagated by the driver internally and further propagate it to the ISP subdevice. Signed-off-by: Jacopo Mondi Reviewed-by: Umang Jain --- Latest version of the Mali C55 support https://lore.kernel.org/linux-media/20240529152858.183799-1-dan.scally@ideasonboard.com/ --- src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp index 28ad0172658c..156560c1d9bf 100644 --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp @@ -768,7 +768,7 @@ int PipelineHandlerMaliC55::configure(Camera *camera, if (ret) return ret; - ret = data->csi_->setFormat(1, &subdevFormat); + ret = data->csi_->getFormat(1, &subdevFormat); if (ret) return ret; }