From patchwork Thu Jun 13 08:33:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 20287 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 85AFDC3237 for ; Thu, 13 Jun 2024 08:36:47 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 4399365491; Thu, 13 Jun 2024 10:36:47 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="s4lyZhYq"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 193D365491 for ; Thu, 13 Jun 2024 10:36:45 +0200 (CEST) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:3fed:9d83:54f9:6b93]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 35F89BEB; Thu, 13 Jun 2024 10:36:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1718267791; bh=FmJxQYeUR4Bl8VI/NfYDxrq007y1nTNet68JV+aXpDk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=s4lyZhYqMeDcgZu/gW5Sezcjr8siHXuGmcflcc2NsXD0hCCDlVp1zA/tmX/qCHQM6 iu94HshqLtb5BCrHagCm5Ac9+A/Vzo5/sjLfFczpt7CNM74XL91y1jiRsa+96B2ZVC I+m2lL3hHEJAT8u8OWaheYBjZSQA4g9N/sReFlt0= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH 3/3] ipa: rkisp1: cproc: Drop incorrect [[maybe_unused]] Date: Thu, 13 Jun 2024 10:33:20 +0200 Message-ID: <20240613083533.855791-4-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240613083533.855791-1-stefan.klug@ideasonboard.com> References: <20240613083533.855791-1-stefan.klug@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" A few function parameters are marked with [[maybe_unused]] but are actually used. Drop the attribute. Signed-off-by: Stefan Klug Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- src/ipa/rkisp1/algorithms/cproc.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ipa/rkisp1/algorithms/cproc.cpp b/src/ipa/rkisp1/algorithms/cproc.cpp index 9f400a52dd96..ef0931b20453 100644 --- a/src/ipa/rkisp1/algorithms/cproc.cpp +++ b/src/ipa/rkisp1/algorithms/cproc.cpp @@ -54,7 +54,7 @@ int convertContrastOrSaturation(const float v) /** * \copydoc libcamera::ipa::Algorithm::init */ -int ColorProcessing::init([[maybe_unused]] IPAContext &context, +int ColorProcessing::init(IPAContext &context, [[maybe_unused]] const YamlObject &tuningData) { auto &cmap = context.ctrlMap; @@ -69,7 +69,7 @@ int ColorProcessing::init([[maybe_unused]] IPAContext &context, /** * \copydoc libcamera::ipa::Algorithm::configure */ -int ColorProcessing::configure([[maybe_unused]] IPAContext &context, +int ColorProcessing::configure(IPAContext &context, [[maybe_unused]] const IPACameraSensorInfo &configInfo) { auto &cproc = context.activeState.cproc; @@ -85,7 +85,7 @@ int ColorProcessing::configure([[maybe_unused]] IPAContext &context, * \copydoc libcamera::ipa::Algorithm::queueRequest */ void ColorProcessing::queueRequest(IPAContext &context, - [[maybe_unused]] const uint32_t frame, + const uint32_t frame, IPAFrameContext &frameContext, const ControlList &controls) {