From patchwork Tue Jun 11 21:20:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 20266 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C0353C3293 for ; Tue, 11 Jun 2024 21:21:29 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id AB8926546D; Tue, 11 Jun 2024 23:21:27 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="t853/Tsz"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id BD72561A26 for ; Tue, 11 Jun 2024 23:21:23 +0200 (CEST) Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C587EA9A; Tue, 11 Jun 2024 23:21:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1718140871; bh=BY1KvL2omlGgZG8+YS/cug+bFLeSdBplKzmoA0SinE4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=t853/TszN8QmyM8IlCpKtFHLZPqNuB4aLFcAGyr13u8d5AKVaLAVV4tzB1diUMqlX yfE0XA4y7EAa15NO6qzC8orMFLt55Zu+MlxzPBBmuRbkDqIIwBtq/wrkCIbdJBFttK fiPn/YTeXhJ4OxFd/hxye3GFHgjpxeVG1NPGwH2w= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH 2/6] ipa: rkisp1: goc: Drop incorrect [[maybe_unused]] Date: Wed, 12 Jun 2024 00:20:57 +0300 Message-ID: <20240611212101.14313-3-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.44.2 In-Reply-To: <20240611212101.14313-1-laurent.pinchart@ideasonboard.com> References: <20240611212101.14313-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" A few function parameters are marked with [[maybe_unused]] but are actually used. Drop the attribute. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Klug --- src/ipa/rkisp1/algorithms/goc.cpp | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/ipa/rkisp1/algorithms/goc.cpp b/src/ipa/rkisp1/algorithms/goc.cpp index fc5ad9f9177e..01331b653c27 100644 --- a/src/ipa/rkisp1/algorithms/goc.cpp +++ b/src/ipa/rkisp1/algorithms/goc.cpp @@ -48,8 +48,7 @@ const float kDefaultGamma = 2.2f; /** * \copydoc libcamera::ipa::Algorithm::init */ -int GammaOutCorrection::init([[maybe_unused]] IPAContext &context, - [[maybe_unused]] const YamlObject &tuningData) +int GammaOutCorrection::init(IPAContext &context, const YamlObject &tuningData) { if (context.hw->numGammaOutSamples != RKISP1_CIF_ISP_GAMMA_OUT_MAX_SAMPLES_V10) { @@ -81,8 +80,7 @@ int GammaOutCorrection::configure(IPAContext &context, /** * \copydoc libcamera::ipa::Algorithm::queueRequest */ -void GammaOutCorrection::queueRequest([[maybe_unused]] IPAContext &context, - [[maybe_unused]] const uint32_t frame, +void GammaOutCorrection::queueRequest(IPAContext &context, const uint32_t frame, IPAFrameContext &frameContext, const ControlList &controls) { @@ -102,9 +100,9 @@ void GammaOutCorrection::queueRequest([[maybe_unused]] IPAContext &context, /** * \copydoc libcamera::ipa::Algorithm::prepare */ -void GammaOutCorrection::prepare([[maybe_unused]] IPAContext &context, +void GammaOutCorrection::prepare(IPAContext &context, [[maybe_unused]] const uint32_t frame, - [[maybe_unused]] IPAFrameContext &frameContext, + IPAFrameContext &frameContext, rkisp1_params_cfg *params) { ASSERT(context.hw->numGammaOutSamples ==