From patchwork Wed May 8 08:04:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 20015 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 8CB27BDE6B for ; Wed, 8 May 2024 08:04:13 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id DE59263440; Wed, 8 May 2024 10:04:10 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="Z3eonQvg"; dkim-atps=neutral Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 793E66342D for ; Wed, 8 May 2024 10:04:04 +0200 (CEST) Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-41b782405bbso28319995e9.1 for ; Wed, 08 May 2024 01:04:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1715155444; x=1715760244; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Jm5/HVAZRKYn81evUSPhEi4s4e/rvffsxRQpv6ayiLM=; b=Z3eonQvgnUOgFZPcbvdzCEZAosda8oJaSkQgZbF7BpoD0n+iSLCZSFALTbOoeo7sw6 7qPJP3t8f99U8bb+QLLVvyfhv7/gQ45311RPAaEbcGVLZi4NKuQZmqnwXhAwGERfPQYe h61jRfe3qiLSM8FfvFs5lPC0xBSB+xIYtizaoBfgV7J9kpbl4Eg6t+1QdYCZ+0HZm7vz Fb+F9K5fvxb83buIzjrieozMZmiADtdPARkXdIy7kNjyMydNGsEdlUDtXQXm/ekR7nSF h0HPpSkWo7ssdf8enJTmfTUQN7V/DLTUUtrZGzR0VzH486aQX1o/aL1KNfLw3Du5FhRL wgWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715155444; x=1715760244; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Jm5/HVAZRKYn81evUSPhEi4s4e/rvffsxRQpv6ayiLM=; b=RgE1A7o5Qpy6cc+W3Pt0YSaANhTwQLjAt/PP8LszvkWqOaiIY9Ltnl2DPgKeJK+dL9 /+NogCDSfOoDbC1jkbPcQToYlZmmpcwXsY4T6/CZIvwOW2rXpr47u9z43q0yEPzcpOjX zbwH3PEXpD4sbTWn+BySA4brqI9MyK4PDUa5pqcY9tzxR+9X1AF7uzTLSv1OUR1K28ay I3vvi0FVthZjdFf3r8NqNiNDS0K88dUuiRgkEQXvcAdaAodHUWgTeWxdyaw0LJeAtRiX 1hjGV1jYUf/rndH5QsBnZ25111y68DY7kw+kgsFmdgOMf24IfTmUyXv9WUdX3SC3mRy1 oKKQ== X-Gm-Message-State: AOJu0YzkJfE2JIdL5simSIzcJ/VBp+i7Cf4fepvL/F/nXDMO02E3srDR iDye0rYmHbfBInB4V2OcY6MTszs8xs6Y7a7MmgCJuh0tIESz0AzetMwq0s2OdqAYjatq+AwpTbC L X-Google-Smtp-Source: AGHT+IE8mhWhhKiBt5b2l85To8UzaLvWG0AAD4FvKUliLTdv55JNVrtqxj5jCEhdthUjcPGaFi+KZw== X-Received: by 2002:a05:600c:3552:b0:41b:f30a:41f1 with SMTP id 5b1f17b1804b1-41f71302a9dmr13711545e9.7.1715155443920; Wed, 08 May 2024 01:04:03 -0700 (PDT) Received: from localhost.localdomain ([188.39.149.98]) by smtp.gmail.com with ESMTPSA id w16-20020a05600c475000b0041c14061c71sm1351944wmo.15.2024.05.08.01.04.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 May 2024 01:04:03 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Cc: Naushir Patuck Subject: [PATCH v2 5/6] ipa: rpi: Move variables from private to protected Date: Wed, 8 May 2024 09:04:00 +0100 Message-Id: <20240508080401.14850-6-naush@raspberrypi.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240508080401.14850-1-naush@raspberrypi.com> References: <20240508080401.14850-1-naush@raspberrypi.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The following member variable will be used by the derived IPAs in an upcoming commit, so make them protected: lensPresent_ monoSensor_ Signed-off-by: Naushir Patuck Signed-off-by: Naushir Patuck Reviewed-by: Jacopo Mondi Reviewed-by: Kieran Bingham Reviewed-by: Kieran Bingham --- src/ipa/rpi/common/ipa_base.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h index 512d7e8fe778..ebdc4d297abb 100644 --- a/src/ipa/rpi/common/ipa_base.h +++ b/src/ipa/rpi/common/ipa_base.h @@ -71,6 +71,9 @@ protected: /* Whether the stitch block (if available) needs to swap buffers. */ bool stitchSwapBuffers_; + bool monoSensor_; + bool lensPresent_; + private: /* Number of metadata objects available in the context list. */ static constexpr unsigned int numMetadataContexts = 16; @@ -96,9 +99,6 @@ private: std::map buffers_; - bool lensPresent_; - bool monoSensor_; - std::array rpiMetadata_; /*