From patchwork Tue May 7 18:16:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 20007 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B4B29BDE6B for ; Tue, 7 May 2024 18:16:17 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id BF1726342D; Tue, 7 May 2024 20:16:16 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="pRorN29U"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7855A633E4 for ; Tue, 7 May 2024 20:16:15 +0200 (CEST) Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D3330904 for ; Tue, 7 May 2024 20:16:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1715105773; bh=yuNVIfLP1s1I2s/OOUX8ZLQv1FV9i0r6viEdQcSvAbU=; h=From:To:Subject:Date:From; b=pRorN29UrsK4nT92TNWkqTgXxoPNMmKipcS3aL7Xaoo3a2oH2kr/McpbA+/JX9Ibq t/TH8jU+ylzK6ohq2fVNFZWEa6pMwOA9w7tmu3X03Nacw3tapFhyNagdanaeYnYEST Ywxg97cjy9atWy9/cJoIrdiGA3J6GxXsdsb2ymqs= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Subject: [PATCH] Revert "meson: Deprecate bitwise operations between different enumeration type" Date: Tue, 7 May 2024 21:16:07 +0300 Message-ID: <20240507181607.32538-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.43.2 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Enabling -Wdeprecated-enum-enum-conversion by default turned out to be a too hasty decision. It causes compilation failures with Qt headers prior to Qt v5.15.8. As the previous LTS versions of Debian and Ubuntu ship older Qt versions, those errors cause real inconvenience to users. This reverts commit bf4695266bfca8cc21bcf10a3281e874ebce0d27. The original goal of avoiding C++20 compilation regressions is still handled through a test in CI. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- meson.build | 9 --------- 1 file changed, 9 deletions(-) base-commit: bf4695266bfca8cc21bcf10a3281e874ebce0d27 diff --git a/meson.build b/meson.build index 89320adbde1f..39e4947f8c97 100644 --- a/meson.build +++ b/meson.build @@ -178,15 +178,6 @@ if cc.has_argument('-Wno-c99-designator') ] endif -# Enable the C++20 deprecated enum-enum conversion warning if the compiler -# supports it. This helps avoiding C++20 regressions, and should be removed -# when switching to C++20 as the warning will then be enabled by default. -if cxx.has_argument('-Wdeprecated-enum-enum-conversion') - cpp_arguments += [ - '-Wdeprecated-enum-enum-conversion', - ] -endif - c_arguments += common_arguments cpp_arguments += common_arguments