From patchwork Thu May 2 08:09:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 19979 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B01A2C32C9 for ; Thu, 2 May 2024 08:09:44 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 100F46341B; Thu, 2 May 2024 10:09:40 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="h8KKUuxY"; dkim-atps=neutral Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 22D046340B for ; Thu, 2 May 2024 10:09:37 +0200 (CEST) Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-41a72f3a20dso53129825e9.0 for ; Thu, 02 May 2024 01:09:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1714637376; x=1715242176; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nxXm2ChhWGkIUK/b0RakYTICcoi5twMYP1Qaj6ksUZc=; b=h8KKUuxYQPQ3Suu3hTh6jriPkhT03FsiZaXnjEqIvwX4L3phnitWXWo1P7QNJ5Jw7W awF7yLpRLg+JGiNTAab4DWKmIMyZcTYr9pjUXQhtdtWzUoYV+X2XP8ZsNP8jMPOJk8oM l7/cJXcla8aS+DmvMEl/diZH2flBE23Ld93V1zLrBXhBYIO9hETdbHIRSE6Rc4faJxr2 9aPkn8DP51c0PYFofoCZHzVa00i9bS2mWaS4gHuqYLYgIgxIK3cQTYcgIBEhmesXmaIi Q6yfimlRJuWYgV0kK+k0dAYSb1QfmLM3cS9t3UziLGmKEaHY3NQO2PPFfcJHBKRdv+cw NnXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714637376; x=1715242176; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nxXm2ChhWGkIUK/b0RakYTICcoi5twMYP1Qaj6ksUZc=; b=iMkZqWa5A1hiTu8PxfKWJ9y7CWdscBuWldfNOZc7hY6NN8eyQyD8kvtLlVdVF7LD93 iWzRU/0za8FNSP6vc01qX2qtfzlxvgnISB8GImmeVMFR11eZw6p7UuktNEgDNJFxa0LE BSHPo8KKCt+lJyovDj5LEwxFQUGgMdeheNvOYyNZHpgYgxjiq4tg4+d5fS5HGRzu2+JV iJS/ONe5YPC1oYw0lvQkMIkNac1wn9iBHuMGLBKZyyyM+yaqhH6wWvSaaujzsE986foq vbAopDb1xdRF4UK9SEXSlKp+zWMj8qcvniPfSVH4HHuKqk9mfL1LqaP/dS0cHYJZoF2p wjIw== X-Gm-Message-State: AOJu0YwTHxrLZtSK38bRStz8XRn67U1EALAWiGuFN/OwWhn9OnNLqBJa T+fi3yLPW0+V7WqtyIW9kiQTVoyRL5I4+U1kPXD6SxGycEDO/23EQaWH2kUAXpnXH4XHybJJMTa i X-Google-Smtp-Source: AGHT+IH4cYEHmmFJUZj2/MffIgbN3JF64DgDtm8DG0CGp01ghhAuNtHkEoHuiZufC1ozOdGpqzizpA== X-Received: by 2002:a05:600c:4446:b0:41b:a4bd:af26 with SMTP id v6-20020a05600c444600b0041ba4bdaf26mr881282wmn.13.1714637376545; Thu, 02 May 2024 01:09:36 -0700 (PDT) Received: from localhost.localdomain ([188.39.149.98]) by smtp.gmail.com with ESMTPSA id p12-20020a05600c1d8c00b0041bcb898984sm1049970wms.31.2024.05.02.01.09.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 01:09:36 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Cc: Naushir Patuck Subject: [PATCH v1 4/5] ipa: rpi: Move variables from private to protected Date: Thu, 2 May 2024 09:09:24 +0100 Message-Id: <20240502080925.31730-5-naush@raspberrypi.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240502080925.31730-1-naush@raspberrypi.com> References: <20240502080925.31730-1-naush@raspberrypi.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The following member variable will be used by the derived IPAs in an upcoming commit, so make them protected: lensPresent_ monoSensor_ Signed-off-by: Naushir Patuck Reviewed-by: Jacopo Mondi --- src/ipa/rpi/common/ipa_base.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h index 512d7e8fe778..ebdc4d297abb 100644 --- a/src/ipa/rpi/common/ipa_base.h +++ b/src/ipa/rpi/common/ipa_base.h @@ -71,6 +71,9 @@ protected: /* Whether the stitch block (if available) needs to swap buffers. */ bool stitchSwapBuffers_; + bool monoSensor_; + bool lensPresent_; + private: /* Number of metadata objects available in the context list. */ static constexpr unsigned int numMetadataContexts = 16; @@ -96,9 +99,6 @@ private: std::map buffers_; - bool lensPresent_; - bool monoSensor_; - std::array rpiMetadata_; /*