From patchwork Fri Apr 12 09:17:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 19867 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 5609DC3285 for ; Fri, 12 Apr 2024 09:17:21 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id F15E663360; Fri, 12 Apr 2024 11:17:20 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="bmxVlSm2"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A52976334D for ; Fri, 12 Apr 2024 11:17:18 +0200 (CEST) Received: from pyrite.hamster-moth.ts.net (h175-177-049-156.catv02.itscom.jp [175.177.49.156]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 27EC6D7E; Fri, 12 Apr 2024 11:16:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1712913395; bh=F4b1sisvNS2PUQCIik4PqmaTBBn9n/VFZAshk+gxS4M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bmxVlSm2pjn0AoSHUq2IMmoBszUXWBHbE0k8Wo2/w4qtMMQ5DniTVBXqWrT78YzYe 5jtCRgBT1Whrui0bfDqCUoooun4NBksCCI56lL4hMKVDJTPRhf5XuAtgfb9zZz7kI6 cA4Jqn/i37oCOzKLSD2poKl+3wawLoEHI5tHvWFQ= From: Paul Elder To: libcamera-devel@lists.libcamera.org Cc: Paul Elder Subject: [PATCH 3/3] ipa: rkisp1: agc: Plumb lux Date: Fri, 12 Apr 2024 18:17:00 +0900 Message-Id: <20240412091700.1817754-4-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240412091700.1817754-1-paul.elder@ideasonboard.com> References: <20240412091700.1817754-1-paul.elder@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Now that the rkisp1 IPA has a lux algorithm module, use the lux value that comes from that as opposed to hardcoding it. Signed-off-by: Paul Elder --- src/ipa/rkisp1/algorithms/agc.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp index ed4d6330..5371ae48 100644 --- a/src/ipa/rkisp1/algorithms/agc.cpp +++ b/src/ipa/rkisp1/algorithms/agc.cpp @@ -424,8 +424,7 @@ void Agc::process(IPAContext &context, [[maybe_unused]] const uint32_t frame, double analogueGain = frameContext.sensor.gain; utils::Duration effectiveExposureValue = exposureTime * analogueGain; - /* \todo Plumb in the lux value. Requires a lux algo + tuning */ - double lux = 400; + double lux = frameContext.agc.lux; utils::Duration shutterTime; double aGain, dGain;