From patchwork Tue Mar 19 12:05:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 19755 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id AE95DC32CA for ; Tue, 19 Mar 2024 12:05:47 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 6E5F263055; Tue, 19 Mar 2024 13:05:47 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="XvbGxiUG"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 02AA962D33 for ; Tue, 19 Mar 2024 13:05:31 +0100 (CET) Received: from jasper.fritz.box (unknown [IPv6:2a00:6020:448c:6c00:1478:344b:8fcb:baf5]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5160DF02; Tue, 19 Mar 2024 13:05:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1710849904; bh=TN69nrXh+FZ9LrbBYsdiBRy2H8uwrQH5cjkM8gmFPA8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XvbGxiUGv5r6Qm4wlifW/heLrL1DWEAitRGeiyt7BjkU/sXRolgVG/3A2+AcFwhi6 IcJl1vIB0vPCf5EnG9bkiFUgte5U8JSgNC5Qf6VtgrRJeE+4b2qzdhbWLjIMp0yiHI pUeoefEHpHkoNGHouO5RieM9ql8q7dz2Dk/yiQ6Y= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH v3 14/16] pipeline: rkisp1: Add more debug logging Date: Tue, 19 Mar 2024 13:05:15 +0100 Message-Id: <20240319120517.362082-15-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240319120517.362082-1-stefan.klug@ideasonboard.com> References: <20240319120517.362082-1-stefan.klug@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Signed-off-by: Stefan Klug --- src/ipa/rkisp1/algorithms/agc.cpp | 4 ++-- src/ipa/rkisp1/rkisp1.cpp | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp index 47a6f7b2..f737ba92 100644 --- a/src/ipa/rkisp1/algorithms/agc.cpp +++ b/src/ipa/rkisp1/algorithms/agc.cpp @@ -125,14 +125,14 @@ void Agc::queueRequest(IPAContext &context, / context.configuration.sensor.lineDuration; LOG(RkISP1Agc, Debug) - << "Set exposure to " << agc.manual.exposure; + << "Set manual exposure to " << agc.manual.exposure; } const auto &gain = controls.get(controls::AnalogueGain); if (gain && !agc.autoEnabled) { agc.manual.gain = *gain; - LOG(RkISP1Agc, Debug) << "Set gain to " << agc.manual.gain; + LOG(RkISP1Agc, Debug) << "Set manual gain to " << agc.manual.gain; } frameContext.agc.autoEnabled = agc.autoEnabled; diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp index 44d03eb8..6bc09198 100644 --- a/src/ipa/rkisp1/rkisp1.cpp +++ b/src/ipa/rkisp1/rkisp1.cpp @@ -314,6 +314,7 @@ void IPARkISP1::unmapBuffers(const std::vector &ids) void IPARkISP1::queueRequest(const uint32_t frame, const ControlList &controls) { IPAFrameContext &frameContext = context_.frameContexts.alloc(frame); + LOG(IPARkISP1, Debug) << "queueRequest: " << frame; for (auto const &a : algorithms()) { Algorithm *algo = static_cast(a.get()); @@ -354,6 +355,7 @@ void IPARkISP1::processStatsBuffer(const uint32_t frame, const uint32_t bufferId stats = reinterpret_cast( mappedBuffers_.at(bufferId).planes()[0].data()); + LOG(IPARkISP1, Debug) << "processStatsBuffer for frame " << frame; frameContext.sensor.exposure = sensorControls.get(V4L2_CID_EXPOSURE).get(); frameContext.sensor.gain =