From patchwork Sun Mar 10 14:30:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 19653 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id CEE33BD160 for ; Sun, 10 Mar 2024 14:30:52 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 837EB6286F; Sun, 10 Mar 2024 15:30:52 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=protonmail.com header.i=@protonmail.com header.b="kGUDemr6"; dkim-atps=neutral Received: from mail-4316.protonmail.ch (mail-4316.protonmail.ch [185.70.43.16]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 2613462973 for ; Sun, 10 Mar 2024 15:30:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1710081050; x=1710340250; bh=aWQhyjRoCHcfdYy792f/KmWzWIHqSdZBpbElcK0Sb5o=; h=Date:To:From:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=kGUDemr6fNj/4PHGPD4bF5N2teDFy8+HvuG4efdWFWO6k5Vh9Xohvv7UnpErAJnxY 4HhFvK5tuwF4mS9+rjhgbfg8yAu+l0ik7koNe/e0QcBeViFTpuBwRs7o0rNYqi/t3h R9AjYffwGU7Btj7X6ZK2D/nKDFhX8MKv/HzFKQjZh3DRnpKm5Hdrvj64n+wk5QRwnk MwzlFTeONak8YGZI0cXquclSe4YAcZTrEeSfp/Su6jXsNP/eyyAYzF4rJqEym5TbEq yk4ok1Dy9jor6jjpiqp3Vj/KPGswxKBh2SdphbIVoeEHrraZr7OsEZJ6ykhqEzAeqr NVeFXaBbryibg== Date: Sun, 10 Mar 2024 14:30:33 +0000 To: libcamera-devel@lists.libcamera.org From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= Subject: [PATCH v2 1/3] libcamera: framebuffer_allocator: Move from argument in constructor Message-ID: <20240310143023.752559-2-pobrn@protonmail.com> In-Reply-To: <20240310143023.752559-1-pobrn@protonmail.com> References: <20240310143023.752559-1-pobrn@protonmail.com> Feedback-ID: 20568564:user:proton MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The single argument, of type `std::shared_ptr`, is passed by value, so it can simply be moved from in order to avoid calling the copy constructor. Signed-off-by: Barnabás Pőcze Reviewed-by: Kieran Bingham Reviewed-by: Jacopo Mondi --- src/libcamera/framebuffer_allocator.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libcamera/framebuffer_allocator.cpp b/src/libcamera/framebuffer_allocator.cpp index 94389735..8cf45ab2 100644 --- a/src/libcamera/framebuffer_allocator.cpp +++ b/src/libcamera/framebuffer_allocator.cpp @@ -59,7 +59,7 @@ LOG_DEFINE_CATEGORY(Allocator) * \param[in] camera The camera */ FrameBufferAllocator::FrameBufferAllocator(std::shared_ptr camera) - : camera_(camera) + : camera_(std::move(camera)) { }