From patchwork Fri Feb 23 15:59:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 19529 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 08A70C3263 for ; Fri, 23 Feb 2024 16:00:02 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id A73D662809; Fri, 23 Feb 2024 17:00:00 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="vwEALkPr"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 92F0F627FD for ; Fri, 23 Feb 2024 16:59:58 +0100 (CET) Received: from Monstersaurus.local (aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net [82.37.23.78]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 43C00D52; Fri, 23 Feb 2024 16:59:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1708703989; bh=Q+1zVWXDyXRmHJN4cxUi7LV29DDCPHUqyyn7SxehJAQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vwEALkPrlG7xB6rK49ybKlRrldHEvVM/5mwJMGcfeAuqG8aZ+ItvLVUAXVIZvFs7/ Ps2pUeJGg0HhS1LpeA8iOYgIrgWf8JIVGPnMtQUfxgefwBW042nK+9dnB1LXuh5mcJ /zHVSCgPkctPjUGQiqClx56WKcJZoYdzz1sxONwg= From: Kieran Bingham To: libcamera devel Subject: [PATCH 1/3] ipa: libipa: Allow retrieving the name of a CameraSensorHelperFactory Date: Fri, 23 Feb 2024 15:59:52 +0000 Message-Id: <20240223155954.4139705-2-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240223155954.4139705-1-kieran.bingham@ideasonboard.com> References: <20240223155954.4139705-1-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Support the test suite iterating the factories by exposing a const retriever of the factory name. --- An alternative here is to just allow direct access to the createInstance() from the test too, without having to re-search all of the factories each time. But I felt this was less of a de-restriction of the existing interfaces. Signed-off-by: Kieran Bingham --- src/ipa/libipa/camera_sensor_helper.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/ipa/libipa/camera_sensor_helper.h b/src/ipa/libipa/camera_sensor_helper.h index 3ea1806cb1fd..dcdbe82b7ac9 100644 --- a/src/ipa/libipa/camera_sensor_helper.h +++ b/src/ipa/libipa/camera_sensor_helper.h @@ -68,6 +68,8 @@ public: static std::vector &factories(); + const std::string &name() const { return name_; }; + private: LIBCAMERA_DISABLE_COPY_AND_MOVE(CameraSensorHelperFactoryBase)