From patchwork Wed Feb 21 05:38:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: hui fang X-Patchwork-Id: 19520 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id EDE97BD80A for ; Wed, 21 Feb 2024 10:06:05 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 3EC7362800; Wed, 21 Feb 2024 11:06:05 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="EuO+LMT3"; dkim-atps=neutral Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4814A62800 for ; Wed, 21 Feb 2024 06:38:12 +0100 (CET) Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-41273252724so4009135e9.1 for ; Tue, 20 Feb 2024 21:38:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708493891; x=1709098691; darn=lists.libcamera.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=5c/SyQQ6ga1349ZotIr6GyRBX+c7Pi2H7Zu/eteg49k=; b=EuO+LMT3DvLYbKMYl/QeBJgjL+rs0jYwMSr8z5Eo6zoN1WiCxLaPGu8wpQGuRgZyLV UE6hgaPo5l80FRsOg38m0zk57mgq5ZzDHu2X4OG75A0XqDqJTmjKkMERQ1KwgrusJuPx +89Xx3kzk2c30OTBjeevXthOruqHXhne8260WS88CMDQQ7YAS15KkAYnXwFBb3zhjy1F IcI7gLsB3iBppwqiah0K5QW1qjDmlAQXNtxVgfbKNWOTMG+KoHll8K3NYNdsCqR6UgXS nRBbdw+vqaFy7TYiHBb+ROC/9ao5zmGe1EyeBD0fjqw6uWN7rHPaWRj0DTHLqZcysqXE NcXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708493891; x=1709098691; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=5c/SyQQ6ga1349ZotIr6GyRBX+c7Pi2H7Zu/eteg49k=; b=TU46yHsiQ4NpZjVJFYHlM46etFj2zHICmqfM0sqEpJvR74CK9jDnLndFeUbushu5NW gJoW1+wh5tgk2K4P1taGFeW1CPRqeaa1uqI65efaWA5x3Sw4+cbD/QF+2ST/cyEbV6q7 UTh4Q+gi373UNjFS0FYW3Rz9JUnMZ4heoOPgAeOWyOngke1UuKTQDNpvOvDmg0GX5tPC 4Jc7peuBl+y57smgODRiS7teuE2vQudiG2hwzr+x/EfYoZa2D9wYiPfP21jc9sPr8W6N D8NYXuAYbI9Ha0z4XYkaRgvKDrCBf/8ByPuHCTqnCvDGumyBrZ+bzcOXE72VA75nuk/J 4V8g== X-Gm-Message-State: AOJu0YyDiv/Y6Ey86I8/rt/LtbUv/nEMsXIxHuXABN8mcBNHe9wq48RN Hk3N9HZHYOOdYvTkuWj8pmD5pkRaMUrnDIUx/7weeFvDPbl3zrrtLUFXWn+jvHB2j/SIu4CL8q1 GMMyWs2WT33SLtRU79k41B6hXu/Rcz0Bs5EU= X-Google-Smtp-Source: AGHT+IE4N6o8H845JOKJR9rIr1qrx6hbTQbSii1xh8WEGB5Fzj9OK+jFJbDtZZ4MK8xty1L9xDjFxFbWRVF9U4GTRNE= X-Received: by 2002:a05:600c:1382:b0:410:7897:6bc0 with SMTP id u2-20020a05600c138200b0041078976bc0mr12732714wmf.22.1708493891469; Tue, 20 Feb 2024 21:38:11 -0800 (PST) MIME-Version: 1.0 From: hui fang Date: Wed, 21 Feb 2024 13:38:00 +0800 Message-ID: Subject: The first valid settings should be saved To: libcamera-devel@lists.libcamera.org X-Mailman-Approved-At: Wed, 21 Feb 2024 11:06:02 +0100 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The first valid settings should be saved, or will be deferred to the next frame. BRs, FangHui diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp index 25cedd44..d45ed1a5 100644 --- a/src/android/camera_device.cpp +++ b/src/android/camera_device.cpp @@ -952,8 +952,8 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques */ if (camera3Request->settings) lastSettings_ = camera3Request->settings; - else - descriptor->settings_ = lastSettings_; + + descriptor->settings_ = lastSettings_;