From patchwork Thu Feb 15 13:27:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 19502 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 49DB1BDE17 for ; Thu, 15 Feb 2024 13:27:23 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 9DB2C6280B; Thu, 15 Feb 2024 14:27:21 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="Ap7554da"; dkim-atps=neutral Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id CE27561CB0 for ; Thu, 15 Feb 2024 14:27:19 +0100 (CET) Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-511ac32ff36so956587e87.1 for ; Thu, 15 Feb 2024 05:27:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1708003639; x=1708608439; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=crpVpPOk2g+hz0+8zRQdstVqUMjcIwP6axfs16ih/z0=; b=Ap7554daavDh0RBLpxEgxuG2K+LB94vUeBduJIqO899D8uQFHQvUsKgX7gvGuu+CET WlqgoosjuX8nq0AZAtwSnxW+dYgD7Q4//T+Jo2PKj9j4wKqWdLBiDn7VEdPeyimiNZwe wvj2ZAQ5VWpUZpBnSitgkQ+pmUBSIRqMX4tTk9LMyYP14B/g7tdI230+IKU2iq3Q1pF7 9p42wuIOZLE4/qRS0ML7VPGS2PQ15H9ooQ+gC6xoEw7u8KiVA0EVekIuG6vCwy75o/yp lWBVCVycgUXDbZ+aYFlJBbYdKODFxBnENDgyyNAd6koXp7q7HQCIKreFjq4kGH/5Bf9M 00CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708003639; x=1708608439; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=crpVpPOk2g+hz0+8zRQdstVqUMjcIwP6axfs16ih/z0=; b=SRNM5QbZ48TAT1qad9j5Jk9zkRNB4y81OHubZJUyi5Ki69p5PIPlsdqzGP9MdhjlYm uv2qQyUdgkpscRwxhyZecE1CC3H5ys/WAn/JCrpGIQQyw0g5ClF4ssLnlG84IWEjqh7k 2Kv5A5b8SYwiJ/RENDOjl1lT9ZbWOCjuNVE+nzdIM7ye8lruY8kCNRpMH1cHOLI72m/p 3Ikf/akFgE/QwTfNCmY0Twoh0MkPrp/VeV4VawRsuVNcMdQPp+TGs9NrMi90s/t32Tnn klIPX2QawdeMGbX+6hnrsp9tHqyJVZ8TRvs3ODQlQbTq7FUui7ae5UZno47E3QerR4Dq qiKA== X-Gm-Message-State: AOJu0YxY5cs/6SStreyEzwJyOaG0clg0AnaFFwUdOqphcM1UsvIjc5ez CJ0Oj2RMaKAs9+2iwSPy5XPjWNPyTCHI1xnhjAmdZEmspuTjIV95FY7UjcTmmLgCbpZocAKj28J k X-Google-Smtp-Source: AGHT+IHWcBxPHWmWjMLi3C5mm8AMCm2PqLUqcshTjsj8hpXRPcn/6OBc9+MoHLrWMehX0jTTraGIcw== X-Received: by 2002:a05:6512:124c:b0:511:85ae:8985 with SMTP id fb12-20020a056512124c00b0051185ae8985mr1614890lfb.53.1708003638583; Thu, 15 Feb 2024 05:27:18 -0800 (PST) Received: from localhost.localdomain ([188.39.149.98]) by smtp.gmail.com with ESMTPSA id ew14-20020a056402538e00b005607825b11bsm532283edb.12.2024.02.15.05.27.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 05:27:18 -0800 (PST) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Subject: [PATCH v1 1/2] libcamera: formats: Add RGB48 formats Date: Thu, 15 Feb 2024 13:27:09 +0000 Message-Id: <20240215132710.810-2-naush@raspberrypi.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240215132710.810-1-naush@raspberrypi.com> References: <20240215132710.810-1-naush@raspberrypi.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add support for 16-bps (48-bpp) RGB output formats. These new formats are define for the RGB and BGR ordering. Signed-off-by: Naushir Patuck --- include/linux/drm_fourcc.h | 4 ++++ include/linux/videodev2.h | 4 ++++ src/libcamera/formats.cpp | 20 ++++++++++++++++++++ src/libcamera/formats.yaml | 5 +++++ src/libcamera/v4l2_pixelformat.cpp | 4 ++++ 5 files changed, 37 insertions(+) diff --git a/include/linux/drm_fourcc.h b/include/linux/drm_fourcc.h index d6c83d9c49f4..4ee421b95730 100644 --- a/include/linux/drm_fourcc.h +++ b/include/linux/drm_fourcc.h @@ -210,6 +210,10 @@ extern "C" { #define DRM_FORMAT_RGBA1010102 fourcc_code('R', 'A', '3', '0') /* [31:0] R:G:B:A 10:10:10:2 little endian */ #define DRM_FORMAT_BGRA1010102 fourcc_code('B', 'A', '3', '0') /* [31:0] B:G:R:A 10:10:10:2 little endian */ +/* 48 bpp RGB */ +#define DRM_FORMAT_RGB161616 fourcc_code('R', 'G', '4', '8') /* [48:0] R:G:B 16:16:16 little endian */ +#define DRM_FORMAT_BGR161616 fourcc_code('B', 'G', '4', '8') /* [48:0] R:G:B 16:16:16 little endian */ + /* 64 bpp RGB */ #define DRM_FORMAT_XRGB16161616 fourcc_code('X', 'R', '4', '8') /* [63:0] x:R:G:B 16:16:16:16 little endian */ #define DRM_FORMAT_XBGR16161616 fourcc_code('X', 'B', '4', '8') /* [63:0] x:B:G:R 16:16:16:16 little endian */ diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h index 7e556911c9e1..ba48d2c89726 100644 --- a/include/linux/videodev2.h +++ b/include/linux/videodev2.h @@ -557,6 +557,10 @@ struct v4l2_pix_format { #define V4L2_PIX_FMT_BGR48_12 v4l2_fourcc('B', '3', '1', '2') /* 48 BGR 12-bit per component */ #define V4L2_PIX_FMT_ABGR64_12 v4l2_fourcc('B', '4', '1', '2') /* 64 BGRA 12-bit per component */ +/* RGB formats (6 bytes per pixel) */ +#define V4L2_PIX_FMT_BGR48 v4l2_fourcc('B', 'G', 'R', '6') /* 16 BGR-16-16-16 */ +#define V4L2_PIX_FMT_RGB48 v4l2_fourcc('R', 'G', 'B', '6') /* 16 RGB-16-16-16 */ + /* Grey formats */ #define V4L2_PIX_FMT_GREY v4l2_fourcc('G', 'R', 'E', 'Y') /* 8 Greyscale */ #define V4L2_PIX_FMT_Y4 v4l2_fourcc('Y', '0', '4', ' ') /* 4 Greyscale */ diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp index 8a606a7c37f1..a674f4179cc8 100644 --- a/src/libcamera/formats.cpp +++ b/src/libcamera/formats.cpp @@ -270,6 +270,26 @@ const std::map pixelFormatInfo{ .pixelsPerGroup = 1, .planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }}, } }, + { formats::BGR161616, { + .name = "BGR161616", + .format = formats::BGR161616, + .v4l2Formats = { V4L2PixelFormat(V4L2_PIX_FMT_RGB48), }, + .bitsPerPixel = 48, + .colourEncoding = PixelFormatInfo::ColourEncodingRGB, + .packed = false, + .pixelsPerGroup = 1, + .planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }}, + } }, + { formats::RGB161616, { + .name = "RGB161616", + .format = formats::RGB161616, + .v4l2Formats = { V4L2PixelFormat(V4L2_PIX_FMT_BGR48), }, + .bitsPerPixel = 24, + .colourEncoding = PixelFormatInfo::ColourEncodingRGB, + .packed = false, + .pixelsPerGroup = 1, + .planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }}, + } }, /* YUV packed formats. */ { formats::YUYV, { diff --git a/src/libcamera/formats.yaml b/src/libcamera/formats.yaml index d8a379923b56..bde2cc803b98 100644 --- a/src/libcamera/formats.yaml +++ b/src/libcamera/formats.yaml @@ -43,6 +43,11 @@ formats: - BGRA8888: fourcc: DRM_FORMAT_BGRA8888 + - RGB161616: + fourcc: DRM_FORMAT_RGB161616 + - BGR161616: + fourcc: DRM_FORMAT_BGR161616 + - YUYV: fourcc: DRM_FORMAT_YUYV - YVYU: diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp index 731dc10f1d73..efb6f2940235 100644 --- a/src/libcamera/v4l2_pixelformat.cpp +++ b/src/libcamera/v4l2_pixelformat.cpp @@ -71,6 +71,10 @@ const std::map vpf2pf{ { formats::BGRA8888, "32-bit ARGB 8-8-8-8" } }, { V4L2PixelFormat(V4L2_PIX_FMT_BGRA32), { formats::RGBA8888, "32-bit ABGR 8-8-8-8" } }, + { V4L2PixelFormat(V4L2_PIX_FMT_RGB48), + { formats::BGR161616, "48-bit RGB 16-16-16" } }, + { V4L2PixelFormat(V4L2_PIX_FMT_BGR48), + { formats::RGB161616, "48-bit BGR 16-16-16" } }, /* YUV packed formats. */ { V4L2PixelFormat(V4L2_PIX_FMT_YUYV),