From patchwork Thu Nov 23 13:09:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 19231 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 27C91BDE6B for ; Thu, 23 Nov 2023 13:09:14 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 25184629BC; Thu, 23 Nov 2023 14:09:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1700744953; bh=0POCS3keIpL5tII+8BFiYdRWRt+0LYRuz4bweg/I1Wo=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=DZVZse2pJsaimfhXNcx8EqwWQkm6cg0lPybDqj7jX4byxHwLL1/d3NwuCmkdgps/b vymrXCJUdCAIvODF0UyDINZroMoY9ZoyUyiTRlEoGXRN8J5KxvH38EMZJBiV+0SR7N AfLKIqO3sZMYWxqaJPBum7lFgP6Ql2KugPUGdi289yyoMmX6VFzR7InwPp4rWGNLSZ Z6I1BFnaBkXVeaknnmvwV0GNaWSCWvRQiHJi2nF3gYPVYEewcZJpu3n+A9zSHgeIrX lE2nSb8l4M+UHOIn2IQSvbuCO6NPKzoCFmaWse8oMK5PJSeWW5Ds3DL3r/PPuYx3IX jFW3m236LXpZA== Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F72A629AF for ; Thu, 23 Nov 2023 14:09:11 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="RibI+mQi"; dkim-atps=neutral Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-40b2c9ee8ecso5637855e9.2 for ; Thu, 23 Nov 2023 05:09:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1700744950; x=1701349750; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=e4JC3h0rZbhNibftS95P6AEhUzmM7iPR3sNNjkPYK/I=; b=RibI+mQiOLRTTS/lhhAF69vBuOUJcXV5uXrAF0b2Z3REtqFG2uZ79y5u9vg+CdZYPu 7daIv1h7dmR2BkquOT9K5byknf5OonMc2a/eZFRkTmUlqxuNavv/pDf0iFbZJijrHrp4 hOCctDzi2Wfy0JLgqGQex3NmnuJaVGjX3j377AlMDi/Dv8hwRBhCrYksJq9RJIdV8bhu biTmkIn4inSFxJNJqgsYYW1fvpF9/fvw92wbuAPM8YnHd4z3y1JzGhxcwQyiK+icSOym 8f1DfuRc9/01MzgrGtXfuD8GhWEitE0UZ4oEFVS8s9cc7863RRHDtdNkUoY9zhfniPd+ JH3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700744950; x=1701349750; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=e4JC3h0rZbhNibftS95P6AEhUzmM7iPR3sNNjkPYK/I=; b=F4IeMlmJIXvhNmK/U1ljzX7cia8orFzXHFqL8cPfxBsOUe7kyvv70I9yHyF9FrWW8K R3kNiM+4rmZpjl47j/UqnbZ7xs62YenSdFLsKb6WvG14BUBWAPfMp8npYI9NTWEOrAh4 d4S6JeZ9W5TfQ/mQwqGZocid8Ns6MhSS0xyMMo8hGz2d1dhtR63o0H4jyN8wsDrpwGf0 bp8RJEb2JxYuPJncHEAd96ZC0Mr8/bTwRr1r0yFxHqBleoHP3vaLV8V0hhIXZ+RhGOMh P3ul3LgTskOt5+6zaQFovVOsgSQCZTlWSGqHITcbrTs1Vgownu7IPg7QzQK+jC7i06jZ 9rOg== X-Gm-Message-State: AOJu0Yxf60n3B3vhUqAruC0UPQxuMmBkie42ENEnhRbuu33IgZQINBD5 ToXPRHiy/mFTr+Is381GhRHyB1bwF0urtHCW8k4= X-Google-Smtp-Source: AGHT+IHB8v919xD2+wqDj8akRTVhTGKzJXw3GJhpiEDW+eeUrLkGVJB+r8mT4+eDBoM4oneWdU4IuA== X-Received: by 2002:a5d:634f:0:b0:332:e58b:ab58 with SMTP id b15-20020a5d634f000000b00332e58bab58mr870603wrw.1.1700744950227; Thu, 23 Nov 2023 05:09:10 -0800 (PST) Received: from pi5-davidp.pitowers.org ([2a00:1098:3142:14:183e:6cc8:a436:a27c]) by smtp.gmail.com with ESMTPSA id v10-20020adff68a000000b00332c0e934aasm1593380wrp.44.2023.11.23.05.09.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 05:09:09 -0800 (PST) To: libcamera-devel@lists.libcamera.org Date: Thu, 23 Nov 2023 13:09:04 +0000 Message-Id: <20231123130905.103934-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 1/2] libcamera: controls: Update the ColourTemperature control to be writable X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Plowman via libcamera-devel From: David Plowman Reply-To: David Plowman Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Implementations are allowed to expose this as a settable control so that applications can demand a specific colour temperature. The description is updated to this effect. Signed-off-by: David Plowman Reviewed-by: Kieran Bingham --- src/libcamera/control_ids.yaml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml index c3232abf..8fbcc5f6 100644 --- a/src/libcamera/control_ids.yaml +++ b/src/libcamera/control_ids.yaml @@ -312,9 +312,11 @@ controls: - ColourTemperature: type: int32_t - description: Report the current estimate of the colour temperature, in - kelvin, for this frame. The ColourTemperature control can only be - returned in metadata. + description: | + Report the current estimate of the colour temperature, in kelvin, for + this frame. An implementation may also allow this control to be set so + as to disable the AWB algorithm whilst setting the colour gains to the + correct fixed ones for this colour temperature. - Saturation: type: float