From patchwork Sun Oct 22 22:41:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 19177 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id AFF74C32B9 for ; Sun, 22 Oct 2023 22:42:06 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 82F236299B; Mon, 23 Oct 2023 00:42:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1698014524; bh=MJ7wHvEOETCVJDNchxhDWGfJNlIODO9/4WptVnFI3Z0=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=fOTPeKoVonYRjs3nlGwUsVkBYmH1LE8reKjCjDYJGMVAWyuzPf9qdPnpEksin5y97 ycYIypn0xDj2q1ADKS4pFFIxRVC56wyMrz3lO5G6vQoCk0hCCJePfJtuI3uheZuQv9 BHHnpV2+p6rCR6wp8XWiwQB9uFHN1rBh+PYkOtQVqDYQZISno0AtSijjWoPjsbYch3 4REvzved3NV68CyFMEMqbmvVxjrbBdKw8Qr6vuFfAt2L2r7p+acNxqGW14sxuABXwl pnUgroqY4AYby7vFk/x8vjeFz9yV0TmyGI1quSw+k8lUfrhNjEq4ODDT8nKjnJ3TkT bU1h8dbhuYyPg== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4767D62990 for ; Mon, 23 Oct 2023 00:42:02 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="cjaBZRrz"; dkim-atps=neutral Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E752CD20; Mon, 23 Oct 2023 00:41:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1698014512; bh=MJ7wHvEOETCVJDNchxhDWGfJNlIODO9/4WptVnFI3Z0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cjaBZRrzNFlG9EtRiY2DGVXq6YzJb6/tJZtWNFoaIzxQvkcAiIwazV7n8wRYc/MhO 0VxBjZg4Cm2O8yLWTi7eBbO5ST/wNEIeJCeSXmpgm/z989aU7K0eVTTSfXTfhWc9Xd LUM2dv66RdIZtr/gytK4tjC9XLqI2jbUrssNP4WM= To: libcamera-devel@lists.libcamera.org Date: Mon, 23 Oct 2023 01:41:59 +0300 Message-ID: <20231022224159.30298-9-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231019140133.32090-1-jacopo.mondi@ideasonboard.com> References: <20231019140133.32090-1-jacopo.mondi@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v6 21/12] libcamera: transform: Make the transformFromOrientation() function static X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Laurent Pinchart via libcamera-devel From: Laurent Pinchart Reply-To: Laurent Pinchart Cc: Jacopo Mondi Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Now that the transformFromOrientation() function isn't used outside of transform.cpp, make it static to remove it from the public API. Signed-off-by: Laurent Pinchart --- include/libcamera/transform.h | 1 - src/libcamera/transform.cpp | 4 ++++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/include/libcamera/transform.h b/include/libcamera/transform.h index 4998a6c04cb7..44cb4c6fc974 100644 --- a/include/libcamera/transform.h +++ b/include/libcamera/transform.h @@ -71,7 +71,6 @@ constexpr Transform operator~(Transform t) } Transform transformFromRotation(int angle, bool *success = nullptr); -Transform transformFromOrientation(const Orientation &orientation); Transform operator/(const Orientation &o1, const Orientation &o2); Orientation operator*(const Orientation &o, const Transform &t); diff --git a/src/libcamera/transform.cpp b/src/libcamera/transform.cpp index cd2717c28c3a..fb2d55ac1931 100644 --- a/src/libcamera/transform.cpp +++ b/src/libcamera/transform.cpp @@ -301,6 +301,8 @@ Transform transformFromRotation(int angle, bool *success) return Transform::Identity; } +namespace { + /** * \brief Return the transform representing \a orientation * \param[in] orientation The orientation to convert @@ -330,6 +332,8 @@ Transform transformFromOrientation(const Orientation &orientation) return Transform::Identity; } +} /* namespace */ + /** * \brief Return the Transform that applied to \a o2 gives \a o1 * \param o1 The Orientation to obtain