From patchwork Sat Sep 16 12:19:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 19043 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 2635CBD160 for ; Sat, 16 Sep 2023 12:19:46 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B51CE6291F; Sat, 16 Sep 2023 14:19:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1694866785; bh=QfR+JclEnCYqYSFFstRnyrbg8ePcbMNcod+QMO9f+wQ=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=LfYQ2gXr14ts9qxW5AfIITiICEDC0zPEQcYzKfviTtk9XH5HAtLlut+keo7tfyxGr 53l8ndlvEXptiKa4nsI3GBrSxqvSsDCT0i2xw/V9Igo8Vr529AAS3/UF+NaPWnVobF 88kVk3O5w2CkemAl/nr9vRZhnQAS4SJ6ZcD30XBHvNnypfWmwTbn9+YU0pDtg5XLJ4 HFexbDY0uhs4j1n0DKiBBcCKYxkjpz6R5OLfGoQxzPFuenghOitLjKg2zJqbKd/KmD dmmODVz+3ySxUUiUa3c7SOD8BDinSDP/TosuellyRveZRiWC5uRUb/eYwa8YsJpjQW BpXCSi22LQSKA== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A278162911 for ; Sat, 16 Sep 2023 14:19:39 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="DY6sQi6W"; dkim-atps=neutral Received: from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it [93.61.96.190]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 881C91536; Sat, 16 Sep 2023 14:18:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1694866685; bh=QfR+JclEnCYqYSFFstRnyrbg8ePcbMNcod+QMO9f+wQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DY6sQi6WC1srU0fNNaqgOr/Z92TjOCLSm4unVQyQZBS6tibGVA/QQYj8KlcHZa/sI mQsjQVfv8yaTx0N2VL1SzasdQ6NQBP2okzB+0ZaFgO4N2PqXi6el2wUoCwqrqIIUms TEhtusxSR5wTTqF91A6qeAA8FhdyJR9RA9+HA7FY= To: libcamera-devel@lists.libcamera.org Date: Sat, 16 Sep 2023 14:19:23 +0200 Message-ID: <20230916121930.29490-6-jacopo.mondi@ideasonboard.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230916121930.29490-1-jacopo.mondi@ideasonboard.com> References: <20230916121930.29490-1-jacopo.mondi@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v4 05/12] libcamera: rpi: Allow platformValidate() to adjust format strides X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jacopo Mondi via libcamera-devel From: Jacopo Mondi Reply-To: Jacopo Mondi Cc: Jacopo Mondi Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Naushir Patuck Propagate any changes to the format stride done by platformValidate(). The stride value may be adjusted for performace reasons. Signed-off-by: Naushir Patuck Reviewed-by: Jacopo Mondi Signed-off-by: Jacopo Mondi --- src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp index 4d0d150ccf0c..566aa8f3211e 100644 --- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp +++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp @@ -305,6 +305,17 @@ CameraConfiguration::Status RPiCameraConfiguration::validate() V4L2DeviceFormat format; format.fourcc = out.dev->toV4L2PixelFormat(cfg.pixelFormat); format.size = cfg.size; + + /* + * platformValidate may have worked out the correct stride so we + * must pass it in. This also needs the planesCount to be set + * correctly or the stride will be ignored. + */ + const PixelFormat &pixFormat = format.fourcc.toPixelFormat(); + const PixelFormatInfo &info = PixelFormatInfo::info(pixFormat); + format.planesCount = info.numPlanes(); + format.planes[0].bpl = cfg.stride; + /* We want to send the associated YCbCr info through to the driver. */ format.colorSpace = yuvColorSpace_;