From patchwork Thu Aug 29 23:26:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Niklas_S=C3=B6derlund?= X-Patchwork-Id: 1887 Return-Path: Received: from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net [195.74.38.229]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 996C160BE5 for ; Fri, 30 Aug 2019 01:27:30 +0200 (CEST) X-Halon-ID: 8e450385-cab4-11e9-837a-0050569116f7 Authorized-sender: niklas@soderlund.pp.se Received: from bismarck.berto.se (unknown [79.202.45.17]) by bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA id 8e450385-cab4-11e9-837a-0050569116f7; Fri, 30 Aug 2019 01:27:24 +0200 (CEST) From: =?utf-8?q?Niklas_S=C3=B6derlund?= To: libcamera-devel@lists.libcamera.org Date: Fri, 30 Aug 2019 01:26:40 +0200 Message-Id: <20190829232653.13214-2-niklas.soderlund@ragnatech.se> X-Mailer: git-send-email 2.22.1 In-Reply-To: <20190829232653.13214-1-niklas.soderlund@ragnatech.se> References: <20190829232653.13214-1-niklas.soderlund@ragnatech.se> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 01/14] libcamera: ipa: Remove IPAInterface::init() X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Aug 2019 23:27:31 -0000 The function performs no useful task and will not be needed when we extend the IPA interface to process parameter and statistic buffers. Signed-off-by: Niklas Söderlund Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- include/libcamera/ipa/ipa_interface.h | 2 -- src/ipa/ipa_dummy.cpp | 8 -------- src/ipa/ipa_dummy_isolate.cpp | 8 -------- src/libcamera/ipa_interface.cpp | 5 ----- src/libcamera/pipeline/vimc.cpp | 2 -- 5 files changed, 25 deletions(-) diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h index 2c5eb1fd524311cb..9bbc4cf58ec66420 100644 --- a/include/libcamera/ipa/ipa_interface.h +++ b/include/libcamera/ipa/ipa_interface.h @@ -13,8 +13,6 @@ class IPAInterface { public: virtual ~IPAInterface() {} - - virtual int init() = 0; }; } /* namespace libcamera */ diff --git a/src/ipa/ipa_dummy.cpp b/src/ipa/ipa_dummy.cpp index 4c8b6657689d0c9f..2fe232295c676941 100644 --- a/src/ipa/ipa_dummy.cpp +++ b/src/ipa/ipa_dummy.cpp @@ -14,16 +14,8 @@ namespace libcamera { class IPADummy : public IPAInterface { -public: - int init(); }; -int IPADummy::init() -{ - std::cout << "initializing dummy IPA!" << std::endl; - return 0; -} - /* * External IPA module interface */ diff --git a/src/ipa/ipa_dummy_isolate.cpp b/src/ipa/ipa_dummy_isolate.cpp index 24434e85d31809e2..fa50be5309eba3c4 100644 --- a/src/ipa/ipa_dummy_isolate.cpp +++ b/src/ipa/ipa_dummy_isolate.cpp @@ -15,16 +15,8 @@ namespace libcamera { class IPADummyIsolate : public IPAInterface { -public: - int init(); }; -int IPADummyIsolate::init() -{ - std::cout << "initializing isolated dummy IPA!" << std::endl; - return 0; -} - /* * External IPA module interface */ diff --git a/src/libcamera/ipa_interface.cpp b/src/libcamera/ipa_interface.cpp index 9d30da29228fabb7..273477a5272677b7 100644 --- a/src/libcamera/ipa_interface.cpp +++ b/src/libcamera/ipa_interface.cpp @@ -19,9 +19,4 @@ namespace libcamera { * \brief Interface for IPA implementation */ -/** - * \fn IPAInterface::init() - * \brief Initialise the IPAInterface - */ - } /* namespace libcamera */ diff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp index f8f91d6219b1aee4..55d5bff287c3366d 100644 --- a/src/libcamera/pipeline/vimc.cpp +++ b/src/libcamera/pipeline/vimc.cpp @@ -364,8 +364,6 @@ bool PipelineHandlerVimc::match(DeviceEnumerator *enumerator) ipa_ = IPAManager::instance()->createIPA(this, 0, 0); if (ipa_ == nullptr) LOG(VIMC, Warning) << "no matching IPA found"; - else - ipa_->init(); std::unique_ptr data = utils::make_unique(this);