From patchwork Thu Jun 1 09:56:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 18675 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C18C3C328F for ; Thu, 1 Jun 2023 09:56:36 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 3521C627CD; Thu, 1 Jun 2023 11:56:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1685613395; bh=S2puBFGwZ/w5QwcuK3963B+w3Ph36QunnZY4eLDbHlQ=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=vM3SUk8W1TIKXhSbFHb7lrn47h0ESs5lkaF7yEYUdJr7KxmmM/gXIjxPXgy153M/e 7QRXzuJqu84+2smpkDkac+Y9VLbCncfbQRkOBOyySjE6/Qr229M0jGJItu4uoymdw4 Apv+/krcHFciGELsuyltNDo1Orno+bCrz2AEqWgqS2b7bBSvT6roVVxd1RRVnPVKzU B6sPORqJnqrnGZf9EU6lKwR6E9hs9+yLuYPMM/SxiVlzsvhLmvA02ufl0+Y+pRebQU 8CkckR6b4isK0jGuvcZJuplfnP4EgEvuRJUXucnUYp5ETUwwQVfhMTE6zQ180i6SJe wPQ5SQ4Wuxzsw== Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 91E22626FA for ; Thu, 1 Jun 2023 11:56:32 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="jvygl4yv"; dkim-atps=neutral Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-30aa76048fbso592524f8f.2 for ; Thu, 01 Jun 2023 02:56:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1685613392; x=1688205392; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=99hTf1x62+87E/VKSOzixF+A/Fl9SJ0Rqk6/PYzjbbA=; b=jvygl4yvUNayVZsQuWSE8jBU+6bqyFTc3n7gDv3xdEB68BntvrS2Ry45pJgI0FA0TN fbsyQGb0hgbpAssrAnu8rrRy+uVkTezMXKxp1HOD09L+/ZqYa8PrZHlaaNufVr/K2TRN sqEwvt6hJ1oVrjCWRgPLRZgfvh4sqdQkUUFKrk4OeHN9X1ZF8KT77AHmN0z1UV4LthAW i98J7Ql7dLNzdf//zHg7CyJDi7JqgibunYTTM7gCs7An0uxFOdC+d+Df6p+qZVnAsJ0K H7sx0qMnHpLmYJUShfeoRzD9iRowTVKDQf6/TJly0HcOJaQJ9BDl551efySgfKS8diBm DyPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685613392; x=1688205392; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=99hTf1x62+87E/VKSOzixF+A/Fl9SJ0Rqk6/PYzjbbA=; b=jHvBzpobexzPX5j57g2Ezov69R0doZZmZJmqJpjkcz0NxckVRn3wUzKJ+2kEfeJswo o0Fs8HntWcvaew8QEx3+vxGkU1dRmuOwlQOAb04JPaEyGfxRHY8ua7xdKSFx2fjfWLml LL6EHUNOykfsnHWaXeb+QKm7PYQJC2B/vATfJogHwYLnIZT1bS1MnU8assNZTTunfLv/ bl3vV5EraKrKCnKSe2+/UjRrjsRMEtUyf+hV25qJ0hBzE18EPjJNU9FUwXegwTCcYFz2 OS6+m5N8G0EYfzg9SqJOMVbsExoCMRjy60xKxunWkZKKuxykUqd1hjxc0dfenMPl9GI7 Rj4A== X-Gm-Message-State: AC+VfDwGyptBogMMO+pjPtgU3v3hrTLSIbw/oBz0hGxTuiqH0J8diL3U GqoRZODJ16s5hIO4iNhM+hBe0YSRx7W5bTfjVHqB6g== X-Google-Smtp-Source: ACHHUZ4DtJoMFgMv2atfqzdRKhETnL8VD3A5rCy1iFUWpg8AoU7Rk3JxmlspqEIzP9S2KvoDWjk4uA== X-Received: by 2002:adf:e4c4:0:b0:309:3a1e:fc54 with SMTP id v4-20020adfe4c4000000b003093a1efc54mr1366679wrm.7.1685613392105; Thu, 01 Jun 2023 02:56:32 -0700 (PDT) Received: from localhost.localdomain ([93.93.133.154]) by smtp.gmail.com with ESMTPSA id h12-20020a5d6e0c000000b002ca864b807csm9889531wrz.0.2023.06.01.02.56.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 02:56:31 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Thu, 1 Jun 2023 10:56:28 +0100 Message-Id: <20230601095630.25443-2-naush@raspberrypi.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230601095630.25443-1-naush@raspberrypi.com> References: <20230601095630.25443-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v1 1/3] libcamera: controls: Define a default lens position behaviour X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Naushir Patuck via libcamera-devel From: Naushir Patuck Reply-To: Naushir Patuck Cc: nick.hollinghurst@raspberrypi.com Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Update the LensPosition control description to explicitly define a startup/default behaviour. On startup, the IPA will move the lens to the position given by the default value of the LensPosition control. Typically this would be the hyperfocal position of the lens. Signed-off-by: Naushir Patuck --- src/libcamera/control_ids.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml index adea5f90acc5..f6dbfd6c0bf0 100644 --- a/src/libcamera/control_ids.yaml +++ b/src/libcamera/control_ids.yaml @@ -610,6 +610,11 @@ controls: sharp). The minimum will often be zero (meaning infinity), and the maximum value defines the closest focus position. + On startup, the IPA will move the lens position to the default value of + this control. This can be overridden by the application providing an + alternative value though this control, or setting an appropriate AF mode + with controls::AfMode. + \todo Define a property to report the Hyperfocal distance of calibrated lenses.