From patchwork Fri May 19 16:22:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 18641 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 32FB4C31E9 for ; Fri, 19 May 2023 16:22:30 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id E3DC86285F; Fri, 19 May 2023 18:22:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1684513349; bh=xB07lu0dDMtJPXv5ttm7E5kTf000VC8udf1ZV1hHHEY=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=QSZvQZ+Y2o/hwsom0EgRzyvMZf3o2DySpbwlKZtPB7aqVmy0FSVerUf4AgZSZv2X/ wKdzgLDSjuWdXXrkgJa5kgddZ/jM6ea/7VM3XQ1hJWQGQ2ydME2VKs/O7BXlEz0j08 /Sfx7qrtLyeGmHpz7rsve3wx/Ba79kwACdifaAF0Bps4W2sHhmcwaZLjsdYNQYRDN0 WwPDGV+KR9kBBNWffUNYUpSEq0Bkf5NeOhRXuFNm61boeu6rv2E/q0cbA4u1mJw8gZ TuHdbK1Pld9b2S40Lh+y0cxPBjyXyKltJfAGUIZpu8GqOpXfDw8D4jsfFOmg0W2C4x RKHBF02WhB36g== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 13003627CD for ; Fri, 19 May 2023 18:22:28 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="CQ/Zzbzu"; dkim-atps=neutral Received: from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it [93.61.96.190]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8C9AA720; Fri, 19 May 2023 18:22:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1684513334; bh=xB07lu0dDMtJPXv5ttm7E5kTf000VC8udf1ZV1hHHEY=; h=From:To:Cc:Subject:Date:From; b=CQ/ZzbzudfMbco4MZi2QlLurdhn2npe9Zu76dmKhgedTj0DddIOLbcIQBTI8n94Xz nsP3rd2EmMyLPVrha3pOjDcO0p8awZZurgYghxHPZFkUvrq209GnSMVCv/ECkpmf5k EY/s1HgqIgbndhczXoUVlh6fci62LRo7dxg7BbFY= To: libcamera-devel@lists.libcamera.org Date: Fri, 19 May 2023 18:22:15 +0200 Message-Id: <20230519162215.413831-1-jacopo.mondi@ideasonboard.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] ipa: ipu3: agc: drop hard-codec analogue gain range X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jacopo Mondi via libcamera-devel From: Jacopo Mondi Reply-To: Jacopo Mondi Cc: Jacopo Mondi Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" As the sensor's analogue gain range is known drop the arbitrary limits for the sensor analogue gain. Signed-off-by: Jacopo Mondi --- src/ipa/ipu3/algorithms/agc.cpp | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp index b5309bdbea25..74a14675fca0 100644 --- a/src/ipa/ipu3/algorithms/agc.cpp +++ b/src/ipa/ipu3/algorithms/agc.cpp @@ -47,10 +47,6 @@ namespace ipa::ipu3::algorithms { LOG_DEFINE_CATEGORY(IPU3Agc) -/* Limits for analogue gain values */ -static constexpr double kMinAnalogueGain = 1.0; -static constexpr double kMaxAnalogueGain = 8.0; - /* \todo Honour the FrameDurationLimits control instead of hardcoding a limit */ static constexpr utils::Duration kMaxShutterSpeed = 60ms; @@ -96,11 +92,11 @@ int Agc::configure(IPAContext &context, maxShutterSpeed_ = std::min(configuration.agc.maxShutterSpeed, kMaxShutterSpeed); - minAnalogueGain_ = std::max(configuration.agc.minAnalogueGain, kMinAnalogueGain); - maxAnalogueGain_ = std::min(configuration.agc.maxAnalogueGain, kMaxAnalogueGain); + minAnalogueGain_ = configuration.agc.minAnalogueGain; + maxAnalogueGain_ = configuration.agc.maxAnalogueGain; /* Configure the default exposure and gain. */ - activeState.agc.gain = std::max(minAnalogueGain_, kMinAnalogueGain); + activeState.agc.gain = minAnalogueGain_; activeState.agc.exposure = 10ms / configuration.sensor.lineDuration; frameCount_ = 0;