From patchwork Thu May 4 14:48:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 18602 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 6EA08C327C for ; Thu, 4 May 2023 14:48:10 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5A855633B5; Thu, 4 May 2023 16:48:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1683211689; bh=l7vYOSDfk2w3/NkfqAVHXW3cFN465DX/rZaoY2+qhew=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=VueOaUDlI60zpUZQ1x/pokdec4b7/XseoMegX58lmJMw/Tg3sw4aKdXGPBfr0EC6h 1GIa15FvXUMxVEO5IUQfQUzaWhuQwcqARbkOC4hvigWXHdmtsXK6BdwDixEoxrVCbQ pGt4tNJqwi3J181nQoduY3VdCixDexf7CRQQk1nIRPoc1joOl9x+IOUw9+4Co5b468 vAX4BxU+w8vvGnAKUxyvi6+TMbsSUEy/FG8REeE6CukaDQXJQonIYg4md+m77oYu9p 0H3s32cuygVvLN1e8kt3l/PeNYMucNlL+rWj3AI8c/Rv64yeGcKDpKGFgxTlw1LWZK CdmgeM8sG43gQ== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5AFDB627DE for ; Thu, 4 May 2023 16:48:07 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="YevsyqP4"; dkim-atps=neutral Received: from Monstersaurus.local (aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net [82.37.23.78]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C0EF27CE; Thu, 4 May 2023 16:48:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1683211683; bh=l7vYOSDfk2w3/NkfqAVHXW3cFN465DX/rZaoY2+qhew=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YevsyqP4yefnFaDVsx7zme37BT6UuNJF41DnTKV7DAVxnBB6lYrF0NgFTblm688LD 0jOJdobGdLNnCJxMpyV1F2OQJiw5C1+PwLROdLtlkXdG9qQLFuu9560s3Lx7OJF6mw Ek9g0sKIG0JGhcLvrKFb/NSMyJv3Q3qcdBOx+K7g= To: libcamera devel Date: Thu, 4 May 2023 15:48:00 +0100 Message-Id: <20230504144801.2590668-2-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230504144801.2590668-1-kieran.bingham@ideasonboard.com> References: <20230504144801.2590668-1-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 1/2] libcamera: ipa_manager: Only parse IPA modules X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Kieran Bingham via libcamera-devel From: Kieran Bingham Reply-To: Kieran Bingham Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Ensure that when we iterate the libcamera libdir we only select shared objects which are expected to be IPA modules, with an ipa_ prefix. Any shared object not matching this filter is ignored and not processed by the IPA Manager. Reviewed-by: Javier Martinez Canillas Signed-off-by: Kieran Bingham --- src/libcamera/ipa_manager.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp index 030ef43fb994..c0c2f027e902 100644 --- a/src/libcamera/ipa_manager.cpp +++ b/src/libcamera/ipa_manager.cpp @@ -206,6 +206,10 @@ void IPAManager::parseDir(const char *libDir, unsigned int maxDepth, if (strcmp(&ent->d_name[offset], ".so")) continue; + /* Ignore any modules which are not IPAs. */ + if (strncmp(ent->d_name, "ipa_", 4) != 0) + continue; + files.push_back(std::string(libDir) + "/" + ent->d_name); }