From patchwork Sat Mar 11 19:05:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Elias Naur X-Patchwork-Id: 18380 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 14777BE080 for ; Sat, 11 Mar 2023 20:02:37 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 832F5626D6; Sat, 11 Mar 2023 21:02:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1678564956; bh=E1PxUu2w+skXAgnuNDA0mBtPYPNSegr2JU9taNinm7Q=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=fmvSvXxIGGNmoYYIkZ/9f940vDEFCaa0lnTVw0cysPPyr3OnRBfkAYauMQfQP8VY1 RpLYGIOwQYtsm375TGqY+L+OZonenM3GAEOla4w4iOazuYMA6jrK9Pg2o9vToB1kUS 6K4TrTUce6HUMU7t7MnA8lhU/oq8S0bitudqKQC1H2OQvggAvGv+PvUtRQrQYCLkAX aRmsJIaGS3msCpMRFy48I3g3V9LhNYMviBoRVyYY2vAj4ACvoM3LN90Jq8kPJzXad9 Napu6/nNYU+8iHR/XpfvCQIWB/RiHDKodJ8i/w9x7lb6Q1HNTLfERA6k4T/sjG40bL 8mAp0tgHKICMQ== Received: from mail-vs1-xe2e.google.com (mail-vs1-xe2e.google.com [IPv6:2607:f8b0:4864:20::e2e]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0289761ED5 for ; Sat, 11 Mar 2023 20:05:40 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=eliasnaur.com header.i=@eliasnaur.com header.b="rxmFVfaK"; dkim-atps=neutral Received: by mail-vs1-xe2e.google.com with SMTP id d20so7628745vsf.11 for ; Sat, 11 Mar 2023 11:05:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eliasnaur.com; s=google; t=1678561539; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=vS7wbTXk7KoExEUsDUdKHOzhATj80NAZyJYhWuKhuEM=; b=rxmFVfaKhmxRxPBJEBoNERBQHu10VnAAC/vOV4BSn/hk9yauQGhp/ACmMoLdwBUjjv JO/t4oWjtfHcJ2PT0wAZtnBC/p+U94Q6RU8rgFUgSzhxzQm2+cyQzhQpkIv+Bz025H5b 9ndLsSE2zU5xoHN1VVM7ojPaL3+j0yKweSyPv9dDrgafuxxn+l6zoKSdHPAxfcbn2TNf 8O2QsaG/0vu1LSzg/sBqHJ69PEcCzXHJ4+tW1tMd9rN8axnItQxLlyAJvlcCCKaPiuLE cLgKlMIZ6sKyFv2OYHwFqgKsbjETTyOdq3uudnMrsPrgVDjI5SvA0R/KZg31ZvswlfDB Dc0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678561539; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vS7wbTXk7KoExEUsDUdKHOzhATj80NAZyJYhWuKhuEM=; b=ZOcY2XB4x+dg04VEeRcSj8YJy00qzTtjw+bWMlsbyWNNY90M2APlbc0Xs7GRMMxtVK fo1mD8JhwiHnKet7vfAPyQAGa0GfXb1F+dBBHnED/GQeuJEv4s7OcFBTHTlt87f6wQtK jMqNzgNzkmZrXGwPbe+ew+TeRCtZ+O9Rzd5I8RuNxzJPXQUuy5+MiAKhQIMwrp0lFxPq xFYqE9PgDu7hop9Ny8L7SmYkUFhIdsAUZBMxA3lIIrzhTdQcZAhSNHhw8qiU/K9UpnCV lyG0WDSL3Q9EpIdbotqw4PyCyLD5KhtEePgoTTEk+nbpghoZTTnneCvsBI39Xzuwrnys cNUQ== X-Gm-Message-State: AO0yUKWSN6ArGnM4lRIUbqJTFbJoVp356XShdztfK8Ktmkb5w809pNGz l5K5H1cnvEPNvm6lTxXaU4F3BGr8gSO16qyYVNk= X-Google-Smtp-Source: AK7set+zHKnXX30zOrB9Wjb+V8/b0MpUPc57FUWfgHVTsh99nMLYyY6iopbJvx694eqvupoHD36JxQ== X-Received: by 2002:a67:ffc1:0:b0:412:220e:369c with SMTP id w1-20020a67ffc1000000b00412220e369cmr16065321vsq.21.1678561539482; Sat, 11 Mar 2023 11:05:39 -0800 (PST) Received: from localhost.localdomain ([190.53.0.133]) by smtp.gmail.com with ESMTPSA id s18-20020a05610201d200b004122a65ee17sm304032vsq.21.2023.03.11.11.05.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Mar 2023 11:05:39 -0800 (PST) To: libcamera-devel@lists.libcamera.org Date: Sat, 11 Mar 2023 13:05:25 -0600 Message-Id: <20230311190526.17104-1-mail@eliasnaur.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Mailman-Approved-At: Sat, 11 Mar 2023 21:02:35 +0100 Subject: [libcamera-devel] [PATCH] libcamera: v4l2_device: openat(2) with O_CLOEXEC to cleanup after exec(3) X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Elias Naur via libcamera-devel From: Elias Naur Reply-To: Elias Naur Cc: Elias Naur Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" It's generally a good idea to openat(2) with O_CLOEXEC, but this patch also fixes a problem where the v4l2 devices would report -EBUSY after an exec(3). Signed-off-by: Elias Naur Reviewed-by: Jacopo Mondi --- src/libcamera/v4l2_device.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git src/libcamera/v4l2_device.cpp src/libcamera/v4l2_device.cpp index 57a88d96..ad9d1e37 100644 --- src/libcamera/v4l2_device.cpp +++ src/libcamera/v4l2_device.cpp @@ -86,7 +86,7 @@ int V4L2Device::open(unsigned int flags) return -EBUSY; } - UniqueFD fd(syscall(SYS_openat, AT_FDCWD, deviceNode_.c_str(), flags)); + UniqueFD fd(syscall(SYS_openat, AT_FDCWD, deviceNode_.c_str(), flags|O_CLOEXEC)); if (!fd.isValid()) { int ret = -errno; LOG(V4L2, Error) << "Failed to open V4L2 device '"