From patchwork Sat Mar 4 10:37:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Advait Dhamorikar X-Patchwork-Id: 18339 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id F2480BF415 for ; Sat, 4 Mar 2023 10:38:35 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 458F162676; Sat, 4 Mar 2023 11:38:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1677926315; bh=7b1QmTZYWrCGNobxEr6ek+0Tk1Q48A3cUMklDdZUUKI=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=IpEbfDhhtJ7LEtD8BgRvzVlI2PCqB21sHfpywfGA6ueUgBXOabglYZL941ZOYyTln J95KjYwfnSwdr1L4hl98HDXqlt2zDCVBxNhJALaMSjSMcC+ogqJlzRIy+Pr2xwz2+x fedIBhntjYRGYjrkDvTqpuqFj8bEcmkpW3XZMc+zlKcfQ/LgkbFadFKTTCA+hSyBDc 9uZzZhMwXz+cwvV7OonyH3GTbeUr009SAu6VNCkz2nCHsNc+a2oKQlH3OJMfIgwT8g +MmyBlscqz/71QCxTQ+ERijmMunRoxRUc9tdC6Mbm2NRJ+JtScVJ/AhWAIJAobPurn 8m0kfxtiPvu1Q== Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 71BFD62676 for ; Sat, 4 Mar 2023 11:38:33 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="KpaLdYvR"; dkim-atps=neutral Received: by mail-pl1-x633.google.com with SMTP id i10so5269829plr.9 for ; Sat, 04 Mar 2023 02:38:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677926311; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=94OAPV/tYvYH7Tpgu+6GAl9kmD3PYLAANiePiOQJJFI=; b=KpaLdYvR8TS1F88kX27/UtaagStwju9hLqdWDBjtVSlkgghyD57+v68j99RG20MVlP HlGYdx3lLsD1CTIQJcA+cPmtbHMXi+8NaUpBujMXEdKDuTKRZ4jAfHoNag82CQg7HYLG shKjJrQREsMUkEqoXvn9szrEH6nyVWYH+2tn02vxKdomePwroAdbTMW1BuYSyG9oBpI/ QQ14OdKtPCdjZlx/NRCni+LFIZL+dCzk6OTRVEu6gUfXoG1t4jIUxQXovKYvVE9airSO b/A03IDSPQy/cSrcO035BDek2mMUYHBosX0v6Vmft416cd7JMN5xqSi5yqPzyTFTMLO3 e0Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677926311; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=94OAPV/tYvYH7Tpgu+6GAl9kmD3PYLAANiePiOQJJFI=; b=M3SDUTwKFwTVPNAPXKSVrhwSVxPIgt0XpbJ/XVuJWWS5F2eJtdXLzFbHnR6B4kkjiw DQ9qK3mSzYSqJEz1Nl5rwvNgY14gDz/c0wXVPjQsyZGJem6ebRH+iRNLWKBIHDU+fOXi dpoJrhDY44simPdKq3/SL4gEApfUHIlrZGx1GyEe4WhGL+UqgSaYO/5y5rrBLWCr2TOk o7L2jfIsYWQawk3wh2MmOIBdNBqABasQIOERkFVvWrIkG/AwcggGZexcxN8lpdKf6dEy HrosR14/zB8Nbzlsk8eqfiYoH5lk6s09Z6KlgwW8ibVfLzrRry2LkKnRcR6vxi5C8IPg W34g== X-Gm-Message-State: AO0yUKXyaZBgNk3FF7rXhv+2QFlRH+1nVF1bULF1GFURaGPUP13xCH9V aPyasZXD9dW8GmootIc2KmYCyn4IglDsNw== X-Google-Smtp-Source: AK7set/e0myPg6iDN6/K5F+sIshAbxFW7TZWThT1B0ygkN/RdQjgaV3yvbWOoTjuJQyLRTaY+ICDTA== X-Received: by 2002:a17:902:d486:b0:19d:1230:439b with SMTP id c6-20020a170902d48600b0019d1230439bmr6244859plg.63.1677926311458; Sat, 04 Mar 2023 02:38:31 -0800 (PST) Received: from advait-HP-Kde.. ([2405:201:1e:f0ba:ed27:cf12:52b0:dc08]) by smtp.gmail.com with ESMTPSA id h6-20020a170902f54600b0019cb131b89csm3047707plf.254.2023.03.04.02.38.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Mar 2023 02:38:31 -0800 (PST) To: libcamera-devel@lists.libcamera.org Date: Sat, 4 Mar 2023 16:07:58 +0530 Message-Id: <20230304103758.9154-1-advaitdhamorikar@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v4] documentation: guides: pipeline-handler: Fix spelling error X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Advait Dhamorikar via libcamera-devel From: Advait Dhamorikar Reply-To: Advait Dhamorikar Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The pipeline handler writers guide incorrectly references the VividCameradata::init() impelementation with a spelling error Fix spelling of "impelementation" in the pipeline handler development guide Reviewed-by: Kieran Bingham Signed-off-by: Advait Dhamorikar Reviewed-by: Laurent Pinchart --- Hello Kieran, Thanks for the review, here's another version with the mentioned changes, I'm currently studying how simple-cam works, looking forward to contribute more. Regards, Advait Documentation/guides/pipeline-handler.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst index e1930fdf..4d38fa23 100644 --- a/Documentation/guides/pipeline-handler.rst +++ b/Documentation/guides/pipeline-handler.rst @@ -1409,7 +1409,7 @@ function to the V4L2 device buffer signal. video_->bufferReady.connect(this, &VividCameraData::bufferReady); Create the matching ``VividCameraData::bufferReady`` function after your -VividCameradata::init() impelementation. +VividCameradata::init() implementation. The ``bufferReady`` function obtains the request from the buffer using the ``request`` function, and notifies the ``Camera`` that the buffer and