From patchwork Thu Feb 2 11:12:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Fend X-Patchwork-Id: 18232 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B44ECC329C for ; Thu, 2 Feb 2023 11:13:08 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id D1F86603BF; Thu, 2 Feb 2023 12:13:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1675336386; bh=WVDPlWY1vqRIsqop3ZaZPhFJ7lDNiETEj+WaEiZVmao=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=BI30YlIr26eHOdStd7weY0qrivp+A5OzywfK08qYae+OZLIoW9R1ocN3qr7WBnEoA 30VoEuBYB1J2LM7d2kKbabBJF3C2imMwNmLBrvVDLXfterwqgoGD5trH0lRCimJT4R UIOmLDvaoibwo8GMJsSdoSzrnu+wFqEvXW3JCouGLxHvpk2fC0G6yQAWRB7PnOR9qn LzYEOonDioDnnxdDix+mXPyipILVsK2K8rP+SPJKTrP396m3wvAStMmM+/2u0fy64d 6vBNS6hnET0AxHaoe0P4WrX1KomNG7j3LsnlsqUkL9i1bi+O8iTnnSsLQIGh2CHCIP d8TSJivOdlDow== Received: from lx20.hoststar.hosting (lx20.hoststar.hosting [168.119.41.54]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D043B625DD for ; Thu, 2 Feb 2023 12:13:03 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=emfend.at header.i=@emfend.at header.b="hQZpeIPw"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=emfend.at; s=mail; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=2oKGyofZPFVFSyRgoLKCL6PmzvWBKUB94KWl8cArkF8=; b=hQZpeIPwSVBswh6kPyP5cPwwnI xslHJunuuHPrRlu2hGfjlHvQ45HAFF7CKZhsE5BdWUlB+jvqieeMUBy36mGGT1Yq9rjRvOPLcXdht w2R1Aktvz8f3V30JX2QYrjo+aMxukI9Xh1iM/UMC5HI+yWrrwKbW4/+ASJmRmYUdesWg=; Received: from 194-208-208-245.tele.net ([194.208.208.245]:51050 helo=localhost.localdomain) by lx20.hoststar.hosting with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1pNXWZ-008Uhs-2g; Thu, 02 Feb 2023 12:13:03 +0100 To: libcamera-devel@lists.libcamera.org Date: Thu, 2 Feb 2023 12:12:48 +0100 Message-Id: <20230202111252.3366729-4-matthias.fend@emfend.at> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230202111252.3366729-1-matthias.fend@emfend.at> References: <20230202111252.3366729-1-matthias.fend@emfend.at> MIME-Version: 1.0 X-Spam-Score: -1.0 X-Spam-Bar: - X-Spam-Report: Spam detection software, running on the system "lx20.hoststar.hosting", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: This method allows v4l2 controls to be set directly on the underlying v4l2 subdevice. Signed-off-by: Matthias Fend --- include/libcamera/internal/camera_lens.h | 1 + src/libcamera/camera_lens.cpp | 10 ++++++++++ 2 files changed, 11 insertions(+) Content analysis details: (-1.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address 0.0 KAM_DMARC_STATUS Test Rule for DKIM or SPF Failure with Strict Alignment Subject: [libcamera-devel] [RFC PATCH 3/7] pipeline: rkisp1: transparently pass lens controls from the IPA to the lens X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Matthias Fend via libcamera-devel From: Matthias Fend Reply-To: Matthias Fend Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Instead of parsing the values in the v4l2 controls from the IPA and passing them to CameraLens (where they are then converted back to v4l2 controls), the IPA v4l2 controls are reused directly. Signed-off-by: Matthias Fend --- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index d4fbcf4b..e4f328cb 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -403,14 +403,8 @@ void RkISP1CameraData::setSensorControls([[maybe_unused]] unsigned int frame, delayedCtrls_->push(sensorControls); CameraLens *lens = sensor_->focusLens(); - if (!lens) - return; - - if (lensControls.contains(V4L2_CID_FOCUS_ABSOLUTE)) { - const ControlValue &focusValue = lensControls.get(V4L2_CID_FOCUS_ABSOLUTE); - - lens->setFocusPosition(focusValue.get()); - } + if (lens) + lens->setSubdevControls(lensControls); } void RkISP1CameraData::metadataReady(unsigned int frame, const ControlList &metadata)