From patchwork Sat Aug 17 15:20:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 1819 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5DDD6600F9 for ; Sat, 17 Aug 2019 17:21:13 +0200 (CEST) Received: from pendragon.bb.dnainternet.fi (dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id EF9EF98C for ; Sat, 17 Aug 2019 17:21:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1566055273; bh=+cUeGq6v9LDYO54X80qEGfBMuubBG+fSZnXJC3Ux1jQ=; h=From:To:Subject:Date:In-Reply-To:References:From; b=EuzyjSxmu600CViBGMgP+9tvTjRAIxYWUEeAUb5VsOnAnEvQ1rY/l8o/Qpvrab6bq FZoHl6k8gx5yx1naKvb/pv5hFcrZ+24FVUIch9sJIpPxNGgg+7TldJOrsN+TP7oaF+ H+FZNd1RPdSyxWcjx2a4EqilnXTfJf0g/bOvrsJs= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Sat, 17 Aug 2019 18:20:47 +0300 Message-Id: <20190817152104.10834-2-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190817152104.10834-1-laurent.pinchart@ideasonboard.com> References: <20190817152104.10834-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 01/18] libcamera: object: Make message() method protected X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Aug 2019 15:21:13 -0000 The message() method shouldn't be called externally (except by a few friend classes), make it protected. Signed-off-by: Laurent Pinchart Reviewed-by: Jacopo Mondi Reviewed-by: Niklas Söderlund --- include/libcamera/object.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/libcamera/object.h b/include/libcamera/object.h index 5c251a822d9a..3d08d69a9044 100644 --- a/include/libcamera/object.h +++ b/include/libcamera/object.h @@ -26,11 +26,13 @@ public: virtual ~Object(); void postMessage(std::unique_ptr msg); - virtual void message(Message *msg); Thread *thread() const { return thread_; } void moveToThread(Thread *thread); +protected: + virtual void message(Message *msg); + private: template friend class Signal;