From patchwork Mon Jan 23 14:06:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mikhail Rudenko X-Patchwork-Id: 18174 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 40C5ABEFBE for ; Mon, 23 Jan 2023 14:06:39 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id EFACB625EF; Mon, 23 Jan 2023 15:06:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1674482799; bh=DLekmU5YxUdpDQJaNMa/zEFiFDOu+7zfKc3VjzXgj3I=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=4a9Cmo+l+lCpCAQ2Hioyljlb4TkKjsRONob1ved3iRICy2+tJdIwJEnrkGx+r88Pb iX1HUH3vXYb33Z+7h+zk0MIeE3czXmi9CFn1N79JEKaGszLfDO29aSieoOGQ5lJbAZ VYZvjMzoO2JzWp+0eYQ0/gnS/5OVhUGZSO2rNicXL5y5qcpa9bSRIQtSdhy3vbHwE9 O4Z94qwEwJhq+CsrrBjknMVXTgdGXA1U4EKU3G2ZdtuNr2uKm9gtT1pihN2mkwAdnD 1Y6Txlz3+1O+yE2g144dXy3BuB/gOYPzsCMuajB2ZZJdnqDV0kgDL8gIXY7RJrwUHD G1pZVHuO07Txw== Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A22D7625D8 for ; Mon, 23 Jan 2023 15:06:36 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="YVRx/k2Q"; dkim-atps=neutral Received: by mail-lj1-x22e.google.com with SMTP id y18so13186439ljk.11 for ; Mon, 23 Jan 2023 06:06:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=N+q4oXWlN7tVgrlEigWQgWnFoiDOaEvPc0hFBSvDfyE=; b=YVRx/k2QtubRnUjXDoGPztuA64o1KpqQ59yWfDVLMYIEC7NPeXVfNbBTVhjf5OvDBl rH+e8wfxKJ6lEI5RcS87txSOE0EhqJqZEvOu95wCLXlHZDyOaAQomH+JA8HZAF5rZ1Jn ig7PwN/bLC+zsVPn+MIcgDaYZNO4p7CfEJq/nqAof3Hlp0w44Gg7f0KGesDMmgu4KVpt jDbP2annVxpLETQcS25WW4nzqwKVBvSLqxXyjFSJ+Xo2Pskc6j+zS112ROMKZWEcTblc aty15C4WuLE6pyBh4VUr3CPHMbugB8+wjhZ1cyZVD4X4c8XhTSHmYhAI95MC/k3CMb0T 0Swg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N+q4oXWlN7tVgrlEigWQgWnFoiDOaEvPc0hFBSvDfyE=; b=QVbBZUGfGo1eCAVYcPlZ+ly2FlYOPX6vX7E4xcjYc8QwVZKIVzEkTz4ZRIocEpXPqw EBqQqwW/pRBLbF4lLQ/dTpY3r/2oZmqXbcUDZ1bDFuzx4eFkfLyz1J1+9dV0glXO7ixb XVt7X12A0kwuaCAVFRUIflyjuJVqCLcBk8SzoQbiyjhE//tj1yumADqBvGljHvE9I0l7 9DsBOEayh6sAnWQ7BZuzAQE26Rq2x30c/zoDUnpKxOoBWv7RqqY4OUZUxwrGs3ko8Ce9 S8+5xrDzIXAnkp5Qk1Hfr/FSzOB8vL2KZs2PlEO0wNco05iIxbs7KbzbnqFVSq6t+mrb E+HA== X-Gm-Message-State: AFqh2kogmEAekZu4M2xUOCxT6N7VlYn6NqWV2LUNV+skQAmM+piWN6kv cLlkmTudH/ifhocGKL30hpaQooadIkc= X-Google-Smtp-Source: AMrXdXuNvvXc9PpIY08j9oU2ij6DmmcGqLWg7XJVV+8wtkVBaa+G8YQCNw+QeKtLHyOB7H9iR4UZiw== X-Received: by 2002:a2e:bc25:0:b0:27f:bedc:6f09 with SMTP id b37-20020a2ebc25000000b0027fbedc6f09mr8004246ljf.7.1674482795678; Mon, 23 Jan 2023 06:06:35 -0800 (PST) Received: from localhost (93-80-66-125.broadband.corbina.ru. [93.80.66.125]) by smtp.gmail.com with ESMTPSA id k20-20020a2eb754000000b00287eb396f27sm4463926ljo.7.2023.01.23.06.06.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jan 2023 06:06:35 -0800 (PST) To: libcamera-devel@lists.libcamera.org Date: Mon, 23 Jan 2023 17:06:19 +0300 Message-Id: <20230123140619.177878-5-mike.rudenko@gmail.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230123140619.177878-1-mike.rudenko@gmail.com> References: <20230123140619.177878-1-mike.rudenko@gmail.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 4/4] ipa: rkisp1: Raise maximum analogue gain X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Mikhail Rudenko via libcamera-devel From: Mikhail Rudenko Reply-To: Mikhail Rudenko Cc: Mikhail Rudenko Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Omnivision OV4689 sensor driver exposes maximum analogue gain of 16x. Raise kMaxAnalogueGain to 16.0, so that the full gain range can be used. Signed-off-by: Mikhail Rudenko Reviewed-by: Jacopo Mondi --- src/ipa/rkisp1/algorithms/agc.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp index e3470e25..e4cb2fc7 100644 --- a/src/ipa/rkisp1/algorithms/agc.cpp +++ b/src/ipa/rkisp1/algorithms/agc.cpp @@ -38,7 +38,7 @@ LOG_DEFINE_CATEGORY(RkISP1Agc) /* Limits for analogue gain values */ static constexpr double kMinAnalogueGain = 1.0; -static constexpr double kMaxAnalogueGain = 8.0; +static constexpr double kMaxAnalogueGain = 16.0; /* \todo Honour the FrameDurationLimits control instead of hardcoding a limit */ static constexpr utils::Duration kMaxShutterSpeed = 60ms;