From patchwork Wed Jan 4 16:15:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Matti_Lehtim=C3=A4ki?= X-Patchwork-Id: 18085 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id ECA9ABD78E for ; Wed, 4 Jan 2023 16:31:56 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 32220625DE; Wed, 4 Jan 2023 17:31:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1672849916; bh=lK6zSkernqH9qql71Z9YSI3zLaL2q2iF3oUqMfcIbDk=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=nmHGep9bh9poTLdH537Vv66/O1Z2o7h1Ja8QMUoKHNZB4HT+Vg5ms7WyJepmwneu0 O2ygHx1xE531jqD1lr9j/DKQ3i+ku3+03eRszornyjV5VSvDyQpb4aqiqzcWplFExf fW7hJ0aAp3kM7PuwHq217+UlUvMLGKqBL1Vcleb+h98SFWJLsCRrzY74HXlsIPQMxJ FDIVqavG3n9Km5xAK24EFeUXm5f1rcAA76S8yg3onyudjY96lvCMAlaadhs4vZmK4+ J/m2WVzq/xiAkuX4KyJy9w/t8LSkWr6Be4LuFw+3yvfj1umoCK5uimaPoZjFTd+tGw tlMjkK1keQRUg== Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A3F4F603C5 for ; Wed, 4 Jan 2023 17:15:24 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="KZHl5ohZ"; dkim-atps=neutral Received: by mail-lf1-x135.google.com with SMTP id bp15so51060407lfb.13 for ; Wed, 04 Jan 2023 08:15:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kRuNMhYlDOZTUn/sYF0y7T0N10eWjorF2vYXFMtcUlM=; b=KZHl5ohZPVaKkLFiTPr7ByYkp8OQmeFuyGhgd+SVCIj1IwENsK1fcr7IkQYaz88s3L pcLgDbFsBToYyprfm07b+MGx7j8At8vBBczubw5ssijLbqN7OzV13zkSOwvJlEeqU6Rh j1V+stMG/r7DaqDq/+xe7I1l9Jk58mTACnwSnRsghH+JUZzHiAcduApoqMAiJOgc2hot HXJJX8CTGuht8NysaVRY4fuYi5vAtsiOhH3iAGlK29OebvUtykkANR64r5HsoJScEz7f 6jFSmYQ30GFhGnSTvEF8qlayplzyxLT00N99qZexoaPBcCwlZPPVE1gvUpcdl5jXpio/ 1bQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kRuNMhYlDOZTUn/sYF0y7T0N10eWjorF2vYXFMtcUlM=; b=dnuEc0qw3F0F3xgH6BY3ezJoiIVlGip1gfzfLqRkJIAhkbIZF5WlEMHwxQOc0Hxl5y Z9+0SkgXQChV/+dsdh3fAR8q2+BWMQuP91JNvrBiDijwT3JMD4mQWCfiI6Ky1lGJIFgd 1X5uSJZP5YuZgND8gYgnv9CAeEHOX2HLt4s+xH7cP2+LXGusj2rZ/Cs/dzfz0TGHbgXQ KJ5Kn7LdXBBvyELJbo3eXzXIHIJ6rxA7wx8QAu5ja6/EfQQJGmSyE5mW5IpEjQi05x2r z0vw/wbpM07BrstdQLk3jGZ7Ayi/DsnUjqdGEbopV8KqNWTYtcdRbZwSKKyjUmUdvXEr dgqA== X-Gm-Message-State: AFqh2kpOkWtNrKTW/t79QwmxoOunjiDqbxyQ/SLK+RjN1MwGUfaHsoo+ p5N0tqoMvzh/wHGvLcVM8RXXLLnyZsE= X-Google-Smtp-Source: AMrXdXvUkBvCs+dA30aJ3LD484FXQSaM2PGFi6OeZ3uY0d/zbD6fbFZd4K7WIHbcx128mScEsDl3WA== X-Received: by 2002:a05:6512:3a8f:b0:4c8:5f19:ccb8 with SMTP id q15-20020a0565123a8f00b004c85f19ccb8mr14249065lfu.48.1672848923702; Wed, 04 Jan 2023 08:15:23 -0800 (PST) Received: from i-vetokaappi.home.lan (dsl-hkibng42-56733b-36.dhcp.inet.fi. [86.115.59.36]) by smtp.gmail.com with ESMTPSA id a25-20020ac25e79000000b004a0589786ddsm5219482lfr.69.2023.01.04.08.15.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 08:15:23 -0800 (PST) To: libcamera-devel@lists.libcamera.org Date: Wed, 4 Jan 2023 18:15:01 +0200 Message-Id: <20230104161501.100221-1-matti.lehtimaki@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Mailman-Approved-At: Wed, 04 Jan 2023 17:31:55 +0100 Subject: [libcamera-devel] [PATCH] libcamera: Use C++17 [[fallthrough]] everywhere X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: =?utf-8?q?Matti_Lehtim=C3=A4ki_via_libcamera-devel?= From: =?utf-8?q?Matti_Lehtim=C3=A4ki?= Reply-To: =?utf-8?q?Matti_Lehtim=C3=A4ki?= Cc: =?utf-8?q?Matti_Lehtim=C3=A4ki?= Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Fixes build failure on some build environments. Signed-off-by: Matti Lehtimäki Reviewed-by: Laurent Pinchart Reviewed-by: Jacopo Mondi --- src/gstreamer/gstlibcamera-utils.cpp | 2 +- src/libcamera/camera_sensor.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp index 16aac441..750ec351 100644 --- a/src/gstreamer/gstlibcamera-utils.cpp +++ b/src/gstreamer/gstlibcamera-utils.cpp @@ -154,7 +154,7 @@ colorspace_from_colorimetry(const GstVideoColorimetry &colorimetry) case GST_VIDEO_TRANSFER_GAMMA22: case GST_VIDEO_TRANSFER_GAMMA28: GST_WARNING("GAMMA 18, 20, 22, 28 transfer functions not supported"); - /* fallthrough */ + [[fallthrough]]; case GST_VIDEO_TRANSFER_GAMMA10: colorspace->transferFunction = ColorSpace::TransferFunction::Linear; break; diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp index ae3127d6..a210aa4f 100644 --- a/src/libcamera/camera_sensor.cpp +++ b/src/libcamera/camera_sensor.cpp @@ -427,7 +427,7 @@ int CameraSensor::initProperties() LOG(CameraSensor, Warning) << "Unsupported camera location " << v4l2Orientation << ", setting to External"; - /* Fall-through */ + [[fallthrough]]; case V4L2_CAMERA_ORIENTATION_EXTERNAL: propertyValue = properties::CameraLocationExternal; break;