From patchwork Wed Dec 14 09:33:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harvey Yang X-Patchwork-Id: 18002 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id EE718C328D for ; Wed, 14 Dec 2022 09:33:39 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 9554563354; Wed, 14 Dec 2022 10:33:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1671010418; bh=E2m7QffPxm8qYVlVx57pZSYUeDiX2bTpVnCJ7pyvUN8=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=QH4R3ojtkQm4yOC8Nm8qqkzVeGVY0GsjkikXmKBA3JocD2z/TEqoteJaka1Ww6l3d oKJ7NMJ3762/GSw5VFZ8TbMrpAndfAvBBPLwZk1ia6g1k+c0xAILfNHCXQGU/3bQAt FvIPzTCKBoclQBqP+g9LsDNVNYrgGCSAhZ/kuOAL66svULUNm8QdfJebj8WQIymIw4 9VZAkekivxhcqK10ZopdRRCvi3utrILi/cgV2MvIO4bz+x9CHKefi5UYawOh6dYR0U 4uJ+35EQbdskjjcAwVoUufdFW0lGXoBWc007nEBwKmxxww+kRWQtuiTGgI7HJPZoEZ hTJKCujmR31/g== Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 6FE2663354 for ; Wed, 14 Dec 2022 10:33:37 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="JWutsoK+"; dkim-atps=neutral Received: by mail-pf1-x436.google.com with SMTP id n3so4020359pfq.10 for ; Wed, 14 Dec 2022 01:33:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BCX1ICp7HjraiuyI8JwLhhuX3e6nM3XCIN0/+nJsM8c=; b=JWutsoK+N7Z68aabs37nzlAV/hxEKh05aPwa3MIeNYDCnQQWrvi6MOrXFBxRiUARKj 2sS6U3F7fsDA7JAzkOi3vNBbG8+7yi7yEYJ4v7NdZbOmJasDQYuw4wE+8gehvSW9KR8F 2Q0tvkHNqmPvHsyFC7Ak/TSQ6oIvNegT2sLbA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BCX1ICp7HjraiuyI8JwLhhuX3e6nM3XCIN0/+nJsM8c=; b=j3qK1DMbL6zEX4gvJZdcVkDjA9fI4A4c/qQ7zlg8kztSeQ31B7TOonAe+l4/ro9rzn GVrPGjfbZsdtRMhnpsjgj6g/B2Vp/CeD4cxjYoasU/3r/jriK1E3lByJL1LofRFAqy1D lRedKr15RqYXi0riWCWqS6EYBS7QjfXGH7ZzHlGLtm4BwixEZeUmlFrDC6hg8aV9xmjd 17UOIbI+sz3heTn3OLFvgGWGsi2OMlIrPhOXQyxKiuytvPq6mSkR6qPAtYGttQ5SdgYC /0O7EJlJC8KwJNJTwxJ+XR+gEnJq7wklN/NnZRT2WidqT9cpuDasIMlWXsuZnKehTqPB 6PZg== X-Gm-Message-State: ANoB5pnHiGvT3vLlEYgFeMVveMf0qw1bcSyfvRMCVXxwaaRRkn20EAyi fIrwRLtt7U8g5QlXreilFp4tMOTGwr3Qcb1h X-Google-Smtp-Source: AA0mqf66qSmj8p3TcBXbmP0YNwoocucOVZM06VuhN93hL+8onhrzur98mEZzBu+6BhOtLuViFb8tDQ== X-Received: by 2002:aa7:9e02:0:b0:578:f60:6fac with SMTP id y2-20020aa79e02000000b005780f606facmr21443703pfq.26.1671010415786; Wed, 14 Dec 2022 01:33:35 -0800 (PST) Received: from chenghaoyang-low.c.googlers.com.com (46.165.189.35.bc.googleusercontent.com. [35.189.165.46]) by smtp.gmail.com with ESMTPSA id d206-20020a621dd7000000b0056bc742d21esm9331190pfd.176.2022.12.14.01.33.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Dec 2022 01:33:35 -0800 (PST) X-Google-Original-From: Harvey Yang To: libcamera-devel@lists.libcamera.org Date: Wed, 14 Dec 2022 09:33:24 +0000 Message-Id: <20221214093330.3345421-2-chenghaoyang@google.com> X-Mailer: git-send-email 2.39.0.rc1.256.g54fd8350bd-goog In-Reply-To: <20221214093330.3345421-1-chenghaoyang@google.com> References: <20221214093330.3345421-1-chenghaoyang@google.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v8 1/7] Allow inheritance of FrameBuffer X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Harvey Yang via libcamera-devel From: Harvey Yang Reply-To: Harvey Yang Cc: Harvey Yang Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Harvey Yang To add buffer_handle_t access in android, this patch allows inheritance of FrameBuffer to add a derived class in android. Signed-off-by: Harvey Yang Reviewed-by: Laurent Pinchart Reviewed-by: Han-Lin Chen --- include/libcamera/framebuffer.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h index 69553999..61244829 100644 --- a/include/libcamera/framebuffer.h +++ b/include/libcamera/framebuffer.h @@ -46,7 +46,7 @@ private: std::vector planes_; }; -class FrameBuffer final : public Extensible +class FrameBuffer : public Extensible { LIBCAMERA_DECLARE_PRIVATE() @@ -60,6 +60,7 @@ public: FrameBuffer(const std::vector &planes, unsigned int cookie = 0); FrameBuffer(std::unique_ptr d); + virtual ~FrameBuffer() {} const std::vector &planes() const; Request *request() const;