From patchwork Mon Dec 12 15:02:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 17981 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 63413BDE6B for ; Mon, 12 Dec 2022 15:03:10 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 22D1D63361; Mon, 12 Dec 2022 16:03:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1670857390; bh=YWPWwqQkHBcUXVJShx6TFB02q7dRvu1h8sWW3ltEzD0=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=bsVwbRAcswi6FuiBBDZt9VLHyxRfBrXzPNH0SjyPEFrzdW/qFqC7lKHOLqFatwY9f HXLiiRmSINmvMQ+4YPRMv9yJiTSg2wq6/dTMfFnmHFMew9IfE4AblbYn5BaSxn88FE L3zJVcrSfxQLxZdu4GVZczwREawYRnCbMG9UX277hhfLXFwmkqjflPlicIEUjOWu1y 6OgFpVwYHskx1/MH1AOkDYlkmWE3eQxZVSmOwf0naCZuD/MVrWV4ROqyNLGYG0PTp/ hTz9KIEdMquP1VB4NoGIUnYH8Vu8M2rq+TReQYy8UDp8j7280cEjZLnKh3l09/J6nz T2WOLpIPnLqHA== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A22CB63361 for ; Mon, 12 Dec 2022 16:03:08 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="SM9u1sQq"; dkim-atps=neutral Received: from umang.jainideasonboard.com (unknown [IPv6:2401:4900:1f3e:7d24:3f0:3e81:fb16:ab4d]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 38FB46CF; Mon, 12 Dec 2022 16:03:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1670857388; bh=YWPWwqQkHBcUXVJShx6TFB02q7dRvu1h8sWW3ltEzD0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SM9u1sQqV3N2l7Pao6Af3949b3MqXPkDtYotvC7WcheOAf7eAkZNeMWtM6zjvFv0Q PU86HKsDJRiz3ghDubkorBfJ6L1XHFFqeAv3SYo794hgyhR+10mQimHN4CADePlSOF PLgoN4j6ReOu7kF4u9tOOts1i8SXp6dLlS+yomhA= To: libcamera-devel@lists.libcamera.org Date: Mon, 12 Dec 2022 20:32:55 +0530 Message-Id: <20221212150256.69004-2-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221212150256.69004-1-umang.jain@ideasonboard.com> References: <20221212150256.69004-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/2] ipa: Move kMaxFrameContexts to mojom interface X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Umang Jain via libcamera-devel From: Umang Jain Reply-To: Umang Jain Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Move kMaxFrameContexts to the mojom interface. This will prepare the pipeline handler class to manage queuing of requests to the IPA. Signed-off-by: Umang Jain --- include/libcamera/ipa/ipu3.mojom | 3 +++ include/libcamera/ipa/rkisp1.mojom | 3 +++ src/ipa/ipu3/ipu3.cpp | 3 --- src/ipa/rkisp1/rkisp1.cpp | 3 --- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom index d1b1c6b8..b1ecd57f 100644 --- a/include/libcamera/ipa/ipu3.mojom +++ b/include/libcamera/ipa/ipu3.mojom @@ -8,6 +8,9 @@ module ipa.ipu3; import "include/libcamera/ipa/core.mojom"; +/* Maximum number of frame contexts to be held */ +const uint32 kMaxFrameContexts = 16; + struct IPAConfigInfo { libcamera.IPACameraSensorInfo sensorInfo; libcamera.ControlInfoMap sensorControls; diff --git a/include/libcamera/ipa/rkisp1.mojom b/include/libcamera/ipa/rkisp1.mojom index 1009e970..62c59fbd 100644 --- a/include/libcamera/ipa/rkisp1.mojom +++ b/include/libcamera/ipa/rkisp1.mojom @@ -8,6 +8,9 @@ module ipa.rkisp1; import "include/libcamera/ipa/core.mojom"; +/* Maximum number of frame contexts to be held */ +const uint32 kMaxFrameContexts = 16; + struct IPAConfigInfo { libcamera.IPACameraSensorInfo sensorInfo; libcamera.ControlInfoMap sensorControls; diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp index 08ee6eb3..1cfae8fe 100644 --- a/src/ipa/ipu3/ipu3.cpp +++ b/src/ipa/ipu3/ipu3.cpp @@ -55,9 +55,6 @@ static constexpr uint32_t kMinCellSizeLog2 = 3; /* log2 of the maximum grid cell width and height, in pixels */ static constexpr uint32_t kMaxCellSizeLog2 = 6; -/* Maximum number of frame contexts to be held */ -static constexpr uint32_t kMaxFrameContexts = 16; - namespace libcamera { LOG_DEFINE_CATEGORY(IPAIPU3) diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp index 6544c925..509be2d3 100644 --- a/src/ipa/rkisp1/rkisp1.cpp +++ b/src/ipa/rkisp1/rkisp1.cpp @@ -41,9 +41,6 @@ using namespace std::literals::chrono_literals; namespace ipa::rkisp1 { -/* Maximum number of frame contexts to be held */ -static constexpr uint32_t kMaxFrameContexts = 16; - class IPARkISP1 : public IPARkISP1Interface, public Module { public: