From patchwork Fri Dec 9 08:19:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 17960 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 7D89BBDE6B for ; Fri, 9 Dec 2022 08:20:01 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 4765063351; Fri, 9 Dec 2022 09:20:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1670574001; bh=6WIFo5utB76imWZ9s+f10d/k/eBUWdAREDOOFKKbTdU=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=xHCm77YpYTRbwF4Wt/TNrjYF+sNipnrv/lhBgN37HhZrZWbLVMGP6JT4pGepksiTa eSUGdkU6In73NiXgo/A4wABqQXrd3KPhDkoBTubOagKq75k67JSv+zB9J5urde88Ta 0JClHluTWajZqv7V8blpuYY8FIFk82WZnm/inI5JF7dOpuFHiUKh7c2LCcNTRxHVaQ Xp/Y8ZR/KWgNYH7Wsd2t0DXUEXydZzvOmbC338bVCjJ6SOOjBcjthwBXlxEz60uSDH KVkNXCiaVorftxPRMUaC4gc2lD08tHznycVKOHL1PdUxE11XVOQwdBR5TErn1yL5gT 7GM1aVmN80Irg== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id BA4626334A for ; Fri, 9 Dec 2022 09:19:57 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="QvwC99zw"; dkim-atps=neutral Received: from pyrite.tail37cf.ts.net (h175-177-042-159.catv02.itscom.jp [175.177.42.159]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5DD7C480; Fri, 9 Dec 2022 09:19:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1670573997; bh=6WIFo5utB76imWZ9s+f10d/k/eBUWdAREDOOFKKbTdU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QvwC99zwFREZelk/bMZHD6NCG+aOhNH6NgyDyZJk4xM/TfB8tQQNDen20wJbDr8JF qJjMJyCZRB5BnqUcCpnKyjAMNnKomsRPtVILyOoTcyIWDzo0XGMI9czR2l6zXnDKYp LHBw4uyEeRHIVqPwlsKgJZqpCrxvzg4CTheOFyrM= To: libcamera-devel@lists.libcamera.org Date: Fri, 9 Dec 2022 17:19:34 +0900 Message-Id: <20221209081937.598303-2-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221209081937.598303-1-paul.elder@ideasonboard.com> References: <20221209081937.598303-1-paul.elder@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/4] tracepoints: request: Add private pointer to request_construct X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Paul Elder via libcamera-devel From: Paul Elder Reply-To: Paul Elder Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Since some Request tracepoints print the public pointer and some print the private pointer, print both pointers in the constructor tracepoint so that they can be used to associate with the other request tracepoints. Signed-off-by: Paul Elder --- include/libcamera/internal/tracepoints/request.tp | 13 ++++++++++--- src/libcamera/request.cpp | 2 +- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/include/libcamera/internal/tracepoints/request.tp b/include/libcamera/internal/tracepoints/request.tp index f1e54497..491c7705 100644 --- a/include/libcamera/internal/tracepoints/request.tp +++ b/include/libcamera/internal/tracepoints/request.tp @@ -8,6 +8,7 @@ #include #include +#include TRACEPOINT_EVENT_CLASS( libcamera, @@ -22,12 +23,18 @@ TRACEPOINT_EVENT_CLASS( ) ) -TRACEPOINT_EVENT_INSTANCE( +TRACEPOINT_EVENT( libcamera, - request, request_construct, TP_ARGS( - libcamera::Request *, req + libcamera::Request *, req, + libcamera::Request::Private *, priv + ), + TP_FIELDS( + ctf_integer_hex(uintptr_t, request, reinterpret_cast(req)) + ctf_integer_hex(uintptr_t, priv, reinterpret_cast(priv)) + ctf_integer(uint64_t, cookie, req->cookie()) + ctf_enum(libcamera, request_status, uint32_t, status, req->status()) ) ) diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp index 949c556f..b9fb17d6 100644 --- a/src/libcamera/request.cpp +++ b/src/libcamera/request.cpp @@ -356,7 +356,7 @@ Request::Request(Camera *camera, uint64_t cookie) */ metadata_ = new ControlList(controls::controls); - LIBCAMERA_TRACEPOINT(request_construct, this); + LIBCAMERA_TRACEPOINT(request_construct, this, _d()); LOG(Request, Debug) << "Created request - cookie: " << cookie_; }