From patchwork Tue Nov 22 12:03:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 17841 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 5EEA5BE08B for ; Tue, 22 Nov 2022 12:03:55 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 22D9863314; Tue, 22 Nov 2022 13:03:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1669118635; bh=6FM3QFEdtWOjmGPVWwF1R7Y9blkyrWCuUZsR9VgGB5M=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=VIZds3PzYlPib7mF3qe/6HsOZ0vSJZeNlqjET/UA1pudppLLia/kEG8y4m56uiqxi a/hWZWfE0M6QWOAfXlDFSFbFzCwJEQ2e6LBmhnQof4xrB57Q6jSZszrK04nzVNxfsa zJbd0B0EY5H16WrU0WVhuJksLfeR0l4LJPe4e4MpM9NgtGaaJwteoYkSanGsWXHLA5 /wzm+dhOx4qOYWZjydXFCzViPCv5yYtYp0cgbO1vify6oQTSYK9ZrP+ORhCzmacdS7 7rniCOpCBHFS83X/oncn0jILnHQYaCMYhbf6Y79ZiXn21cyIbTekaHsuptqpy/Xehw Wc77gN2xjUDkQ== Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5834C6331E for ; Tue, 22 Nov 2022 13:03:52 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="OyxY1OuM"; dkim-atps=neutral Received: by mail-wm1-x334.google.com with SMTP id j5-20020a05600c410500b003cfa9c0ea76so11115146wmi.3 for ; Tue, 22 Nov 2022 04:03:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QM3FI8MTL2nC87hq0DBBUKu5+wbe6JmvxrskIriyLVE=; b=OyxY1OuM+GOfLUlnq5hHrl8+gJJQUvQby8lHcTHchEB1BYWY7T2A7FDy3m6Q/iUFOi trqHTrQCSAWqw9PQLAgD3zJzYFizJQghI5Ss1FpnoSUkbS16mON//FIyw/1OriKgkxrv OuI0C3/A7l+hp90QLcBmbAfEFahHDiJZo2V/ulbIm5ASAQIfAruF+24T48d49FbaktQ9 PcKoyVr1TZgwXjnqHEKZ3PmrJm6rCpZuHuKmJc+ytK7L3qxVSJ4zlhzez4UBy6YdQh02 vpg25zo7/XTi83NKYk/VAX0kRvYF/Dp9f+5qisWYAFj6mSrLU97e5iRGEQ1WDCdkeF5v GyCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QM3FI8MTL2nC87hq0DBBUKu5+wbe6JmvxrskIriyLVE=; b=c0jYJcR8/Unrnu9qbb5LpC7FEPdwzB/NOPQ3uGe4Ks4Dy9MoRkJBo8/VjEXk5zz6EM AsKuPSpgbZYXRXpsyqEy+sxej2HyjPo272/6om7O/D5yIqy09zv282Of9rN8pmCA57k/ m25lI09D+Zky4RRlXin6ihP8ik30eQoblYemQdfEOtw3lQG3QberghWN1DQl+poDREXb hhdWISBU8o/KFxO9/HoYp/aTS1+jMlWhkCNUjl9aizagBkD/cKSvvQ60lA3jPsSten7F Px7g43UKrM63CAC5LPvRz5UxSJUWzmm4gT/aCz82ULj1NrhBjj7GsdCPvpCY46oLJIHS 2zgQ== X-Gm-Message-State: ANoB5pk1m82nQitlDcEA4I1zmVpjO7RhNrzUikiO6dANlHSqtLI46y2V YZsGTCzKOdFnTbxwjme2mZPOEFF2hUMWfg== X-Google-Smtp-Source: AA0mqf5BTv7xfbT8F4+jqJBncuMMVbWQFQdfng8h17cHkU3K5/HUuqlEyzdj35L9orZq/NtYiCk0QQ== X-Received: by 2002:a05:600c:1e89:b0:3cf:774b:ce6f with SMTP id be9-20020a05600c1e8900b003cf774bce6fmr2999915wmb.133.1669118631385; Tue, 22 Nov 2022 04:03:51 -0800 (PST) Received: from pi4-davidp.pitowers.org ([2a00:1098:3142:14:e4a2:3070:eea4:e434]) by smtp.gmail.com with ESMTPSA id p18-20020adfe612000000b002366a624bd4sm12119141wrm.28.2022.11.22.04.03.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Nov 2022 04:03:50 -0800 (PST) To: libcamera-devel@lists.libcamera.org Date: Tue, 22 Nov 2022 12:03:43 +0000 Message-Id: <20221122120343.4825-4-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221122120343.4825-1-david.plowman@raspberrypi.com> References: <20221122120343.4825-1-david.plowman@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 3/3] libcamera: pipeline: ipu3: Reset sensor HBLANK control X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Plowman via libcamera-devel From: David Plowman Reply-To: David Plowman Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Resetting the sensor's HBLANK to its minimum value is no longer performed for us, so the pipeline handler must call the helper method to do it. Signed-off-by: David Plowman --- src/libcamera/pipeline/ipu3/ipu3.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp index e4d79ea4..47ec6bd0 100644 --- a/src/libcamera/pipeline/ipu3/ipu3.cpp +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp @@ -566,6 +566,9 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c) if (ret) return ret; + /* Reset the horizontal blanking to minimum in case it has changed. */ + cio2->sensor()->resetHblank(); + /* * Pass the requested stream size to the CIO2 unit and get back the * adjusted format to be propagated to the ImgU output devices.