From patchwork Tue Nov 22 12:03:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 17840 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 832D6BE08B for ; Tue, 22 Nov 2022 12:03:53 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C258B6331D; Tue, 22 Nov 2022 13:03:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1669118632; bh=G8frbkZVyMaSX9UYgeVvPpdfKXAc2FdySpJjfQpPuxE=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=xX0bhW4TfhBF7xsUlcPcWj02CvaixHlxR3qUVnsa9c/Qp9VlLLmgW2jGDLyG6JxhZ RZDG3vNvi5WLjmvWh3Djft8ove6W141+/uyv/ZhqINYkbqa+Ffx5HK6bWJOA3FyouG kDXUi1+kZi8KLPi+YRVMPdzvu17kYLblrdHFWka8CyBZYiQhQNX1jxtR9J6DwzK59g QtAQ12gsvUpiCg0WhtU5Nki6RQwOY3pSh2yCu4HcQriEgxik8VNVhAvlgZxgc30Z3K sm/ycrcdtNiHJdepC5L9fyqoYqi4DQ9C5zoiGe9EZS5OUDf3l5LBlUYBYrHdxg/A84 8yMhvhh5QImfA== Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3133363314 for ; Tue, 22 Nov 2022 13:03:51 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="INqJK4iA"; dkim-atps=neutral Received: by mail-wm1-x333.google.com with SMTP id l39-20020a05600c1d2700b003cf93c8156dso11102565wms.4 for ; Tue, 22 Nov 2022 04:03:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=K9hGY02j4oY0BOoVT4ZMtV3lThC8jKwGnVMrWOiWI24=; b=INqJK4iA7Nk825hrmgVGDW3REsF0fVGcrR2ELMdekCgRPXRdUBJptBfIYgjAdKEkY2 kQ0DhvIS4AFTUHBPUiHKctj5WBc7AFnnVMc2R35yqshDYE9KFvQJwGpnk7JqsJ+Ebaow yQP72xXUygPUkkItZikskPSEhnui9CsODB3Vv5uAcEUuHpRZeVddBCKaaX43lPeNT1mT BwVjfIgMS9tP+m2kH8XoPxdpSJBWSKhIYjzMiOS7K7SBwkNM8WWvTBQFmfw8YVj6CZb2 /2Fnihg7+b/3fTOth5urxUnhxTHmDkp+lXaS9k/Z8ZivgjBDlkuVIk12b0A8vIHJFBKu uzAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K9hGY02j4oY0BOoVT4ZMtV3lThC8jKwGnVMrWOiWI24=; b=DOozPFGIfqUR5wZWE6zTWnJOzDkFM/cOnyjWnX56Ay6tyrO2ov9iKo8cnH4X6R9nWK JNeN32P0gu/P03zIVjGCb1VdurG/ijWZIOaWPI+AD9n8LHzX5FMj3Ef4Ww7Yd8HdXKWL 7kr90PevZl/8mve0ppD+XuClUKbyC8/raBvfCtcY28gj4jpkj4tAJmLzvq7HJzRorCCr T29xMos7DWXBzCvSqfys6DL8R+A8hlBitm95iiR2P4/U5iubH6bGxtnaK2Yc3WFOJCI4 tn9N9xF2OriiCgfmGekrJElJnBjHGJrQNQneIsy3Y2TOKLaugUuQ470c22uYE4v4HWJz akcg== X-Gm-Message-State: ANoB5pnDQJOk6rmCsKBsx7NHuk9kfo+P4O33X3TLpmgh1o/Pt+3LuCI+ hQ2OOUHBNaNZxZN6A4NadgEFkBuRyJn4nA== X-Google-Smtp-Source: AA0mqf5m19ATH2S5NH5cU1BW2ndJWWjoW80Hd4cLAwomEIcdxarEcwfMf/F6ylb1XkFjZ+sbfQVrpg== X-Received: by 2002:a05:600c:46c8:b0:3cf:8896:e1de with SMTP id q8-20020a05600c46c800b003cf8896e1demr8991976wmo.4.1669118630462; Tue, 22 Nov 2022 04:03:50 -0800 (PST) Received: from pi4-davidp.pitowers.org ([2a00:1098:3142:14:e4a2:3070:eea4:e434]) by smtp.gmail.com with ESMTPSA id p18-20020adfe612000000b002366a624bd4sm12119141wrm.28.2022.11.22.04.03.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Nov 2022 04:03:49 -0800 (PST) To: libcamera-devel@lists.libcamera.org Date: Tue, 22 Nov 2022 12:03:42 +0000 Message-Id: <20221122120343.4825-3-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221122120343.4825-1-david.plowman@raspberrypi.com> References: <20221122120343.4825-1-david.plowman@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 2/3] libcamera: pipeline: rkisp1: Reset sensor HBLANK control X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Plowman via libcamera-devel From: David Plowman Reply-To: David Plowman Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Resetting the sensor's HBLANK to its minimum value is no longer performed for us, so the pipeline handler must call the helper method to do it. Signed-off-by: David Plowman --- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index 3d3a7086..4163cc27 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -632,6 +632,9 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c) if (ret) return ret; + /* Reset the horizontal blanking to minimum in case it has changed. */ + sensor->resetHblank(); + /* * Configure the format on the sensor output and propagate it through * the pipeline.