From patchwork Mon Nov 21 15:44:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 17827 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 22256BE08B for ; Mon, 21 Nov 2022 15:44:35 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id D50096331F; Mon, 21 Nov 2022 16:44:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1669045474; bh=bh9I5bRKF0w2MeqEa0N4v8iZ5H0zEkddiVq8N8dlwCM=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=z607aPOfgUnzHc02tBm+PeifNhJgtfjTYVpWBOumsHnkbpm9+uHgI1EO/2wL/CXde wFt5yUObdnbQnc3ug2WOzyfp/0EDYxuL6JdlVbwQnrgYK6ih8uh/qk3wCX5ou5gLF7 Vqz32h5Cdngl9xOlSJ8QrQgUwHmvgopIjx7sfXbO27pZW4PGGFukHjikOBdcjvAhtg 9/YQR2H980VixMsaWane0ku0ex0fczTxohWI9+bB4AooCvEGSdljmoZiQc6FYFB6OL w6if4qcUbdr00sMq1uNbRpG+SLYJsWGTZD5J7T7YaCyTlA2DQoYAEyZc2l3WIa1GTn EBvNaG4UkZynw== Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 573236331D for ; Mon, 21 Nov 2022 16:44:31 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="WfgnXriR"; dkim-atps=neutral Received: by mail-wr1-x436.google.com with SMTP id x17so7005145wrn.6 for ; Mon, 21 Nov 2022 07:44:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=41Mcjs494HINUeN/gt5bpH1WI2znT1tO4uWTxfMQSOU=; b=WfgnXriR+ocVLgADu71vi804rwTPNipJW/FWp85EJV8jq3O+vhU8+XpQob5fs7rBBH 54Up3Qa0TUco7uU5g59XwrzyyXiJmBtdoqRKb564eh6F4Mdd29O/I/9HY5b0/cCNswPS ZIhGiO/OdlMTHmCF+uU3DKF3Aa+8E7ja0ZuSfWZVPhLDFeYz77h06fKmGfXUyWfwClRy Knxg0icDYmZDKAPwolDvZI6jKJDJxR+3xMrP0DWfouJdxmR1xxsC2Mbc9VuDdv0gq9A/ wdov/RXHLHb5Qbebu08DPuCBz5M6V9ZKz9Vf/riu49CAsnFf10nqcQXgW+0I7/nFzFba ajYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=41Mcjs494HINUeN/gt5bpH1WI2znT1tO4uWTxfMQSOU=; b=hDITbpCk7z1ELTxtLXPoVmXDVKhY1dYoe3UBPYus4RwYpMMHDEtNOXsR4xUeItePsh 0u30e47LKNEJ4j83uTwPolXvRKVymlhXHnoHCqObiQEtH/UZdIOajaWTSGrBhnQtwEkx bJyFsBkQE7KF4aL9ThavXFmtNHqgK20o+79sivBGXF1GfW1YKZf3M+SD1gv66PoJBH5r ACsGdyeYfDUmc75xB5yY2WJ+eds40KuUbztA51Gqgpozmuub14Eda9VPRb+cV9YL5eYn 9qHNoJ9HfGpZOnRQ8URsSiHBneeVAGKcV3hJEenFWCRf+GtM77JGM/DnDzozY99LKJ4m UAKw== X-Gm-Message-State: ANoB5pk9mrhZvwEy9LGt/7QwLd9/zbZIyUtIIR5UpvH50B4c+RskBepH bnVR5/gz/bJuUP3DHA0JjcN8Egpw6lg8pA== X-Google-Smtp-Source: AA0mqf4Z+lSas8hDiclCmDBwClgyYZ1eBq2i2tgoUJvsylsb8hJ0yPRIV8Km2a7UnWmc7965y4qDww== X-Received: by 2002:adf:f38a:0:b0:236:5270:7347 with SMTP id m10-20020adff38a000000b0023652707347mr11828327wro.35.1669045470730; Mon, 21 Nov 2022 07:44:30 -0800 (PST) Received: from pi4-davidp.pitowers.org ([2a00:1098:3142:14:e4a2:3070:eea4:e434]) by smtp.gmail.com with ESMTPSA id t11-20020adff60b000000b0022e035a4e93sm11742257wrp.87.2022.11.21.07.44.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Nov 2022 07:44:30 -0800 (PST) To: libcamera-devel@lists.libcamera.org Date: Mon, 21 Nov 2022 15:44:21 +0000 Message-Id: <20221121154421.11732-6-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221121154421.11732-1-david.plowman@raspberrypi.com> References: <20221121154421.11732-1-david.plowman@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 5/5] libcamera: pipeline: rkisp1: Set device's flip controls as previously X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Plowman via libcamera-devel From: David Plowman Reply-To: David Plowman Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Set the horizontal and vertical flip controls by calling the device's setTransform method now that this no longer happens in CameraSensor::init(). The aim here is to preserve the previous behaviour. Signed-off-by: David Plowman --- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index 3d3a7086..f144fabd 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -632,6 +632,9 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c) if (ret) return ret; + /* Set up the device's horizontal and vertical flips. */ + sensor->device()->setTransform(c->transform); + /* * Configure the format on the sensor output and propagate it through * the pipeline.