From patchwork Mon Nov 21 15:44:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 17826 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 6AD6BBE08B for ; Mon, 21 Nov 2022 15:44:34 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 23EB46331D; Mon, 21 Nov 2022 16:44:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1669045474; bh=wC/eouBOvKoHq7yHhH+rO6xXi0AvXprsYlXej4tsNSA=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=PsfOga6tkH9R3v56uXpOYi8g1QTGWKBDi93dp6wPd9Lgs7VH6Oma6ZdXRkMVcmrtR MCeyQ1F2Zrvogs3JVOZ3z4yBKrG5WWJ8eeWY8pcj1/+zdoL3BQ1ZIkoXvb6gYSZCWk Dg/koOB4kzEJxqNtD9D01mzx2hliXzQopcu1rMJulLSX2dz3UpaevK6wDTqyfc+tA0 FkFAhK7dxqL5nJK259Insmjzf8lZJt87M3luewzFvn1WkZiB2QHDQ8atISPC4qbpld z6662x0cdhNsxHCpRKJCygvl5HAltpbNl3jDhach5IvUbwMaqTISs1oE69s6OJjVFY eKj1ra/ge6AvA== Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A5BF263321 for ; Mon, 21 Nov 2022 16:44:30 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="ZT6ZAYtp"; dkim-atps=neutral Received: by mail-wm1-x32f.google.com with SMTP id m7-20020a05600c090700b003cf8a105d9eso9300877wmp.5 for ; Mon, 21 Nov 2022 07:44:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=quSfxEw9Fkkx4YktgHt5yQsthxWzdQOrtAnA/xUQP+c=; b=ZT6ZAYtp9glbfNNZTNICrOkpInDgzxTRMxjuJM8C0wZAfnoYjUO1D1cKLRAaKlzOq8 YJ/L31Vbve1VJ1wlfKimER9LjnPkKPWjnXCwgnFuIVgousXwNaQJrIDQHFT9QlbIPBz9 MGesCvdkIE4d6xMvd1O4exDll0QEKMXWh7mpBFuz4U0K4rbgwuq4XxNfl9aMI9W1fXd5 dqrWGP66xZ0L1c3d5cMieYXLKFqSFnb8NQ+Qo6LaOiMRq6Wr5lIW6llprNWcipqPpWS7 U75zfKYhrbDsScqHV94V1U3AnPFbv6dcUPEe7asKUFoGF40LV+6MP0Jb3fKoTPsWITRW OWYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=quSfxEw9Fkkx4YktgHt5yQsthxWzdQOrtAnA/xUQP+c=; b=Zj3lNl8L+mfi5wPLChP77oJFIASl638EnFrzV1B9tLvFcLo7Tinrr8EpCAdTP7mhxz ZMuZi7NIs9BGjmlqYLslHR9lH0bV6UOAnYUukqRxO46uz4EySkBaCXLbeLS88IcKU0j9 GxCTQelWlQYIR32pKY44JrJTKABcm1o4PFrBXwAWZGPda2Z2MtJPUxgb8pj52YJoQtu8 CUnpI9B1vhOqVruY+gxUTsackhHJAwBMKGt8GK5ISvndaFobRovfQjViF+8jz9Z2N+KG QI6SOGioyXQzn4Pdo4PZrCPov8zP0aAEoMA++36jFvKV7ti3doJrVtIpy4BvXpAhpNlr QeeQ== X-Gm-Message-State: ANoB5pl8fPt5VZ/c1ibmeijPF+zonSy0fnLqWz5S7p4kkSNvg3qnf4wO 7AO4q3ulg1rQ1V4E9lDSVcWNWJaSKGiM+Q== X-Google-Smtp-Source: AA0mqf4c0jTGN+VOM4QDuEdhqyN+8yCLNLCCczIG1idMBgQUorO+mlPf0wwE0Gew3R1l8fHu3KoMlA== X-Received: by 2002:a05:600c:3d8f:b0:3cf:6a4c:af8b with SMTP id bi15-20020a05600c3d8f00b003cf6a4caf8bmr17364274wmb.115.1669045469956; Mon, 21 Nov 2022 07:44:29 -0800 (PST) Received: from pi4-davidp.pitowers.org ([2a00:1098:3142:14:e4a2:3070:eea4:e434]) by smtp.gmail.com with ESMTPSA id t11-20020adff60b000000b0022e035a4e93sm11742257wrp.87.2022.11.21.07.44.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Nov 2022 07:44:29 -0800 (PST) To: libcamera-devel@lists.libcamera.org Date: Mon, 21 Nov 2022 15:44:20 +0000 Message-Id: <20221121154421.11732-5-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221121154421.11732-1-david.plowman@raspberrypi.com> References: <20221121154421.11732-1-david.plowman@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 4/5] libcamera: pipeline: simple: Set device's flip controls as previously X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Plowman via libcamera-devel From: David Plowman Reply-To: David Plowman Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Set the horizontal and vertical flip controls by calling the device's setTransform method now that this no longer happens in CameraSensor::init(). The aim here is to preserve the previous behaviour. Signed-off-by: David Plowman --- src/libcamera/pipeline/simple/simple.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp index a32de7f3..f25a8cc1 100644 --- a/src/libcamera/pipeline/simple/simple.cpp +++ b/src/libcamera/pipeline/simple/simple.cpp @@ -1120,6 +1120,9 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c) if (ret < 0) return ret; + /* Set up the video device's horizontal and vertical flips. */ + video->setTransform(c->transform); + /* Configure the video node. */ V4L2PixelFormat videoFormat = video->toV4L2PixelFormat(pipeConfig->captureFormat);