From patchwork Thu Nov 10 14:45:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 17769 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id DAD7CC3285 for ; Thu, 10 Nov 2022 14:46:09 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 81FA463095; Thu, 10 Nov 2022 15:46:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1668091569; bh=e5cWW4cvf5Nxfg5oOAVrMT/Yb+FcJFD5zlWOs2WGIvg=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=mVEjDIoJOR7xP70hmJyfY7CFTtdBFcGqaBQiI5a2wEWf4VGC4g9NMjvzaa3mpJyNQ LJqYIK5FrGovnlQYPoJ//xMFyryGJyOr/9aiWv4fdl9FP2oQR6wgPCVUIqvgWF4KnV ZqD1BpMPmOXBX52aF0MksrK7MCWA7Rrfuhs5Dz5Is1hUvtuH30JY4oBrrBX0lP2EqK hvOoOs2aIBFn5FCiQDaNwBu3bFmqY1m/8cXYLYtrfUYmFqSW9VJSIIDdKmyKutcrlL /zp1VHVcY6GDEQrVAFT1MVtMKJqmAiruBbCVkAVBHUyPXCEh9BC0Qb2PIM0/DV5rk1 6DbOChuGZSHYg== Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id DA8D363083 for ; Thu, 10 Nov 2022 15:46:06 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="eb3ObKIj"; dkim-atps=neutral Received: by mail-wm1-x333.google.com with SMTP id m7-20020a05600c090700b003cf8a105d9eso1281844wmp.5 for ; Thu, 10 Nov 2022 06:46:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WSJzl7kxIvYV64/0iXvdPD4pm/+rRQJ7WgzAhvrgZIE=; b=eb3ObKIjBxrNa0WVsF94I+v1Ik6ADd1HzjMRkfRvKhvOsXKawZMwNvBAMvwTkGWy6C C1N8eG/6kUYJR+cNIFowXgX9NTU+uFcjMQliqyDX9md/J02Y1g4UBiVoziSfFyMGyaTX i3YR+My8lFWYlr6eLJJ4mola/DQv9+VHcQ0063VHlncO4X9gijc9kE2/9GdKv2aoxSoT 6ubRX6yJJoBBz95RwmN7Js6SwT9Z8+GKgZoI+BD7NyV4nD1ja5dVD8gUafE5YWQFimV+ z2bnbjXm2n05Rp2p3DncRFXx6imZw8vbuoEJz2fJsJ4nBTyo84d60LBNj9s3mOb6WZ+5 X9FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WSJzl7kxIvYV64/0iXvdPD4pm/+rRQJ7WgzAhvrgZIE=; b=It31/4j0HbjJ9JehdULwAHx+o6M5j6YDNOeXEia44X9C95IkA38F55CnCxzlddMra2 E+tfJZaEgGzwO9yx/0z90EDHOTpfyz3GItmKEaVKLfey7T5O6fGNjOPdZAczbbJVtFmp CYzb2AfQ+/S33zkLilpQbyV2e28AD4OdwiFNdmK22CZT+UY+fgjdyoI91NcnjhqG1k6N YtcLuYQMJF1rK4EDMnP+LFKXhHYMfziF/QfGv+MIOW7dyQV/AA1l5v+vTE2UkmF36yj3 VBJcJw4s/nNLFe2Tanu5T9po5gyNZfk75P93lzPpRsmOdxynKBcBhaq0xygGCHn/DCsh /V/Q== X-Gm-Message-State: ACrzQf2vOmuSJk49vTUZE2VhKdJ2r90b9A7HVTGkqXulTX2RXHD0wZ2P nnedrpDzTGqYErH4SeTq0zfppbyhLzYwmw== X-Google-Smtp-Source: AMsMyM71bGGOu5A9NOXlLEPk/OWC3mS9+IswaYvkfB1qhtFZwr2LQ5nKMVuGEPE+I/Hg9K7umpupzw== X-Received: by 2002:a05:600c:28ce:b0:3cf:6e78:e335 with SMTP id h14-20020a05600c28ce00b003cf6e78e335mr38288108wmd.142.1668091566136; Thu, 10 Nov 2022 06:46:06 -0800 (PST) Received: from pi4-davidp.pitowers.org ([2a00:1098:3142:14:e4a2:3070:eea4:e434]) by smtp.gmail.com with ESMTPSA id u24-20020a7bc058000000b003b476cabf1csm5249759wmc.26.2022.11.10.06.46.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 06:46:05 -0800 (PST) To: libcamera-devel@lists.libcamera.org Date: Thu, 10 Nov 2022 14:45:54 +0000 Message-Id: <20221110144556.7858-5-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221110144556.7858-1-david.plowman@raspberrypi.com> References: <20221110144556.7858-1-david.plowman@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 4/6] libcamera: pipeline: uvcvideo: Set device's flip controls correctly X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Plowman via libcamera-devel From: David Plowman Reply-To: David Plowman Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Set the horizontal and vertical flip controls correctly by calling the device's setTransform method now that this no longer happens in CameraSensor::init(). Signed-off-by: David Plowman --- src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp index 277465b7..4a891c23 100644 --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp @@ -209,6 +209,9 @@ int PipelineHandlerUVC::configure(Camera *camera, CameraConfiguration *config) StreamConfiguration &cfg = config->at(0); int ret; + /* Set up the video device's horizontal and vertical flips. */ + data->video_->setTransform(config->transform); + V4L2DeviceFormat format; format.fourcc = data->video_->toV4L2PixelFormat(cfg.pixelFormat); format.size = cfg.size;