From patchwork Mon Oct 24 05:55:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Dufresne via libcamera-devel X-Patchwork-Id: 17687 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id DAE6BC3287 for ; Mon, 24 Oct 2022 05:56:09 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8390562F1E; Mon, 24 Oct 2022 07:56:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1666590969; bh=1rE44FJQZfuZwwcQV9s/JuDpAcNkLpfV5OTqSPkqhtk=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=WEz0L1xLvC5MSm8jvJuSp6d4GkaIW6/pOAbmGMva2QWjSQS8yYyWd72IJaj2Zc7I3 N90wXeymU65XxeuSz4YyLP6YoWTTZfMQ/UAfx2HiDqdeBY2G1/NMDwZYp7q4NDQV6E Dg8yeOHDlac2yb/c91o4sJ/DAgGYuA+UJlWNOhfw4z8Q/aUmAmswQFVNwfxdHw/z4D 8PKtikMLQLGrzwH+YnDvt13GoigTy8YJ5y+4cnImYWcAg1GPl95xQtZcsmt7FVtzKJ AjUho00bZss+YwNr+zZSSRNTBBfQ3QCo1zY2KwcSM0gE4EoSyTF74t0bxQy3q7xjwz JTfww8Qu95TmA== Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [IPv6:2607:f8b0:4864:20::232]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5118C62F16 for ; Mon, 24 Oct 2022 07:56:05 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=rothemail-net.20210112.gappssmtp.com header.i=@rothemail-net.20210112.gappssmtp.com header.b="HK9b27pv"; dkim-atps=neutral Received: by mail-oi1-x232.google.com with SMTP id o64so9808925oib.12 for ; Sun, 23 Oct 2022 22:56:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothemail-net.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=TV8/l+1UakKHPjAiAmlj9NPWzyQA9lh6hT9yNy15JWM=; b=HK9b27pvieJR0l5aGVdIY0Vim0ejSTK7u05ISW+9wkJENc6QqRbzT6+I4v8HgfWbIP BMswSKDAa7CkOT1enh4pE+QRr0E98jVSc9onnD0ih3sMiqM9gqh2adf39/7q209BhRHq JVRV/h9UlDZiT5R3DEndBFHU8SQBX3gGbrHCKpwd1OK2Paz1CrUX8oLsTX4A9E/BYLTw hOfK/Z3cvzLXLKn+I368HVnXkw/Z4FUx1+6v6hpvv7A6v1rxDnB+RaasUP586UNYTPsD 2peLBEkjwlLdSTwijD7Q/roj6MWA81lYQvHhsDkA6Iy33XP+MLB5wNIWHHh0amksrhak hqKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=TV8/l+1UakKHPjAiAmlj9NPWzyQA9lh6hT9yNy15JWM=; b=K7bknSuuWACTUidDQKhhWhEPqh5kv2dvP5fEhBpIaQsHVBAESoSXFK/lDuJz4FkfAv Y7O5XKc0gnufQ49NvQZtfpOji1D4qrppkybQJytI6tkSC2UBzERKlsIH5ZKaOCLQL0FQ R2zoaw2qnUXqry/Tl9Mo5lVUlhCDpmvQmE9aZ7xHwrYXGHlDz5nlAtjrQDlmPMLiv6Bc 6Z2K19vh9qglZRgZppmKFccR8TRbOIE5E9WPv13eKtDSqe72sB6jdGqLMq5VGsWSDuMg pr+Tk2CJ5/klfZKDBUOAFzivo52Bl72cHy3ojtAD5DvPqfh2Q2h3TFtUdD0VhZk+Y13+ asRg== X-Gm-Message-State: ACrzQf25eD3KHJTabHQ0U0ltKab+53eUWk8olkR5K8qYol7DEbdcPAjl tlPISbD8DutL+sR5yJ7CCJqUL6f8Rbg70P5s X-Google-Smtp-Source: AMsMyM5jiEi5zcqhOPS1gBu9XINwIAjfx9nskIAhR26caPwuEvYuxOwLuOw+pxK1eX9EKhD2zpY0QQ== X-Received: by 2002:a05:6870:b407:b0:13a:f0b9:7c13 with SMTP id x7-20020a056870b40700b0013af0b97c13mr13159590oap.212.1666590953808; Sun, 23 Oct 2022 22:55:53 -0700 (PDT) Received: from nroth-pc.attlocal.net ([2600:1700:20:20c0:7bc3:aed3:676f:10a0]) by smtp.gmail.com with ESMTPSA id x15-20020a9d628f000000b0066193df8edasm3980278otk.34.2022.10.23.22.55.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Oct 2022 22:55:53 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Mon, 24 Oct 2022 00:55:35 -0500 Message-Id: <20221024055543.116040-4-nicholas@rothemail.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221024055543.116040-1-nicholas@rothemail.net> References: <20221024055543.116040-1-nicholas@rothemail.net> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 03/11] Adds rkisp1 metadata required for the Android HAL to use it. X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Nicholas Roth via libcamera-devel From: Nicolas Dufresne via libcamera-devel Reply-To: libcamera-devel@lists.libcamera.org Cc: nicholas@rothemail.net Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Nicholas Roth --- src/ipa/rkisp1/rkisp1.cpp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp index ba3c547e..c536852c 100644 --- a/src/ipa/rkisp1/rkisp1.cpp +++ b/src/ipa/rkisp1/rkisp1.cpp @@ -100,6 +100,13 @@ const ControlInfoMap::Map rkisp1Controls{ { &controls::Contrast, ControlInfo(0.0f, 1.993f) }, { &controls::Saturation, ControlInfo(0.0f, 1.993f) }, { &controls::Sharpness, ControlInfo(0.0f, 10.0f, 1.0f) }, + /* libcamera requires a fixed value for minimum frame duration, + * but this depends on the frame size and the rkisp1 device datasheets + * measure this in pixels per second. Neither the datasheets nor the driver + * specify a maximum. The minimum below is for 1920x1920. The maximum + * corresponds to two seconds. */ + { &controls::FrameDurationLimits, ControlInfo(48505, 2000000) }, + { &controls::draft::MaxLatency, ControlInfo(0) }, { &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) }, };