From patchwork Mon Oct 10 10:24:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xavier Roumegue X-Patchwork-Id: 17566 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 1CBE8C0DA4 for ; Mon, 10 Oct 2022 10:24:46 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 4260162D57; Mon, 10 Oct 2022 12:24:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1665397485; bh=xWzcPJZZOAF4VKZxko1ljs9g2mnUIRley6m2FC4pn/Y=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=j+c5UdzhuNwUUccBXJL83OWAGAtMx2VpmZG5HXkGnE1kn/ZKNxr2881HzEOzEhHTs aFY5GMspJBstx70AUgjTwc0Fxqy4hKC+GayA1fr1L0F5wXoBObjg9eLwtrPe9ky8i8 YjNIlbZR9Pu5dvn4L6cZji06fPyGPCDJorx/se44jlgFQsIzejkRUw1i1MF6kS7KBV 70fZvE30ojdeGitSNBH53cnzMq2ZkNi9TAXS2kbihhH/26gSQi6o1sAM/8J4zmvlYi hzKE4KILWgsqr4B5EJTMjJLiPVcJ3fIhMukUH3MqXukW/0QoDsWYBdaVVRxd2b20uH IZ5OJwJLCFbRA== Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2073.outbound.protection.outlook.com [40.107.105.73]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 64CEF62272 for ; Mon, 10 Oct 2022 12:24:43 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="YyuItsoO"; dkim-atps=neutral ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MMUVmjtoPBDNUlZvytS4b2/OOxYONksH6MpD5r1siS5SPw1eRaXpokh8y/tGIOGvfTIehY8VNtpagQEFrE46rVNPbnYgcmD8thmSDkjv0yduyXuN0TlhBDXGPzcsF0jUDzqijTjM9nK6ZXk9MZwp+faObCgj/2ozG8x8EZ0dUiohuEs28LRkNKNH4prNSi9BqaIWgsYQmrqc5mTWRpk+CjcbiKslzULnrqZRvAJ9r1f85KbpF9ihCAThiT3EZI0O4WbRnzLdp73f4fuyPHBfl/eAfn1CJGt42wh2XDcDiO/hyj449pVtzwcONXip0xmkTPjzYDRj/ijn4Yq7mmfSgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=akya5CH0hsZdDWoh4Hf3mGABsUQnSCNFrwGUAX/36Ec=; b=I0AgqI7Kv+ATW70/wISGcrrx2hFRKVwaxHYR+p3w5UlHSB4WmwiFDl4TPdDjxQD6rBrAzSI8BH1aeLa/YNAfmoOXqaH70nAwIfePNH/yZOHPyHFdkVprPgbCDV+0vbIrHx6U7rbFn2SsYY8rKZBPup5ZNRSQmCfPVKdpSVaA5SZzirD2BB+qbS0PERAdWHAZZQbjhXrtGRDrXs74qKDHMBUR+uyNgnQv6/i0dnZr7dYLN24m0rXJsA0jqJ+Znvfw1BXCTgHK2/ijumnNWbNYqqzQvOVqVpr65sodUGrS6bGFwPqGHv5vRQAjXz4B1zUoVNACY65MMzc9R67q0k41IQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=akya5CH0hsZdDWoh4Hf3mGABsUQnSCNFrwGUAX/36Ec=; b=YyuItsoOWkVsUyI+l7El5CRz5C7dcqiJat2GXhol+VLmoPuqg8FPpi44V2aJ/rFAO/zqGV2kowPoWyK4li/0nHNqUqSKn72KizFHyZ9JZiHo/BmZWcCJFDc1avTwWxf0biGVnRgT/8Q7I/OdEYaJX66Q9lTrEeSA56cTW7uMzIU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8703.eurprd04.prod.outlook.com (2603:10a6:102:21e::22) by PA4PR04MB9269.eurprd04.prod.outlook.com (2603:10a6:102:2a4::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.32; Mon, 10 Oct 2022 10:24:41 +0000 Received: from PAXPR04MB8703.eurprd04.prod.outlook.com ([fe80::4f72:a35a:8c60:63f1]) by PAXPR04MB8703.eurprd04.prod.outlook.com ([fe80::4f72:a35a:8c60:63f1%6]) with mapi id 15.20.5709.015; Mon, 10 Oct 2022 10:24:41 +0000 To: libcamera-devel@lists.libcamera.org Date: Mon, 10 Oct 2022 12:24:18 +0200 Message-Id: <20221010102418.430215-1-xavier.roumegue@oss.nxp.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221010093745.knws36r4m2ura3er@uno.localdomain> References: <20221010093745.knws36r4m2ura3er@uno.localdomain> X-ClientProxiedBy: SJ0PR13CA0126.namprd13.prod.outlook.com (2603:10b6:a03:2c6::11) To PAXPR04MB8703.eurprd04.prod.outlook.com (2603:10a6:102:21e::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8703:EE_|PA4PR04MB9269:EE_ X-MS-Office365-Filtering-Correlation-Id: d3354e80-cc7e-49b6-d4e1-08daaaa9a3b7 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rqu1cfbF9nTcSDWGjzQDjKZgttnv5Q5KrGojELcHy4nwu0NocwwXZFdw7A7zto0dZhgR6/n9ug4zfzDmy8KnDfkcr1ojqHFNI+fHCJi66mAqlbIzsz48cMW8AWLUcWwPVa87xh14R1Glr6qUw0SfcJvuwcuy42LAkIy6gR8ILHsiA9w+cHEFgQPSoMSXorUsM5U0pLH2jD5FjydXeFHB2nM7fHaKJaz99E87WSyTmU+3MSQcGOwUBIZhxhft7q3Hr2RoDyVey3j8kLqrmT+DMgxDYfzrDymbuMWdpva5V4qUd7ZOiIGVq0TBkW4Jc+2Z9XxzGEk1EEkNOcOigDsttDKicu4w8rivA5oaX+8Yc82EbzSVo0C8P00ixyxi/qqFzkkuseXuesim0yxdN5XE/q1uCPHXK1ZT1sjenu+Dewk4tnWBrYEnKvaWY17p1ytwEVqbEp+m/frtyUWVp/peaqnfeoOPED30Q2gMwTV3UjOW1vCFKm5hKAqr3FfwQ1RNiOGW7U1NPVD+sj3NLHltmjNIR8bEDcRdGh8psqTA1G+fBAd148E6eKoojl5Aa30Q7+ijR8k+/+fWW0DTKqKt46R/ipHdGp2a6TMofpl5EUBLsRZs7AzaK8kX0EpZPMhwMs5PXo/9f2kiWtGyTHuBhbQUWQxnfiFLb2dGws3hrEdw/pZqGrVKBI2luE1DDBRt+SB3XvUhainrUDM8PzyU04st3KPwCy9SLjolhlvsKp5r7pmbNqXa6Du+gveuuxMt X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB8703.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(136003)(366004)(376002)(39860400002)(346002)(396003)(451199015)(86362001)(5660300002)(26005)(2616005)(83380400001)(6512007)(316002)(19627235002)(6486002)(38350700002)(478600001)(8936002)(41300700001)(38100700002)(55236004)(52116002)(6916009)(2906002)(4326008)(8676002)(66476007)(186003)(6666004)(66946007)(1076003)(66556008)(6506007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: k+qL8efcnEtPk5bglqI/F8zz+vWv58qtqRm62GcS/VAprQ/wm/hT1mi/VgHtS5A2XzFkZSvJibnw9Ng2BSnObgYam2iMveelwYQzLrC0bPPvOS4wTEPdEClVI6BfKk7QW1uZB3ChbAldn1P/3lPznW3gvyOv/xKk3Aqwa/zTECzp0mo8QMffTVPZxclC8RrZ4LRJuLu1E9EiPqnUcsbXsNVbk6mK7E+QjTycDJMjn4aH49iKIYlQ8dVYEGMy4zXIpVqhLCf/qBjHglbq3z9+qUZ7KFCkLR5UAlRF/ltdDcosOF6IKIBQtQOn8a4cuVWHQg4ELwfiXBNbiMnBdiiWlEdGsYie9BEZR+3G92a43K2wnQG4itHuwYNvHMG0dzaMabu7m2z6mfb3FBVQM4QLezxJTm7JQfYioJ3YMKnCalY8C2lBGPldzLUr3XIOwtZrWaJfQnPVNVWju2wfTLYEp8PseDbQsWfITdtPR3rZN+R/psNXcVAwauAf2j/dfLGYtIYB77AVOx78r4XWhNaKy455xSY5AX5zYzQ93YN/C0mMwZDYcyrcPBgpmiv1HJw975wE6q9m5xlcKGS4Qk7E3GExkpQBBwbHG4nd4RHVwmZxVc2sOFzOupeM7s9+IWzFxTyXn4tX7FKJZG0bqVo7Wg8hfssP5u92+bDuPiD8q3Sl7XapNZi1PQuGtdxxNVcjVaAbT7zd4UE37eS8V315GehkIgKvUt8m6x4gJ5Kt702X2wzkbagAXPis4jS4jgohmhumv7tR51E3l4FCjCECixExoGY4KDJRMOGjlT7j+ovfi+hEOvI/FpmYObZIT2/UJwPfjBlFO++9ilS3efEvyexUmtbBxP821frzxtONiRTFYg+7Vd6Jmnv4xTVvUjZqumPx21/Bmszm8qin5feWf57EwjDuW8BYq1qhCUVU6zCSnDn1YQFt9T0LSOMT6hXGgXOUIW6NEDppWrwjB2M2DaiVM1QVR1MBagMQz/zlsbYtvNYSL996BzksOLUd5yTNvZ7Q9KvxOu4XUOKGH+1TKmyJIYwhcKZfxScHv3X5wFxm5zUUy8o1Q82bOYUFSpKQjTmiu1QhMW0J2zHRfK3pOL2BVv2UYX47G81xxLSYwjJVX1i4KiMdN2QPIrHxNbXHWv0kpp/AiLNw/u4D9kUloe+nBOz1rJnM4Ct+fCIGnAyBJrJbjaGtQg8JORkHlk9OAVPm0LJsJhiZ84cZM9YsWzhhEOs+kPxwYm80xLUia1dz+LQLfDcnuGlGY95AsJXSuLWSZzLon+pnjGwzQS4nMkj8onQqtAxqb7R89cD9CM3MqVDs4HWo3he0Z2ZDN3BBPh2alQSykGGE8UapLNq9qkJkqBLlnxRyEXB7AcLtAih1mTrzolTAWyN6pihfL8fm3hH8cUzn2VlxFG8F5kxXJeccCgcFyzbeuMHB1kjx7am/ALhI958P3hEA8a1phlCOKkMFr6iuUzNH1ncHRDUfkePI3hnNDstQnFXp7/Qcm5OGw0NLN6lVu6Ln2hby8Ig3tq46Kd+aZUeRbH9h60SxTJOmpalLtT7HG3MHLiA3BGZRoI3lMQXQmyVHz8NjQLi/6OLFtyTto0B4caeRSs1++A== X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3354e80-cc7e-49b6-d4e1-08daaaa9a3b7 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8703.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2022 10:24:41.2232 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pWDBWcP7aNDv5aSggOaqb5tsHxpBbMMTU0w3kn+PCAPr62JEVIInCURWJS76sznpPaJGvKktwwDRvpmalVc3jQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9269 Subject: [libcamera-devel] [PATCH v2] libcamera: v4l2_subdevice: Add JPEG_1X8 and BGR888_1X24 mbus formats to formatInfoMap X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "Xavier Roumegue \(OSS\) via libcamera-devel" From: Xavier Roumegue Reply-To: "Xavier Roumegue \(OSS\)" Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Xavier Roumegue The warnings "Unknown subdev format 0x4001, defaulting to RGB encoding" and "Unknown subdev format 0x1013, defaulting to RGB encoding" are thrown while using simple pipeline handler with NXP ISI hardware. The JPEG_1X8 and BGR888_1X24 media bus formats, supported by the ISI driver, are missing in the V4L2SubdeviceFormatInfo structure storing the correspondence between a media bus format and a colour encoding. So populate the structure with the missing media bus formats. Signed-off-by: Xavier Roumegue Reviewed-by: Umang Jain Reviewed-by: Laurent Pinchart --- src/libcamera/v4l2_subdevice.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp index 9ef95963..37cd63c6 100644 --- a/src/libcamera/v4l2_subdevice.cpp +++ b/src/libcamera/v4l2_subdevice.cpp @@ -68,6 +68,7 @@ const std::map formatInfoMap = { { MEDIA_BUS_FMT_RGB565_2X8_LE, { 16, "RGB565_2X8_LE", PixelFormatInfo::ColourEncodingRGB } }, { MEDIA_BUS_FMT_RGB666_1X18, { 18, "RGB666_1X18", PixelFormatInfo::ColourEncodingRGB } }, { MEDIA_BUS_FMT_RGB888_1X24, { 24, "RGB888_1X24", PixelFormatInfo::ColourEncodingRGB } }, + { MEDIA_BUS_FMT_BGR888_1X24, { 24, "BGR888_1X24", PixelFormatInfo::ColourEncodingRGB } }, { MEDIA_BUS_FMT_RGB888_2X12_BE, { 24, "RGB888_2X12_BE", PixelFormatInfo::ColourEncodingRGB } }, { MEDIA_BUS_FMT_RGB888_2X12_LE, { 24, "RGB888_2X12_LE", PixelFormatInfo::ColourEncodingRGB } }, { MEDIA_BUS_FMT_ARGB8888_1X32, { 32, "ARGB8888_1X32", PixelFormatInfo::ColourEncodingRGB } }, @@ -133,6 +134,7 @@ const std::map formatInfoMap = { { MEDIA_BUS_FMT_SRGGB12_1X12, { 12, "SRGGB12_1X12", PixelFormatInfo::ColourEncodingRAW } }, /* \todo Clarify colour encoding for HSV formats */ { MEDIA_BUS_FMT_AHSV8888_1X32, { 32, "AHSV8888_1X32", PixelFormatInfo::ColourEncodingRGB } }, + { MEDIA_BUS_FMT_JPEG_1X8, { 8, "JPEG_1X8", PixelFormatInfo::ColourEncodingYUV } }, }; } /* namespace */