From patchwork Mon Oct 3 21:21:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 17516 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B4A83C3285 for ; Mon, 3 Oct 2022 21:21:42 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 54BC060A7E; Mon, 3 Oct 2022 23:21:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1664832102; bh=pGyIItIRE998V56f3sGwDeui2rRJe44G2CURlcpOr0k=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=xxpUpLPIr8rxk/5POz5eA6IG8b4h0/fSbfnuMOtPNXSkaXnruoT4r5JGnqTllZccF +5ucK9BmFYaQMsWTS9VRe8thPpSmzinrkHw14IV7aH0sPE88fIT+L0P0w8nC+sD8kb 2qGbuRJ4jt+Ul5NWzRtGuBX9OyOV9UvoH75Kk0aFBtJT3JtkkDIrsRb40xozrLgXIo zUIYYvRZUYiCMLuMia0X+xuENXhQcMHJsJD3ya2Oqx8twRYiQTji0AZvoTpKfN9q6d irOjAqUqMkJ6VjCntKUfYXnBwDCKPt5N5T7NhJ1E5tGD8+7sZ/CJFMmX6iQMGrustt 1wGlQU54HMOXQ== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 87A11601CB for ; Mon, 3 Oct 2022 23:21:40 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="NduYlbWG"; dkim-atps=neutral Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0F0D3A4C for ; Mon, 3 Oct 2022 23:21:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1664832100; bh=pGyIItIRE998V56f3sGwDeui2rRJe44G2CURlcpOr0k=; h=From:To:Subject:Date:In-Reply-To:References:From; b=NduYlbWGJs/6a8/NljgL0Uw+THh8kz77Rrf2sUk3RigGf5S9j4VjXvgXitQxrmvIC LMRLmPQV8DwTGhl+D03YjxE04Jd4pxztTWi2xEGbsidOdBMPbBcec9ljQhWTprwUjZ HQ6+olK+slOBb1G5PBE9jG7J+OtyX5eqjFfN2sxg= To: libcamera-devel@lists.libcamera.org Date: Tue, 4 Oct 2022 00:21:26 +0300 Message-Id: <20221003212128.32429-7-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221003212128.32429-1-laurent.pinchart@ideasonboard.com> References: <20221003212128.32429-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 6/8] libcamera: pipeline_handler: Make registerType() private X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Laurent Pinchart via libcamera-devel From: Laurent Pinchart Reply-To: Laurent Pinchart Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The PipelineHandlerFactory::registerType() function is called by the PipelineHandlerFactory class only. Make it private. Signed-off-by: Laurent Pinchart Reviewed-by: Xavier Roumegue Reviewed-by: Jacopo Mondi --- include/libcamera/internal/pipeline_handler.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h index 46df69dc789a..ebbdf2aa391f 100644 --- a/include/libcamera/internal/pipeline_handler.h +++ b/include/libcamera/internal/pipeline_handler.h @@ -108,10 +108,11 @@ public: const std::string &name() const { return name_; } - static void registerType(PipelineHandlerFactory *factory); static std::vector &factories(); private: + static void registerType(PipelineHandlerFactory *factory); + virtual PipelineHandler *createInstance(CameraManager *manager) const = 0; std::string name_;