From patchwork Mon Oct 3 21:21:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 17512 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id DFA07C3285 for ; Mon, 3 Oct 2022 21:21:36 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1E03F601CD; Mon, 3 Oct 2022 23:21:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1664832096; bh=KvqcdANCeqMf88XLPLtbLZi/p5eiyr6xbGwNV6d227I=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=ovdgyiVS16NfksNO3hhUxeQBKpJNsVqis9uOR9c65Ko4oejjrWPHuTfj5glAaOCsP nRm47Cyk7YFQXRmhS4eYtb/JvqYixK6F/crA+sXh7AKb8+6MXl3q1i+66MW3LJUD+7 S+Jf51wdxbkFIabdk+WFKxLWRZlJWBnETWvo0ZB8UucPn0Dmh7TwvGWPeVxuYGP31g 2500dVDMXJdr7JjCGmckZyFWgnIRbSmsO+OrLSCJ09O+TvoPKFVTWrcGLVG4y5hGFc MaW024UKSqFt66a9UNComrMMrup4MVbyedV4SAc1k1s2aOxF4ilV5A7ASTNu11jwt1 jVcw6cGLloZDg== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id CB5AB601C8 for ; Mon, 3 Oct 2022 23:21:34 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="qJ7Qlysf"; dkim-atps=neutral Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 57016519 for ; Mon, 3 Oct 2022 23:21:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1664832094; bh=KvqcdANCeqMf88XLPLtbLZi/p5eiyr6xbGwNV6d227I=; h=From:To:Subject:Date:In-Reply-To:References:From; b=qJ7Qlysf9+4+F79lmznrGvuKthiKPuT+k02uONEtiw98DcPY8eOdqs/6juKWD+RZ3 Y1306Agy4DZHktTSBHREAIhoNRU6xIaCWEZBfDgbQkysGwUSZl+o1fKyX3zIo0EWqu Uxpg/FigNnQvqdptx1zXKI88PnkAK3PBjLGARylk= To: libcamera-devel@lists.libcamera.org Date: Tue, 4 Oct 2022 00:21:22 +0300 Message-Id: <20221003212128.32429-3-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221003212128.32429-1-laurent.pinchart@ideasonboard.com> References: <20221003212128.32429-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 2/8] ipa: camera_sensor_helper: Make registerType() and createInstance() private X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Laurent Pinchart via libcamera-devel From: Laurent Pinchart Reply-To: Laurent Pinchart Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The CameraSensorHelperFactory registerType() and createInstance() functions are called by the CameraSensorHelperFactory class only. Make them private. Signed-off-by: Laurent Pinchart Reviewed-by: Xavier Roumegue Reviewed-by: Jacopo Mondi --- src/ipa/libipa/camera_sensor_helper.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/ipa/libipa/camera_sensor_helper.h b/src/ipa/libipa/camera_sensor_helper.h index 2042847f29e8..410156efb2ea 100644 --- a/src/ipa/libipa/camera_sensor_helper.h +++ b/src/ipa/libipa/camera_sensor_helper.h @@ -66,15 +66,15 @@ public: static std::unique_ptr create(const std::string &name); - static void registerType(CameraSensorHelperFactory *factory); static std::vector &factories(); -protected: - virtual CameraSensorHelper *createInstance() const = 0; - private: LIBCAMERA_DISABLE_COPY_AND_MOVE(CameraSensorHelperFactory) + static void registerType(CameraSensorHelperFactory *factory); + + virtual CameraSensorHelper *createInstance() const = 0; + std::string name_; };