From patchwork Mon Oct 3 21:21:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 17511 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id DAA0BC327C for ; Mon, 3 Oct 2022 21:21:35 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 96B0C601D0; Mon, 3 Oct 2022 23:21:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1664832095; bh=P9y3UMgZ4IJhFKqKTFUxi/rvpJp6ryIoDA6yp7h1+w8=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=gewhZMmahmp5TKQ07LS4imNtt7xKy6X6nyYM+yYcTJITJr08gv7IfjvcvtiICB/Wf vD2PwPigV/zT0BpPMiqzUrfin8j1Z6t2hZWNHTBIUiNUYwqFjRKMtNqSX5/WVTzQFX 7aWxy4Jj/RIRSPUOYFKKZmRWddYFwwEhA07zXPHddY72WTx6xc8msBn7iLhRsObNGg AqVguGqUlwgCOmtg9VH3RWrcWYkHzEgLqTHon3kpE+pRy4sRISJtx2tvFPICheft0E e7iAWljiJKvaBapoz65lnxVv64yuk4QzP/VUbNCrwzzjYIE0Fz4rIvPZIAJlgLjH2w qAAwviqAgPn6w== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7E54E601CD for ; Mon, 3 Oct 2022 23:21:33 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="uv223wU3"; dkim-atps=neutral Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E3C8C440 for ; Mon, 3 Oct 2022 23:21:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1664832093; bh=P9y3UMgZ4IJhFKqKTFUxi/rvpJp6ryIoDA6yp7h1+w8=; h=From:To:Subject:Date:In-Reply-To:References:From; b=uv223wU3tdLoCPVg8D/aViArPS35zr25d9ISBGOe/VdiisrjJAk3NcDMWva73chwF 7+OTsj1ChidXAaLedH2i66ESSgPMtt6ThuAy6sPD2uV0c4YMspvP1yFOiqovVSmeKn W0cKUYpvAZGgpX4PdQ+/4Uwrevs4ZkN+6hdibWT8= To: libcamera-devel@lists.libcamera.org Date: Tue, 4 Oct 2022 00:21:21 +0300 Message-Id: <20221003212128.32429-2-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221003212128.32429-1-laurent.pinchart@ideasonboard.com> References: <20221003212128.32429-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/8] ipa: camera_sensor_helper: Make factory createInstance() function const X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Laurent Pinchart via libcamera-devel From: Laurent Pinchart Reply-To: Laurent Pinchart Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The CameraSensorHelperFactory::createIsntace() function has no need to modify the factory instance. Make it const. Signed-off-by: Laurent Pinchart Reviewed-by: Xavier Roumegue Reviewed-by: Jacopo Mondi --- src/ipa/libipa/camera_sensor_helper.cpp | 6 +++--- src/ipa/libipa/camera_sensor_helper.h | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp index d4dba4975e17..fde9bf5b8892 100644 --- a/src/ipa/libipa/camera_sensor_helper.cpp +++ b/src/ipa/libipa/camera_sensor_helper.cpp @@ -254,10 +254,10 @@ CameraSensorHelperFactory::CameraSensorHelperFactory(const std::string name) */ std::unique_ptr CameraSensorHelperFactory::create(const std::string &name) { - std::vector &factories = + const std::vector &factories = CameraSensorHelperFactory::factories(); - for (CameraSensorHelperFactory *factory : factories) { + for (const CameraSensorHelperFactory *factory : factories) { if (name != factory->name_) continue; @@ -299,7 +299,7 @@ std::vector &CameraSensorHelperFactory::factories() } /** - * \fn CameraSensorHelperFactory::createInstance() + * \fn CameraSensorHelperFactory::createInstance() const * \brief Create an instance of the CameraSensorHelper corresponding to the * factory * diff --git a/src/ipa/libipa/camera_sensor_helper.h b/src/ipa/libipa/camera_sensor_helper.h index 7351fc7c2928..2042847f29e8 100644 --- a/src/ipa/libipa/camera_sensor_helper.h +++ b/src/ipa/libipa/camera_sensor_helper.h @@ -70,7 +70,7 @@ public: static std::vector &factories(); protected: - virtual CameraSensorHelper *createInstance() = 0; + virtual CameraSensorHelper *createInstance() const = 0; private: LIBCAMERA_DISABLE_COPY_AND_MOVE(CameraSensorHelperFactory) @@ -85,7 +85,7 @@ public: \ helper##Factory() : CameraSensorHelperFactory(name) {} \ \ private: \ - CameraSensorHelper *createInstance() \ + CameraSensorHelper *createInstance() const \ { \ return new helper(); \ } \