From patchwork Sat Sep 3 11:50:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 17286 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 9166FC3272 for ; Sat, 3 Sep 2022 11:50:48 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 081E16202D; Sat, 3 Sep 2022 13:50:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1662205848; bh=VZErR2aNTAD90t6ziUO2u6gIQWdseU3L2BYaHAXim2Q=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=Qm/GTy9OtGY2+KRnfN50vaYn1nRZe7rUNe9m4ZRUNse/1b1IMoEZhJmzaWG1RxWbs V9f3Xu0kZsDDUTquxYMW/3Fx44ditr7fjDBiPhfIVHS3vD7PSpibetZkehlyAY6XAf GoXHBG/P5UgxUx60LoV2Duo2iEFvo/zmjXhXot7h98NCzDsgitIYljDesNSk8r6K2H tQDKc/524820ONtbdWMgIqX7JZUcvFxsQ7MIzjwOrPnz8VvXCFoJMMZfzomOdJfQ3g YhzSaP2h1kQvonaCVmVwT1BNh2VlDO0dJEUT133HdstCmju+q7MEIWjxLm7oUQoW/Z 67l9svmknpxkQ== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 416DF61FBB for ; Sat, 3 Sep 2022 13:50:46 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="De3CciWW"; dkim-atps=neutral Received: from Monstersaurus.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9C32D4A8; Sat, 3 Sep 2022 13:50:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1662205845; bh=VZErR2aNTAD90t6ziUO2u6gIQWdseU3L2BYaHAXim2Q=; h=From:To:Cc:Subject:Date:From; b=De3CciWWlfCn/2ttjbdIutJ7FLzag+zfa00CyDoXxefuX3vcP0ksr2QS55pICI6Rx 3s79MATAujazn7Mj5k4F0usYFwaV1yIDP7QyZ1MPoUVEKPjdWvJFVMzIJzVhZs0sgh oUfw7Fcaf0c8i4f6JXbjK/GBlmYIyIEi1ajMMl88= To: libcamera devel Date: Sat, 3 Sep 2022 12:50:42 +0100 Message-Id: <20220903115042.954797-1-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] libcamera: v4l2_device: Report device node on failure X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Kieran Bingham via libcamera-devel From: Kieran Bingham Reply-To: Kieran Bingham Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" When the V4L2Device fails to open, it is not clear what device caused the failure. The Entity name is presented, but not the device node. Provide it. Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart Reviewed-by: Umang Jain --- src/libcamera/v4l2_device.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp index 1d899657bf7d..29a800a5cee3 100644 --- a/src/libcamera/v4l2_device.cpp +++ b/src/libcamera/v4l2_device.cpp @@ -90,6 +90,7 @@ int V4L2Device::open(unsigned int flags) if (!fd.isValid()) { int ret = -errno; LOG(V4L2, Error) << "Failed to open V4L2 device: " + << deviceNode_ << ": " << strerror(-ret); return ret; }