From patchwork Mon Aug 29 18:58:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marvin Schmidt X-Patchwork-Id: 17239 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B94DCC3272 for ; Mon, 29 Aug 2022 18:59:07 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5953C61FC3; Mon, 29 Aug 2022 20:59:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1661799547; bh=mZ5A/dwYqBmwO3GkG6MkqTcH1a0m6fVilpgJJXRMbbs=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=IYBaXfP2vpcB95maiDrHdtmvPbV75yjw9zab87f8WMz9vQDVpScEucaGsBcjKPD3G Q4aVQFanccDBM503ZD/AVqtaOSoY1xNT8GOC7SBvliG4jICczwGziMZqPwu/JRaHPg Y3S7YZsJsF9CTS0eTaFdg6dIpgQKMfk3vznPEk7e3ZjQOVf+6PBaJPtfcCjgOYxNVB ifKFqgcFRdsa5uLRkIgcpReq7rNESz+njmUeyEy8diTz5Ig6Zmc0MW7VXGala8MotT 8j/VId61Hqqj/guKyYdJhj8+rH4tMfBYvIC3Uz2XlVg6BeMAfPKuWWFoq2jmWuJG6E cOzgPkznqSMLQ== Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id F110161FC8 for ; Mon, 29 Aug 2022 20:59:03 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="HmeHBIyN"; dkim-atps=neutral Received: by mail-ed1-x52d.google.com with SMTP id z2so11369955edc.1 for ; Mon, 29 Aug 2022 11:59:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=P5yH+Wui4qN59uyPB7PWWHAyvw0tGsqkJtFMBz+cyKI=; b=HmeHBIyNkilSXNKAX6wXNqENvd87b8rS/qwvAMYTbQ8E2jJ2VcPg0UVRH4rUxOyEKq EjCSvHPKwcgNTlki4Q6OD+HBIl00lFUvETb0KcsRYl7xGjqfBs0YKcfJwFphGo3pdSWV dhIM6TEU9gO+/Wa21vVyeYvfsxablgK4hqb0AJn2rnnu/nPI8sngoin3qByvtBlNnpKk 7haDGkJ3fofl18RynleaPnOBO8Y7bWfzVwcOfMMe+tP3/qN2+tczBCOg/1bx8I2dBBng tsQxRamb2Ha634+R4tJGqKKmyqHyqGIc/4yeZOpH8m58+V9Qegxz2xJS8aISwXdj1BJm BFpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=P5yH+Wui4qN59uyPB7PWWHAyvw0tGsqkJtFMBz+cyKI=; b=FxSzCdB9DUh/2HdvX0myFb5lnGRFAhvEesGC5TRZTu4KgFa9Oy+ZE6zR0RFAIyAMPc GAuKwE1Wuehqn4lG+lrmOqUPgpC61Y5OT+IukHSMIle4+ux7VPwJl7DCGLFGibuZJ/lG z15r/flwwFscLPxY2jRmniWdA9OxoLZgwKpRDgRvcsHzy8Nw2yFhntPP4dhlH/e87AOD 016Q+ZZ1bLCwtba3ozMivgzn8xcEePqXOhol2LJW6ot90jLW/JKKEDIaQuUQF6vOPT68 hm+08DSYK7p4QGU1pxYFgMWaFKeTBT6TvkGJmQziFpCU8eDHwcli0BDYtTALLZYS8vMC JUcA== X-Gm-Message-State: ACgBeo0Rv2DCuJFuGLYH9wUUHkAS7QrTjpkhy7Wk0buKAqqMVeqg24NT Stce4JT9cnazpcMBtHYlcHcgv9W9q+A= X-Google-Smtp-Source: AA6agR5ZthJ+hAhrvI0EETuYJauUN1jwkzADYS2Xm7j/FKSZ9MQV3zPqSSBcP5U8dAZy8G/zPspQ3w== X-Received: by 2002:a05:6402:1d4e:b0:43d:9822:b4d1 with SMTP id dz14-20020a0564021d4e00b0043d9822b4d1mr17649679edb.212.1661799543153; Mon, 29 Aug 2022 11:59:03 -0700 (PDT) Received: from pythagoras.local (dynamic-077-003-143-111.77.3.pool.telefonica.de. [77.3.143.111]) by smtp.gmail.com with ESMTPSA id 17-20020a170906211100b006fef0c7072esm4828136ejt.144.2022.08.29.11.59.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Aug 2022 11:59:02 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Mon, 29 Aug 2022 20:58:49 +0200 Message-Id: <20220829185849.1884517-4-marvin.schmidt1987@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220829185849.1884517-1-marvin.schmidt1987@gmail.com> References: <20220829185849.1884517-1-marvin.schmidt1987@gmail.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 3/3] ipa: rkisp1: Remove redundant call of std::string::c_str() X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Marvin Schmidt via libcamera-devel From: Marvin Schmidt Reply-To: Marvin Schmidt Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The constructor of libcamera::File takes a const reference to a std::string and clang-tidy's readability-redundant-string-cstr check warns about it: > ../src/ipa/rkisp1/rkisp1.cpp:147:12: warning: redundant call to 'c_str' [readability-redundant-string-cstr] > File file(settings.configurationFile.c_str()); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > settings.configurationFile Signed-off-by: Marvin Schmidt --- src/ipa/rkisp1/rkisp1.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp index 27b4212b..9e3eb7fb 100644 --- a/src/ipa/rkisp1/rkisp1.cpp +++ b/src/ipa/rkisp1/rkisp1.cpp @@ -144,7 +144,7 @@ int IPARkISP1::init(const IPASettings &settings, unsigned int hwRevision, } /* Load the tuning data file. */ - File file(settings.configurationFile.c_str()); + File file(settings.configurationFile); if (!file.open(File::OpenModeFlag::ReadOnly)) { int ret = file.error(); LOG(IPARkISP1, Error)